Module talk:Main page image: Difference between revisions

Browse history interactively

← Previous edit

Content deleted Content added

VisualWikitext

Add topic

Revision as of 05:59, 5 November 2021 edit MSGJ (talk \| contribs) Autopatrolled, Administrators 135,092 edits →Protected edit request on 4 November 2021: Responded to edit request Tag: editProtectedHelper ← Previous edit		Latest revision as of 13:42, 9 September 2022 edit undo DatGuy (talk \| contribs) Edit filter managers, Autopatrolled, Checkusers, Administrators 40,033 edits →Protected edit request on 2022 September 8: Responded to edit request Tag: editProtectedHelper
(3 intermediate revisions by 2 users not shown)
Line 51: ::{{U\|MSGJ}} and {{U\|Coffeeandcrumbs}}: This bug still exists in the module. – [[User:Jonesey95\|Jonesey95]] ([[User talk:Jonesey95\|talk]]) 00:22, 5 November 2021 (UTC) :::{{U\|ProcrastinatingReader}}, do you have time to look at this? I don't see a visible error in [[Wikipedia:Main Page history/2021 June 24\|the archived version]] but <code>-nan</code> is in the source code. --- [[User talk:Coffeeandcrumbs\|<span style="color:blue;">C</span>]]&[[Special:Contributions/Coffeeandcrumbs\|<span style="color:#663366;">C</span> (]][[User:Coffeeandcrumbs\|Coffeeandcrumbs]]) 02:39, 5 November 2021 (UTC) ::::This is happening again at [[:Template:Did you know nominations/Boy Scouts of America (march)]]. – [[User:Jonesey95\|Jonesey95]] ([[User talk:Jonesey95\|talk]]) 06:20, 29 January 2022 (UTC) == Protected edit request on 4 November 2021 == Line 57 ⟶ 58: Please copy change [[Special:Diff/1053614141]] from the samdbox to this template. It resolves the issues seen at [[Template:Main page image/DYK/testcases]] where a red Lua error appears if the image parameter is removed. [[User:GKFX]]<sup>[[User talk:GKFX\|talk]]</sup> 23:32, 4 November 2021 (UTC) :{{done}}<!-- Template:EP --> — Martin <small>([[User:MSGJ\|MSGJ]] · [[User talk:MSGJ\|talk]])</small> 05:59, 5 November 2021 (UTC) == Protected edit request on 2022 September 8 == {{edit fully-protected\|answered=yes}} The formula on line 16 appears to be convoluted? It seems to be the equivalent of <code>math.floor(140 * math.sqrt( page.file.width / page.file.height ) + 0.5)</code>, which reads much more simply to me. The new code also makes it obvious to passers-by what exactly this code is trying to do: downsize the image to an area of 19,600 pixels, preserving aspect ratio. Can the formula on line 16 be changed to the requested code above? [[user:theleekycauldron\|theleekycauldron]] ([[user talk:theleekycauldron\|talk]] • [[Special:Contributions/Theleekycauldron\|contribs]]) (she/her) 02:46, 9 September 2022 (UTC) :{{done}}<!-- Template:EP --> [[User:DatGuy\|DatGuy]]<sup>[[User talk:DatGuy\|Talk]]</sup><sub>[[Special:Contributions/DatGuy\|Contribs]]</sub> 13:42, 9 September 2022 (UTC)