Module talk:Main page image: Difference between revisions

Revision as of 06:21, 29 January 2022

Latest revision as of 13:42, 9 September 2022

(2 intermediate revisions by one other user not shown)

Line 58:

Please copy change [[Special:Diff/1053614141]] from the samdbox to this template. It resolves the issues seen at [[Template:Main page image/DYK/testcases]] where a red Lua error appears if the image parameter is removed. [[User:GKFX]]^{[[User talk:GKFX|talk]]} 23:32, 4 November 2021 (UTC)

:{{done}}<!-- Template:EP --> &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 05:59, 5 November 2021 (UTC)

== Protected edit request on 2022 September 8 ==

{{edit fully-protected|answered=yes}}

The formula on line 16 appears to be convoluted? It seems to be the equivalent of <code>math.floor(140 * math.sqrt( page.file.width / page.file.height ) + 0.5)</code>, which reads much more simply to me. The new code also makes it obvious to passers-by what exactly this code is trying to do: downsize the image to an area of 19,600 pixels, preserving aspect ratio. Can the formula on line 16 be changed to the requested code above? [[user:theleekycauldron|theleekycauldron]] ([[user talk:theleekycauldron|talk]] • [[Special:Contributions/Theleekycauldron|contribs]]) (she/her) 02:46, 9 September 2022 (UTC)

:{{done}}<!-- Template:EP --> [[User:DatGuy|DatGuy]]^{[[User talk:DatGuy|Talk]]}_{[[Special:Contributions/DatGuy|Contribs]]} 13:42, 9 September 2022 (UTC)