Wikipedia:Bots/Requests for approval/ScannerBot: Difference between revisions
Content deleted Content added
ping |
Alexis Jazz (talk | contribs) m script name change (will not change again, if the script is renamed again FTT will remain as a meaningless abbreviation) |
||
| (3 intermediate revisions by 3 users not shown) | |||
Line 1:
<noinclude>[[Category:
#EAFFEA; margin:2em 0 0 0; padding:0 10px 0 10px; border:1px solid #AAAAAA;">
:''The following discussion is an archived debate. <span style="color:red">'''Please do not modify it.'''</span> To request review of this BRFA, please start a new section at [[Wikipedia:Bots/Noticeboard]].'' The result of the discussion was {{BotApproved}}<!-- from Template:Bot Top-->
==[[User:ScannerBot|ScannerBot]]==
{{BRFA help}}
Line 70 ⟶ 72:
:::::::Yes because {{code|.}} and {{code|\.}} have different meanings in regex. [[User:0xDeadbeef|<span style="font-family:Fira Mono,Courier New,monospace">0x<span style="text-transform:uppercase">Deadbeef</span></span>]] <span style="font-family: serif">([[User talk:0xDeadbeef|T]] [[Special:Contributions/0xDeadbeef|C]])</span> 02:30, 17 May 2022 (UTC)
::::::::I know. Just surprised one needs escaping and the other doesn't. Not important, if the code works, it works.  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 10:24, 17 May 2022 (UTC)
:::::::::@[[User:Headbomb|Headbomb]], for what it's worth, I believe it's because some non-python RegEx is enclosed in / . . . /, so <code><nowiki>/</nowiki></code> needs to be escaped, but in python RegEx is just given as a string ' . . . ' ― <span id="Qwerfjkl:1653834173516:
: You'll want to detect primary URLs, or skip archive URLs, changing those will break them. Archive URLs can be 20+ types, it's probably easiest to detect if the twitter URL starts with "/" (example in [[Brandon Clarke]]). -- [[User:GreenC|<span style="color: #006A4E;">'''Green'''</span>]][[User talk:GreenC|<span style="color: #093;">'''C'''</span>]] 16:15, 14 May 2022 (UTC)
::Yeah, I should probably match {{code|[^/]}} or <code><nowiki>[\s=>]</nowiki></code> for it to be primary. [[User:0xDeadbeef|<span style="font-family:Fira Mono,Courier New,monospace">0x<span style="text-transform:uppercase">Deadbeef</span></span>]] <span style="font-family: serif">([[User talk:0xDeadbeef|T]] [[Special:Contributions/0xDeadbeef|C]])</span> 02:07, 15 May 2022 (UTC)
Line 91 ⟶ 93:
:::::So I tried querying the wayback machine api to fix archive.org URLs: [https://gist.github.com/fee1-dead/8428cd954b55d83043f94a1753e91a18] Looking at the preview of the bot's edits, it looks fine. Perhaps it needs an extended trial? <span style="font-family:Iosevka,monospace">0x[[User talk:0xDeadbeef|<span style="text-transform:uppercase;color:black">'''Deadbeef'''</span>]]</span> 08:01, 31 May 2022 (UTC)
::::::<small>(@[[User:The Earwig|The Earwig]]) <span style="font-family:Iosevka,monospace">0x[[User talk:0xDeadbeef|<span style="text-transform:uppercase;color:black">'''Deadbeef'''</span>]]</span> 11:52, 4 June 2022 (UTC)</small>
::::::That's great, as it checks there is a copy in the API, it should be good to go. - [[User:GreenC|<span style="color: #006A4E;">'''Green'''</span>]][[User talk:GreenC|<span style="color: #093;">'''C'''</span>]] 15:35, 4 June 2022 (UTC)
::::::{{tl|BAG assistance needed}} <span style="font-family:Iosevka,monospace">0x[[User talk:0xDeadbeef|<span style="text-transform:uppercase;color:black">'''Deadbeef'''</span>]]</span> 05:28, 12 June 2022 (UTC)
:::::::{{BotApproved}} {{re|0xDeadbeef}} Thanks for your patience. Edits look good. I am fine with the expanded functionality for Wayback links and don't see a need for an extra trial provided you monitor these changes. — [[User:The Earwig|<span style="opacity:0.8;">The</span> Earwig]] ([[User talk:The Earwig|talk]]) 02:35, 13 June 2022 (UTC)
:''The above discussion is preserved as an archive of the debate. <span style="color:red">'''Please do not modify it.'''</span> To request review of this BRFA, please start a new section at [[Wikipedia:Bots/Noticeboard]].''<!-- from Template:Bot Bottom --></div>
| |||