User talk:Mxn/CommentsInLocalTime.js: Difference between revisions

Revision as of 22:08, 18 November 2022

Latest revision as of 18:09, 24 December 2022

(3 intermediate revisions by 3 users not shown)

Line 1:

== Interface-protected edit request on 18 November 2022 ==

{{edit interface-protected|User:Mxn/CommentsInLocalTime.js|answered=noyes}}

This script has a bug causing the browser window to hang unresponsively when encountering certain invalid dates. I will not include triggering examples in this edit request for obvious reasons, but [[User_talk:Thparkth/CommentsInLocalTime.js]] contains two examples (the zeroth of August and the 32nd of August). I found the issue trying to read [[Wikipedia:Dispute_resolution_noticeboard/Volunteering]] which contains the "zeroth of August" string.

Line 9:

:Note the "break glass" fix triggers on [[WP:GAN]], reported by @{{u|Olivaw-Daneel}} [[User_talk:Mxn/CommentsInLocalTime|here]]. I can't look into the actual underlying parsing error immediately but this edit request would be a good band-aid. <span style="border-radius: 3px; padding: 2px; border: 1px solid #808080; font-size: x-small; font-family: Lucida Console, Monaco, monospace">[[User:Thparkth|Thparkth]] ([[User_Talk:Thparkth|talk]])</span> 22:06, 18 November 2022 (UTC)

*{{not done}} as to the immediate edit request. On the gadgets page, users are warned that this script is managed by a single user, {{u|Mxn}} - who is not inactive. As such, Mxn can make any changes to their own script as they see fit. — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] ^{[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]} 23:03, 18 November 2022 (UTC)

::Understood, I mistakenly thought that Mxn would be the person seeing the request :) <span style="border-radius: 3px; padding: 2px; border: 1px solid #808080; font-size: x-small; font-family: Lucida Console, Monaco, monospace">[[User:Thparkth|Thparkth]] ([[User_Talk:Thparkth|talk]])</span> 23:07, 18 November 2022 (UTC)

:@[[User:Thparkth|Thparkth]]: Thank you for narrowing down the issue! The root cause had eluded me [[Special:Diff/962085037|for years]] until I saw the examples you provided. I [[Special:Diff/1129316126|applied a different fix]] that should hopefully address the problem even more rigorously. If you'd like to reach me in the future about something urgent, please post something on my main user talk page or e-mail me, as I'm unable to monitor my watchlist regularly. Thanks again! [[User:Mxn|Minh <span style="font-variant: small-caps;">Nguyễn</span>]]&nbsp;^{[[User talk:Mxn|<span style="display: inline-block;">&#x1f4ac;</span>]]} 18:05, 24 December 2022 (UTC)