Content deleted Content added
→isIpV4Range and isIpV6Range: Reply |
→isIpV4Range and isIpV6Range: Reply |
||
| (One intermediate revision by one other user not shown) | |||
Line 130:
:tl;dr: please consider placing these new functions in module IP rather than here.
:peace. [[User:קיפודנחש|קיפודנחש (aka kipod)]] ([[User talk:קיפודנחש|talk]]) 19:47, 10 January 2023 (UTC)
::@[[User:קיפודנחש|קיפודנחש]] [https://en.wikipedia.org/w/index.php?title=Module:IPAddress/sandbox&diff=1132811434&oldid=1069755838 Here] is a diff with the code at [[Module:IPAddress/sandbox]] and testcases at [[Module talk:IPAddress/testcases]].
::In principal I'm not opposed to having this in [[Module:IP]] instead, but if were going to have two separate modules, which the [[Wikipedia:Templates_for_discussion/Log/2018_July_1#Module:IP|2018 TfD]] thought was for the best, I feel this fits better here than in [[Module:IP]] since it's intended to be easy to use in templates while IP seems to have functions primarily intended for use in Modules. --[[User:Trialpears|Trialpears]] ([[User talk:Trialpears|talk]]) 20:22, 10 January 2023 (UTC)
:::thanks. don't know how i missed them earlier. i have some excuses, but i doubt anyone here will be interested.
:::those functions seem to be in the right place - they do use the functionality of this module, and do belong here, contrary to my previous assumption they do not, which was made before reading the code. thanks.
:::btw, the addition of these functions (retroactively) justifies the inclusion of _isIpOrRange() here...
:::will be good to add testcases, both positive and negative, before merging the sandbox to the module itself.
:::peace. [[User:קיפודנחש|קיפודנחש (aka kipod)]] ([[User talk:קיפודנחש|talk]]) 00:10, 11 January 2023 (UTC)
| |||