Content deleted Content added
m Archiving 1 discussion(s) from Module talk:Location map) (bot |
m Fixed Lint errors on this page (stripped tags) |
||
| (5 intermediate revisions by 3 users not shown) | |||
Line 3:
== Detecting missing parameters, and illogical combinations ==
I want to incorporate the following code: <
|11000000|00110000|00111100|00111111=<!-- valid combinations - do none -->
|#default=[[Category:Location map parameter errors]]
}}{{#ifeq:{{#if:{{{lat_dir|}}}|1|0}}|{{#if:{{{lon_dir|}}}|1|0}}|<!-- valid combination - do none -->|[[Category:Location map parameter errors]]}}</
:{{ping|Redrose64}} I set this up, but with the generic error category instead of a new one, and also with visible messages explaining exactly what the problem is. [[User:Jackmcbarn|Jackmcbarn]] ([[User talk:Jackmcbarn|talk]]) 18:45, 4 February 2015 (UTC)
::
Line 59:
It's my understanding that the {{param|name}} parameter of each map's own defining module or template is intended to be used within a default map caption and/or alt text when no explicit caption is supplied by the transcluding article. There's no requirement, as far as I can tell, that this parameter should be the name of an appropriate article. (That requirement would conflict, in some cases, with the previously mentioned intention; see below for an example) Yet when you view the module or template directly, the table that summarises the data wikilinks the name parameter. This can result in an unintended red link or to a link to a disambiguation page. Can the code that generates this table (wherever that is(?)) be modified not to link the name?
An example of this is [[:Module:Location map/data/United Kingdom Preston]]. In my view, the correct {{param|name}} for this is simply "Preston", but this generates an unwanted link to the disambiguation page [[Preston]]. I don't want to replace "Preston" by "Preston, Lancashire" because that would generate some unnecessarily verbose map captions; in the articles where this map appears, disambiguation isn't necessary as other information in the article makes it clear which "Preston" is being referred to. --<span style="border:1px solid #006000">[[User:Dr Greg|<
:{{ping|Dr Greg}} Should be fixed now. [[User:Jackmcbarn|Jackmcbarn]] ([[User talk:Jackmcbarn|talk]]) 18:41, 2 July 2015 (UTC)
:: {{ping|Jackmcbarn|label1=Jack}} See [[Fernyhalgh Wood]]. [[User:Alakzi|Alakzi]] ([[User talk:Alakzi|talk]]) 19:02, 2 July 2015 (UTC)
Line 66:
:::{{ec}} Thanks, {{ping|Jackmcbarn}}, that seems to work for modules, but not for templates.
:::Unfortunately, I have now just discovered that [[:Template:Location map Scotland Highland]] has a piped name <code>Highland (council area)<nowiki>{{!}}</nowiki>Highland</code>, which is expecting to be linked. Which is the correct specification for what {{param|name}} is supposed to be?
:::I wrote the above sentences before Alakzi's reply. (Can we do something clever to detect the presence of a pipe character?) An example of a "misbehaving" infobox is {{tlx|Infobox UK feature}}. --<span style="border:1px solid #006000">[[User:Dr Greg|<
:::: Only [https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=default&search=Template%3A+intitle%3ALocation+map+intitle%3A-doc+insource%3A%2Fname.*%5C%7B%5C%7B%21%5C%7D%5C%7D%2F&fulltext=Search 16] of them in the Template namespace. [[User:Alakzi|Alakzi]] ([[User talk:Alakzi|talk]]) 19:27, 2 July 2015 (UTC)
:::: And [https://en.wikipedia.org/w/index.php?title=Special%3ASearch&profile=default&search=Template%3A+insource%3A%2F%5C%5B%5C%5B%5C%7B%5C%7B%5C%23invoke%5C%3ALocation+map%5C%7Cdata%2F&fulltext=Search these] are all of the infoboxes which link to the name. [[User:Alakzi|Alakzi]] ([[User talk:Alakzi|talk]]) 19:30, 2 July 2015 (UTC)
Line 113:
== [[Template talk:Infobox civil conflict]] ==
{{resolved}}
Anyone familiar with implementing ___location maps into infoboxes? I feel this infobox would be a great candidate. I tried to do it myself, but couldn't get it to show a map in previews. '''
:It appears that it does support it, but I just didn't know how to use it in an article. My mistake. '''
== Template-protected edit request on 25 March 2016 ==
Line 263:
::Thanks! All the best: ''[[User:Rich Farmbrough|Rich]] [[User talk:Rich Farmbrough|Farmbrough]]'',<small> 22:28, 29 September 2016 (UTC).</small><br />
:::{{re|Rich Farmbrough|Jackmcbarn}} [[Special:Diff/742213785|Done]], I think. On another note, is there a reason why [[Module:Location map/data/USA|some]] data pages are named "Module:Location map/data/<var>place</var>" and [[Template:Location map USA California Southern|others]] are named "Template:Location map <var>place</var>"? [[User:Jc86035|Jc86035]] ([[User talk:Jc86035|talk]]) <span style="display:inline-block;margin-bottom:-0.3em;vertical-align:-0.4em;line-height:1.2em;font-size:80%;text-align:left">Use {{[[Template:Reply to|re]]|Jc86035}}<br />to reply to me</span> 10:39, 2 October 2016 (UTC)
::::{{re|Jc86035}} It's historical. Once upon a time, all maps were defined via templates. Then a new, preferred, module definition was introduced, but the old templates were never converted to the new module format; the software is compatible with both versions. --<span style="border:1px solid #40A040">[[User:Dr Greg|<
:::::{{re|Dr Greg}} Couldn't we just make a bot request to copy data from all the various Template:Location map <var>place</var> pages to Module:Location map/data/<var>place</var>, instead of having two different systems which both have to be supported? [[User:Jc86035|Jc86035]] ([[User talk:Jc86035|talk]]) <span style="display:inline-block;margin-bottom:-0.3em;vertical-align:-0.4em;line-height:1.2em;font-size:80%;text-align:left">Use {{[[Template:Reply to|re]]|Jc86035}}<br />to reply to me</span> 12:49, 2 October 2016 (UTC)
::::::Sounds like a good idea. All the best: ''[[User:Rich Farmbrough|Rich]] [[User talk:Rich Farmbrough|Farmbrough]]'',<small> 13:23, 2 October 2016 (UTC).</small><br />
Line 291:
}}
As reported at [[Template talk:Infobox settlement]], the ___location map of Ukraine disappears when zoom is not 100% in Firefox 47 and 49. For example, try to adjust your zoom and look at the map to the right. I cannot figure this out: can someone else help take a look? —[[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 13:20, 16 October 2016 (UTC)
:For what it's worth, I'm using Firefox 49.0.1 and see no problem at any zoom level.--<span style="border:1px solid #40A040">[[User:Dr Greg|<
::Works for me too. {{ping|Hike395}} Can you provide more info about your setup? [[User:Jackmcbarn|Jackmcbarn]] ([[User talk:Jackmcbarn|talk]]) 02:12, 17 October 2016 (UTC)
Line 323:
== Accuracy ==
Is there a hard limit on the number of locations that can be displayed accurately using the Location+ template? It seems to start randomly off-setting the locations around when I reach 13-15 dots on one map. It doesn't break down completely but the error is enough to make it unusuable. Help? Thanks, [[User:Shannon1|<
:{{ping|Shannon1}} The map code itself can handle huge numbers of points. For example, [[Template:Syrian Civil War detailed map]] has over 5000 points and still looks fine. If you're using {{tl|Location map+}} to use a lot of points, it's possible that you have some extra whitespace, which causes issues. What page do you notice inaccuracies on? [[User:Jackmcbarn|Jackmcbarn]] ([[User talk:Jackmcbarn|talk]]) 22:14, 2 November 2016 (UTC)
::{{ping|Jackmcbarn}} Thanks for the quick reply. I have a test page on [[User:Shannon1/Sandbox_3]], for locations of stream gauging stations in California. The ones in the top left are displaying correctly but the ones further down (RUS, AMR, ANF and SJF) are for some reason located quite a bit further south/west than they should. I checked the coordinates multiple times and can't seem to find the source of the problem. [[User:Shannon1|<
:::{{ping|Shannon1}} The problem was indeed that you had extra whitespace. I removed it and now it looks normal to me. [[User:Jackmcbarn|Jackmcbarn]] ([[User talk:Jackmcbarn|talk]]) 21:16, 4 November 2016 (UTC)
::::Oh wow, that looks much better. Thanks so much! I had no idea that the blank lines affected the display of coordinates. [[User:Shannon1|<
== Template-protected edit request on 31 August 2016 ==
Line 333:
{{edit template-protected|answered=yes}}
Could the sandbox please be merged into the main template? This change makes the {{para|coordinates}} error message clearer and adds the precision tracking category for that parameter. Thanks, [[User:Jc86035|Jc86035]] ([[User talk:Jc86035|talk]] • [[Special:Contributions/Jc86035|contribs]]) <small>Use <span class="nowrap">{{[[Template:Reply to|re]]|Jc86035}}</span> to reply to me</small> 10:48, 31 August 2016 (UTC)
:{{re|Jc86035}} you made a request not 48 hours before this one. This module is somewhat heavily transcluded, used on almost half a million distinct pages. I'm wondering if the changes here are cumulative, or if you intend on making more changes in the very near future? It would be nice to make one edit if possible to something like this. (Just a quick question, cheers) If this is thought to be cumulative, the sandbox does look ready to sync. — [[User:Andy M. Wang|'''''Andy
::{{re|Andy M. Wang}} This is probably my last edit request for now (unless someone breaks it by changing [[Module:Coordinates]], which isn't particularly likely). [[User:Jc86035|Jc86035]] ([[User talk:Jc86035|talk]] • [[Special:Contributions/Jc86035|contribs]]) <small>Use <span class="nowrap">{{[[Template:Reply to|re]]|Jc86035}}</span> to reply to me</small> 09:08, 1 September 2016 (UTC)
:[[File:Yes check.svg|20px|link=|alt=]] '''Done'''<!-- Template:ETp --> — [[User:Andy M. Wang|'''''Andy
:{{ping|Jc86035|Andy M. Wang}} It's clear that this change was never tested, as the code path that adds the tracking category is [[Unreachable code|unreachable]]. To do what you wanted this to do, it would have to be done from [[Module:Coordinates]]. In the future, please don't request or make changes to this module without testing them. [[User:Jackmcbarn|Jackmcbarn]] ([[User talk:Jackmcbarn|talk]]) 00:00, 21 September 2016 (UTC)
Rather than emit an error message ("{{red|Coordinates from [[Module:Coordinates]] and individual coordinates cannot both be provided}}"), it would be friendlier to editors and readers to simply use the value of {{para|coordinates}} when both {{para|latitude}}/{{para|longitude}} and {{para|coordinates}} are provided. The documentation could be updated accordingly. I do not know anything about programming Lua, so I wouldn't know where to start with the sandbox code.
Line 348:
But now it produces something that is way off: [https://en.wikipedia.org/w/index.php?title=User:Tr%C3%B6del/soccer_map&oldid=678810967 see this edit] for what it looked like when I came back today before I started fiddling with the long/lat: https://en.wikipedia.org/w/index.php?title=User:Tr%C3%B6del/soccer_map&oldid=678810967
Does anyone know why the locations would have changed between then and now and what I can do to fix them? Thx in adv! --[[User talk:Trödel|<
: It looks fine to me. The dots aren’t aligned to the same spot but the coordinates aren’t the same so is presumably as intended. But it looks like your screenshot. How exactly is it 'way off'?--<small>[[User:JohnBlackburne|JohnBlackburne]]</small><sup>[[User_talk:JohnBlackburne|words]]</sup><sub style="margin-left:-2.0ex;">[[Special:Contributions/JohnBlackburne|deeds]]</sub> 06:23, 19 December 2016 (UTC)
:: Thanks for the reply. This image shows the downshift: [[:File:Soccer map showing coordinates are off.jpg]] All the coordinates are down by about 1 --[[User talk:Trödel|<
::: I see what you mean. Have a look at it now: I took the version that was having problems and stripped out a lot of white space and that seems to have fixed it. It probably was interpreting the spacing as paragraph breaks and so inserting <nowiki><p></nowiki> tags which was screwing with the layout. If you want spacing for layout you can put as many blank lines as you want inside comments.--<small>[[User:JohnBlackburne|JohnBlackburne]]</small><sup>[[User_talk:JohnBlackburne|words]]</sup><sub style="margin-left:-2.0ex;">[[Special:Contributions/JohnBlackburne|deeds]]</sub> 14:47, 19 December 2016 (UTC)
:Okay, this is a much more widespread problem than I thought. I added a fix to [[Module:Location map/multi]] that will hopefully make this not be a problem at all anymore. [[User:Jackmcbarn|Jackmcbarn]] ([[User talk:Jackmcbarn|talk]]) 17:28, 19 December 2016 (UTC)
::: Thank you both for your help! --[[User talk:Trödel|<
== Dynamic Kartographer maps ==
| |||