|
#REDIRECT [[Template talk:Requested move]]
== Missing error check ==
Hi, {{u|Mr. Stradivarius}}. In case you didn't notice, I redirected {{no redirect|template:move-multi}} to {{tl|requested move}}, so we are now fully live with your module. I've been busy updating redirects and documentation. I just noticed that while you check the '''current''n''''' parameters and report
: {{strongbad|class=error|1=Invalid title detected in parameter "current2"; check for [[Wikipedia:Page name#Technical restrictions and limitations|invalid characters]] and incorrectly formatted [[Help:Interwiki linking|interwiki prefixes]]}}
errors, you didn't do a similar check on the '''new''n''''' parameters, and the module doesn't handle them gracefully, e.g., <nowiki>John Green (author) → [[:John Gr>een]]</nowiki> in a test I did. I created [[Module:Requested move/sandbox]] to work on this, but thought that you could do it in a fraction of the time it would take me. One of these days I'll take some more time to study Lua. Thanks, [[User:Wbm1058|Wbm1058]] ([[User talk:Wbm1058|talk]]) 19:37, 29 April 2014 (UTC)
:This wouldn't be hard to do, but there's a hidden penalty. At the moment, I'm checking for invalid titles by creating a title object with [[mw:Extension:Scribunto/Lua reference manual#mw.title.new|mw.title.new]]. That is an expensive function - every time it is called on a new page, the [[WP:EXPENSIVE|expensive parser function count]] is increased. And if the expensive function count for the whole page goes over 500 while the module is running, it will produce a script error. On a blank page, this would give us a limit of 250 pages (250 current + 250 new), and on a page that already contains lots of expensive parser functions, that number will be less. We can use [[mw:Extension:Scribunto/Lua reference manual#pcall|pcall]] to avoid the script error, but the fallback behaviour would be to treat valid titles as if they were invalid, which is just as bad. This would only be a problem if someone made a move request involving hundreds of pages, though - are you aware of any such requests that have happened in the past? <p>An alternative would be to not use mw.title.new, but to just check for bad characters in the title. This wouldn't increase the expensive function count, but it also wouldn't catch invalid interwiki prefixes. It would, however, have the advantage that we could tell the user exactly what character was invalid, e.g. 'invalid character ">" found in the "new3" parameter'. We could also check the current''n'' parameters with this check, as it seems like it might be useful. Do you think this is a good idea, and if so, what wording would you like for the error message? — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr. Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪ talk ♪]]</sup> 04:50, 30 April 2014 (UTC)</p>
{{Rcat shell|
== Moving over a disambiguation page implies that a multi-move request should be submitted ==
{{R from remote page}}
[[Special:Permalink/606319385#Requested move|This move request]] was submitted as a single move over a disambiguation page. [[Special:Diff/606407870|With this edit]] I converted it to a multi-move request. Just wondering if it might be possible for this module to detect requests to move over disambiguation pages and automatically create a multi-move request that includes the implied move of the dab page, i.e. automatically convert to a multi-move request as I did manually. – [[User:Wbm1058|Wbm1058]] ([[User talk:Wbm1058|talk]]) 02:29, 30 April 2014 (UTC)
}}
|
