Content deleted Content added
MalnadachBot (talk | contribs) m Replaced obsolete font tags and reduced Lint errors. (Task 12) |
Plastikspork (talk | contribs) Remove page from Special:WantedTemplates |
||
| (7 intermediate revisions by 5 users not shown) | |||
Line 9:
:This was actually something that I was going to propose once. However the small form is not so widely used so I am not sure if it's worth it. In the meantime you can do it manually using a parser function, for example [http://en.wikipedia.org/w/index.php?title=Template:D%26D/core&diff=273391176&oldid=271361162]. [[User:Msgj|Martin]]<sup>[[User talk:Msgj|msgj]]</sup> 09:32, 26 February 2009 (UTC)
::Ah... thanks. I wasn't completely sure whether or not that would work in combination with the Meta template. -[[User:Drilnoth|Drilnoth]] ([[User talk:Drilnoth|talk]]) 14:49, 26 February 2009 (UTC)
:::Since this can be ''so'' easily set by doing <
== Taskforce hook and hide subpage ==
Line 105:
With the successful wind up of quite a long chain of changes, it is now possible for me to have a crack at resolving this issue that's been bugging me for a while. Please take a look at the nested examples below and tell me what you see:
<syntaxhighlight lang=wikitext>
{{WikiProjectBannerShell|category=no|1=
{{WikiProject Cutlery|class=FA|priority=low|category=no}}
{{WPBannerMeta/test|class=B|importance=Low|category=no}}
Line 113 ⟶ 114:
{{WikiProject Discworld|category=no|class=GA}}
{{WikiProject Australia|category=no|class=GA|Brisbane=yes|Canberra=yes|Adelaide=yes|NSW=yes|places=yes}}
}}</syntaxhighlight>
The WikiProject Cutlery is an example of the current display when no quality assessment is given. The Discworld banner shows the current display with a class rating, and the Australia banner shows the appearance when a number of taskforces are included. The three Video Games banners demonstrate the new layout; I like to think it is an improvement, not least because the centrelines of each banner will align correctly when a number of them are present on a page, such as [[Talk:Mohammed]]. Thoughts? [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 23:16, 24 February 2009 (UTC)
:It's nice that they're aligned, but I prefer the larger gap personally. [[User:Msgj|Martin]]<sup>[[User talk:Msgj|msgj]]</sup> 23:37, 24 February 2009 (UTC)
Line 119 ⟶ 120:
:::I increased it a little bit more and like it. [[User:Msgj|Martin]]<sup>[[User talk:Msgj|msgj]]</sup> 00:01, 25 February 2009 (UTC)
:::: How about having the WP Name (and task forces aligned to the left) and then have the classes aligned to the right next to the show button (eg: Rated: C [Show]). [[User:Peachey88|Peachey88]] <sup>([[User_Talk:Peachey88|Talk Page]] | [[Special:Contributions/Peachey88|Contribs]])</sup> 04:41, 26 February 2009 (UTC)
:::::I'll put some classes on the cells so you can inflict that on yourself if you want to... <
{{done}} finally. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 16:56, 3 March 2009 (UTC)
:Not quite. On Firefox 3, there is a slightly annoying thing where the project name and class move slightly when showing/hiding their nested forms. [[User:Msgj|Martin]]<sup>[[User talk:Msgj|msgj]]</sup> 23:51, 3 March 2009 (UTC)
Line 134 ⟶ 135:
:::::MilHist have an A-Class assessment checklist, I think. I know I copied someone's into the code for {{tl|Comicsproj}}. [[User:Hiding|Hiding]] <small>[[User talk:Hiding|T]] </small> 13:13, 3 March 2009 (UTC)
(note: I am a [[WP:MHCOORD|coord]] at MILHIST) - MILHIST removes the B-class checklist when an article passes GA, A, FA or FL, as we feel that it is redundant (although there have been a few discussions about the value of GA and if a MILHIST B is higher or equal to it).<br>
MILHIST does not have an A-class checklist for its template, but we ''do'' have [[WP:MH/A]]. Articles passing an A-class nomination must pass those 5 criteria. (FAQ page is [[WP:MH/A?|here]] for the interested) —'''<
*Hmm. I copied it from someone's template, so maybe it is in India's, Australia's, Film's or Africa's. I think those are the ones I've <s>stolen</s> borrowed from. [[User:Hiding|Hiding]] <small>[[User talk:Hiding|T]] </small> 10:59, 5 March 2009 (UTC)
== Category parameter = "none" ==
Line 142 ⟶ 143:
There is some code in the [[Template:WPBannerMeta/sandbox|sandbox]] ([http://en.wikipedia.org/w/index.php?title=Template:WPBannerMeta/sandbox&diff=275788934&oldid=275787387 diff]). Please tell me if this is a good idea and if this code will do the trick. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:16, 8 March 2009 (UTC)
:We'll need to go deeper than that, or it will just produce output like <
:Actually, most of these would have worked straight off. Only {{para|AUTO_ASSES_CAT}} requires any more groundwork, and that's [http://en.wikipedia.org/w/index.php?title=Template:WPBannerMeta/autoassess&diff=275801290&oldid=264270677 now done]. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 13:02, 8 March 2009 (UTC)
::Great. {{done}}. Seems to be working correctly. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 13:18, 8 March 2009 (UTC)
Line 160 ⟶ 161:
::::How would I best add a tracking category for the forced assessments? By adding the same ifexpr at the end of the banner code? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 19:46, 8 March 2009 (UTC)
:Another question, in the "task force" instructions, it says that TF TEXT 1 is required, but it was left out in the original instructions. If TF NAME 1 is used, why would TF TEXT 1 be required and left blank? Thanks for the help! --[[User:Funandtrvl|Funandtrvl]] ([[User talk:Funandtrvl|talk]]) 19:39, 8 March 2009 (UTC)
::It's not really required, it's just a cunning plot to confuse you <
:::Oh, I thought so. Thanks again for the help!! --[[User:Funandtrvl|Funandtrvl]] ([[User talk:Funandtrvl|talk]]) 19:47, 8 March 2009 (UTC)
:--Need some more help, refering to this paragraph, under "Other details": "Normal project banners, which are substituted rather than transcluded, usually show up in Category:WikiProject banners, allowing for a periodic cleanout. Banners using WPBannerMeta do not appear in this category when substituted, making it easier for them to get lost."
Line 211 ⟶ 212:
:I see this issue in Safari 3.2.1 on Mac OS X 10.5.6, regardless of browser window width. I do not see the issue in Firefox 3.0.7, Flock 1.2.7, Camino 1.5.2, or Camino 1.6.6. So, the issue seems to be in IE7 and Safari. ···[[User:Nihonjoe|<span style="color:green;">日本穣</span>]]<sup>[[Help:Japanese|?]] · <small>[[User talk:Nihonjoe|Talk to Nihonjoe]]</small></sup> 00:34, 14 March 2009 (UTC)
:: I see the same thing without javascript. It's probably in the code in /core that displays the project name. [[User_talk:Gimmetrow|''Gimmetrow'']] 02:40, 14 March 2009 (UTC) <br>[[Image:Bannerissue2.png]]
:::I'm just speculating here but in the header section there is <
::::Gosh that screenshot looks terrible! What browser did you say you are using? WhatamIdoing and Nihonjoe: is this the same issue that you were seeing? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 13:39, 14 March 2009 (UTC)
:::::Yikes, that is awful! Ditto the "what browser" question; also, how did you get that display without JavaScript? Or did you enable JS temporarily to take the screenshot? [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 15:39, 14 March 2009 (UTC)
Line 225 ⟶ 226:
For what it's worth, this is what I see on my screen:
<div style="text-align: center;">[[File:Bannerwrappingissue.png]]</
As I say, for me there is only the wrapping on the Molecular and Cellular Biology banner. No big deal; it looks as if there is enough room for it ''not'' to wrap, though. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 10:47, 14 March 2009 (UTC)
:Actually, looking at my screenshot again I can see there is a very slight difference in the height of Medicine & United States (meta) and Biography & Italy (non-meta). [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 12:09, 14 March 2009 (UTC)
Line 241 ⟶ 242:
----
Ok, it seems the main problem is with a set of browsers including Safari and GoogleChrome, whereby the cell widths in the header sub-table are completely screwed over by something. Unfortunately I'm off on holiday in about an hour's time, so unless the random attempt I made in /core/sandbox worked first time, I'm out of this one for a week. But of course, that's why we gave Martin the admin bit <
One thing that I'm sure would be hugely helpful: can someone who's got one of the affected browsers temporarily put
<
#bodyContent * {border: 1px solid red !important;}
</syntaxhighlight>
into their monobook.css and take another screenshot? As you might guess, that gives ''everything'' a red border, which makes it easy to see what's going on. We need to know if the issue is with the way the width is distributed between the three columns of the table, or if the table is not actually filling the entire header cell. Good luck! [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 21:47, 14 March 2009 (UTC)
:[[:File:Wpbm redborders.png]], I think that screenshot is showing the correct things, right? On the left is Firefox, on the right Safari (looked the same as Chrome for me) '''[[user:chandler|chan]][[user talk:chandler|dler]] [[Special:Contributions/Chandler|·]]''' 17:00, 15 March 2009 (UTC)
Line 314 ⟶ 315:
I strongly disagree with the assumption that a custom class template does not need to be able to adapt to multiple configurations. It should still be ''possible'' to design a custom class template that will properly handle both the FULL_QUALITY_SCALE and B_CHECKLIST parameters that are passed to {{tl|WPBannerMeta}}. Not passing these parameters to the custom class template imposes an artificial limitation on what can be done within the template and this is always something that should be avoided in modular programming.<br />While I can understand wanting to discourage people from using a custom class template when it isn't really needed, I wanted to make use of some of the newer class types that are not present in the default class template. In particular, I intend to make extremely heavy use of the Needed and Merge classes as I'm sorting out and overhauling an entire hierarchy of categories and articles with tons of redirects.<br />''"(which is computationally significantly more expensive than a parameter system)"''<br />Are you certain? In most programming languages, switch statements are ''much'' more efficient than cascaded or sequential if statements.<br />I'd like to propose a compromise. Why not pass B_CHECKLIST and FULL_QUALITY_SCALE to the custom class templates and have the default class template continue to use FQS and possibly something like BCHKLST (instead of B_CHECKLIST). This would prevent anyone from doing a simple copy/paste of the default class template as a custom template and still allow those of us who wish to make use of B_CHECKLIST and FULL_QUALITY_SCALE in custom class templates to do so. Passing the real parameter names to the custom class template makes the most sense anyway as it makes it clear that these are the same parameters that are used for {{tl|WPBannerMeta}} itself.<br />--[[User:Tothwolf|Tothwolf]] ([[User talk:Tothwolf|talk]]) 01:42, 26 March 2009 (UTC)
:Now this is an interesting idea, which may well be workable. I'll have a think, but I can't see any immediate reason why this wouldn't work.
:The mask system uses an #ifexist: statement to check whether the custom mask exists or not, which is three orders of magnitude heavier on the servers than either #switch: or #if:/#ifeq:. So while you're right about nested ifs vs switches, the #ifexist: blows that completely out of the window. Fortunately, we [[WP:PERFORMANCE|don't need to worry]] about load on the servers, only on how our code affects the end-user. Just FYI <
::I forgot about the #ifexist: in the parent code. Still, even with [[WP:PERF]] there's no point in using an expensive parser function if its not needed.<br />Is there a reason #ifexist: was used instead of passing a parameter to {{tl|WPBannerMeta}} pointing to the custom class template? If done as a parameter, it would be possible to keep different flavours of class templates with {{tl|WPBannerMeta}} itself. Perhaps something like <code>CUSTOM_CLASS_MASK = full_path/to/template</code>? [[User:Tothwolf|Tothwolf]] ([[User talk:Tothwolf|talk]]) 16:41, 26 March 2009 (UTC)
:::That would be rather bizzarre centralisation: the whole point of the mask system is to move control over which classes are supported to the invidual banners, ''away'' from the core code that has to be shared with every project. There is no need to require the banner coder to specify in a parameter what can be determined automagically. The point of [[WP:PERF]] is to say "ignore the performance impact ''at our end'', do whatever is best ''for the reader/user'' and we'll pick up the pieces as far as possible". [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 18:10, 26 March 2009 (UTC)
Line 320 ⟶ 321:
:::::Nothing wrong with a redirect; that could be just moving the mask to a more convenient ___location. Difficult to check if a custom mask is blank, but the ''other'' reason to 'outsource' the masks is to say "you use a mask, it's your problem if things go wrong". Obviously if people come here saying "my banner's broken" we can check and quickly see what the problem is, and fix it; but trying to build exception handling into wikitext is a fundamentally Bad Idea: it's a markup, not a programming language. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 18:45, 26 March 2009 (UTC)
::::::Well, I'm wondering if it might be better to have the custom mask template specified as a parameter to {{tl|WPBannerMeta}} because it would allow someone without the admin bit to remove the custom mask template from their project banner. With the current #ifexist: check it isn't possible for a non-admin to effectively remove the custom mask template from a project banner because even if they blank the custom class template or move it elsewhere the parent code is still going to try to use it. Just something to think about anyway I guess... [[User:Tothwolf|Tothwolf]] ([[User talk:Tothwolf|talk]]) 18:58, 26 March 2009 (UTC)
:::::::That's what {{tlx|db-g6}} is for <
::::::::Not everyone knows about the speedy delete templates or how to use them though. It is a minor issue, but still something that could be confusing for people who haven't looked at the code used by {{tl|WPBannerMeta}}. Maybe this is something that could go on the to do list for the next update? [[User:Tothwolf|Tothwolf]] ([[User talk:Tothwolf|talk]]) 20:36, 26 March 2009 (UTC)
:::::::::If you mean a more rigorous check for if the custom mask 'exists', that can be done. My ''personal'' reaction to the parameter suggestion is {{wontfix}}. Of course this isn't bugzilla; there may be consensus to the contrary, but I don't think such a move is a Good Idea. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 20:58, 26 March 2009 (UTC)
Line 345 ⟶ 346:
</nowiki> to a few cat talk pages today, a new red-linked page at the bottom of the transclusion list shows up, only if one adds the "importance" parameter, along with the "class" parameter; it doesn't show up with just the "class" parameter. This only displays in the "edit" mode. For an example, see: [http://en.wikipedia.org/w/index.php?title=Category_talk:Former_United_States_Executive_Cabinet_positions&action=edit
Template:WikiProject United States/class] and look at the bottom of the opened "edit" page. Just wondering! --[[User:Funandtrvl|Funandtrvl]] ([[User talk:Funandtrvl|talk]]) 22:42, 26 March 2009 (UTC)
:Hmn, this is interesting. This is a result of my recent change to how the template looks for custom masks (see [[#Please pass parameters FQS and B CHECKLIST on to custom overrides of WPBannerMeta.2Fclass|above]]). I changed from using the <
:Filed, {{phab|20188}}. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 23:07, 26 March 2009 (UTC)
::Oh-oh, see what you did and look what I started!! :) Thanks --[[User:Funandtrvl|Funandtrvl]] ([[User talk:Funandtrvl|talk]]) 00:32, 27 March 2009 (UTC)
Line 365 ⟶ 366:
{{tlx|editprotected}}
Some projects are using a "bottom" option for importance (see [[Template:Bottom-importance]] and [[:Category:Bottom-importance articles]]). This template does not seem to support it at the moment (see the WPRocketry template on [[Talk:Cape Canaveral Air Force Station Launch Complex 1]]). Would it be possible to enable support for it. Thanks. --'''''[[User:GW Simulations|<
:Please see [[/Archive 3#Bottom-importance]]. —[[User:Ms2ger|Ms2ger]] ([[User talk:Ms2ger|talk]]) 08:51, 29 March 2009 (UTC)
::There is actually a greater use of {{tl|No-importance}}, though I suppose that would be handled by the meta in the same way? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 11:32, 29 March 2009 (UTC)
Line 373 ⟶ 374:
|bottom = Bottom
</pre>
:Inserted between the fourth and fifth lines of [[Template:WPBannerMeta/importance]]. Am I missing something? --'''''[[User:GW Simulations|<
::That most projects don't want to use No- and/or Bottom-importance. —[[User:Ms2ger|Ms2ger]] ([[User talk:Ms2ger|talk]]) 15:12, 29 March 2009 (UTC)
:However some do, and providing the means for these projects to use this template should not affect those that do not. The fact that a feature is enabled doesn't mean it has to be used. Some projects don't have rating, but the template still provides a means to rate articles. --'''''[[User:GW Simulations|<
::If a project does not use bottom-importance then it would not usually be desirable for the template to accept such a rating, as it would be classifying articles into non-existent importance classes and categorising into non-existent categories. I agree that this issue is something which needs to be thought about though. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:33, 2 April 2009 (UTC)
::The issue is that by adding the functionality in the manner you suggest, we unavoidably add it for ''all projects'' using WPBM. This means that setting {{para|importance|bottom}} on ''any'' banner will mark it as "Bottom-importance", whether the necessary infrastructure (categories, assessments, project support) exists or not. This is unlike custom quality classes where the class is added only for that project, and is not 'forced' upon all projects. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 18:18, 2 April 2009 (UTC)
Line 475 ⟶ 476:
:Got a [http://en.wikipedia.org/w/index.php?title=User_talk:Happy-melon&diff=281945711&oldid=281945490 vote] for the new icons over on my talk page. Seems there's mixed opinion. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 19:19, 5 April 2009 (UTC)
::How feasibile would it be to have a parameter in the meta to turn the icons on or off? [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 19:22, 5 April 2009 (UTC)
:::Easily feasible, but utterly pointless. If we can't agree I'll just wrap the icons in some classes so people can hide or show them with CSS to suit, like we did with the vde links... I bet you don't even remember that they're still there, do you? <
::::vde links? I was thinking a parameter would allow the decision to be made at project level. [[User:PC78|PC78]] ([[User talk:PC78|talk]]) 19:43, 5 April 2009 (UTC)
:::::Told you <
<
.wpb .assess img {display: none;}
.wpb .assess-fa img,
Line 484 ⟶ 485:
.wpb .assess-a img,
.wpb .assess-ga img {display: inline;}
</syntaxhighlight>
:::::Will hide all the icons, then show the FA/FL/A/GA ones. Which gives you complete personal control over which icons to hide and which to show (you don't like the A-Class one, don't have it!) Of course if you only include the first line, you can be rid of the icons completely. Personal choice, which I'm a big fan of. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 21:38, 5 April 2009 (UTC)
Line 496 ⟶ 497:
:You're probably right. {{done}}, with a bit of unwanted tag nesting, but still reasonably cleanly. You can now show or hide the images to your heart's content with
<
.wpb .assess * { display: inline; } /* show all */
.wpb .assess-b * { display: inline; } /*show B-Class*/
</syntaxhighlight>
:Hopefully this will make everyone happy. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 14:52, 8 April 2009 (UTC)
::I support the decision to hide B-class and lower icons, but wonder why I'm not seeing GA icons (as, for example, at [[Choral symphony]], which I've never viewed before [so no cache issue?]), while I do see FA icons (as at [[Florida Atlantic University]]). (Firefox 3, MacOs X, if that makes any difference.)
::Also, I note that editors who want to automatically see the class of an article they're viewing can also select the gadget "Display an assessment of an article's quality as part of the page header for each article". That places some text, such as "A B-class article from Wikipedia, the free encyclopedia" immediately under the name of an article.-- <
:::Hmn, they display for me, both logged-in and logged-out, on FF3 and IE7. Are you looking in the right place? These are the icons that display inside WikiProject banners, in the (in this case green) box to the left of the "this article has been rated as GA-Class" notice. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 20:16, 8 April 2009 (UTC)
:::Me too. Me thinks that John might be thinking about the featured article star which appears on the article itself. I don't think there has ever been an equivalent for good articles. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 20:17, 8 April 2009 (UTC)
::::Indeed; there have been occasional attempts to introduce a parallel GA icon in that ___location, but none have ever gained consensus. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 10:14, 9 April 2009 (UTC)
:::: Yes, my misunderstanding. Thanks for the clarification. -- <
== ''yesno'' ==
What is the reason that all the parameters use {{tl|yesno}}? Especially the ''NOTE'' parameters. For example, in our project, we are trying to have our old peer review link to a custom page, usually because the paged was reviewed and then moved. We tried to put <
:{{tlx|yesno}} is used to 'normalise' the value of 'trigger parameters' so they behave more as you would intuitively expect. For instance, editors might expect to be able to trigger a note with {{para|foo|yes}}, but also with {{para|foo|YES}} or perhaps {{para|foo|1}}. On the other hand, you would intuitively expect {{Para|foo|no}} to ''not'' trigger the note. The yesno template makes these responses consistent across all the trigger parameters, and provides one central ___location where we can define and control these responses.
:In response to your actual issue, I've added a new parameter, {{para|title}}, to the peerreview hook that you can use to specify the old title, I think this should work the way you want. Let me know if it doesn't. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 11:25, 7 April 2009 (UTC)
::It works, but I was hoping to not have another parameter. If {{tlx|yesno}} wasn't used, then it could just check if <
:::But then if someone from WikiProject Tulips comes along and tags an article, and innocently thinks "no this article hasn't had a peer review, better set {{para|peer-review|no}}", then he's quite rightly surprised when he gets the same result as setting {{para|peer-review|yes}}.
:::It's possible to use a layer of logic on your WikiProject banner (which one is it, BTW?) to be able to use only one parameter for the 'end user', and split them into two to be passed on to WPBM. It would look something like:
| |||