MediaWiki talk:Common.js/Archive 5: Difference between revisions

Revision as of 16:44, 8 October 2016

Latest revision as of 22:59, 22 June 2024

(2 intermediate revisions by 2 users not shown)

Line 136:

::: That are only the static CSS and JS files, not ones editable on-wiki. No idea if those significantly contribute to the bandwidth usage as well? —''[[User:Ruud Koot|Ruud]]'' 21:02, 1 April 2007 (UTC)

What does it do? At first glance it doesn't seem to have any use outside of other user-scipts (which can just as easily import it themselves.) —''[[User:Ruud Koot|Ruud]]'' 21:02, 1 April 2007 (UTC)

:Also, does <ttcode>Common.js</ttcode> really need [[Object-oriented programming|OOP]] techniques? The smaller is the better, imho — [[User:Alex Smotrov|Alex Smotrov]] 21:29, 1 April 2007 (UTC)

::That's just a minor thing, the idea first is to only parse the query string once. second point is to use correct encoding, as some has been using wrong function for that (window.escape()), and to do it transparent. _{→[[User:AzaToth|<span style="color:#773">Aza</span>]][[User_talk:AzaToth|<span style="color:#359">Toth</span>]]} 21:34, 1 April 2007 (UTC)

:::For something unlikely to be used often, wouldn't it be just as well to put the burden on the client side (extra parsing) rather than on the servers (extra bandwidth for longer code)? See below (obviously just an example). --[[User:Splarka|Splarka]] ([[User_talk:Splarka|rant]]) 07:18, 2 April 2007 (UTC)

Line 153:

</pre>

}}

The above is basically from Lupin's popups, no? Or somewhere else before that, given the nature of much javascript code. Now, my opinion really doesn't matter here (not really that professional a javascript coder), but it might be useful to have one standardized function related to query strings, since a lot of scripts need them, and said scripts have their own query functions. So if those scripts are used together, you have (possibly) three or four query string functions altogether, which doesn't strike me as that efficient. Creating and getting query strings sounds useful; the rest, not as much. [[User:Gracenotes|<fontspan colorstyle="color:#960;">Grace</fontspan><fontspan colorstyle="color:#000;">notes</fontspan>]]^{[[User talk:Gracenotes|<fontsup colorstyle="color:#960;">T</fontsup>]]} § 14:29, 2 April 2007 (UTC)

As [[WP:TW]] is probably the only script as of yet using QueryString (by some freak coincident), the number of calls to QueryString as of yet is 59 times. _{→[[User:AzaToth|<span style="color:#773">Aza</span>]][[User_talk:AzaToth|<span style="color:#359">Toth</span>]]} 14:45, 2 April 2007 (UTC)

:I have added an {{tl|editprotected}} to the top of the page. So, which parts of this are we going to implement? All of it? Static? Object? Certain methods, and not others? [[User:Gracenotes|<fontspan colorstyle="color:#960;">Grace</fontspan><fontspan colorstyle="color:#000;">notes</fontspan>]]^{[[User talk:Gracenotes|<fontsup colorstyle="color:#960;">T</fontsup>]]} § 19:37, 4 April 2007 (UTC)

::I think this is the sort of thing that is more appropriate for [[WP:US]]. Maybe I'm missing the point, but I don't see why this needs to be in the site-wide js, unless it is likely to be used by a general reader or editor. [[User:CMummert|CMummert]] · <small>[[User talk:CMummert|talk]]</small> 16:55, 5 April 2007 (UTC)

::: I agree with this. —''[[User:Ruud Koot|Ruud]]'' 20:41, 5 April 2007 (UTC)

:::: Sorry, I was away a bit. My only problem with this is that I need query string scripts, so I'll have to include my own. And if someone else needs to include them, they'll have to include their own. And all these functions for doing the same thing need to load, rather than having one standardized function. No matter, eh. [[User:Gracenotes|<fontspan colorstyle="color:#960;">Grace</fontspan><fontspan colorstyle="color:#000;">notes</fontspan>]]^{[[User talk:Gracenotes|<fontsup colorstyle="color:#960;">T</fontsup>]]} § 22:53, 7 April 2007 (UTC)

::::: No, <code>importScrtipt</code> will only load a script once, even if it is included multiple times. —''[[User:Ruud Koot|Ruud]]'' 11:17, 8 April 2007 (UTC)

:::::: Do you know of a library that has this code? [[User:Gracenotes|<fontspan colorstyle="color:#960;">Grace</fontspan><fontspan colorstyle="color:#000;">notes</fontspan>]]^{[[User talk:Gracenotes|<fontsup colorstyle="color:#960;">T</fontsup>]]} § 19:24, 8 April 2007 (UTC)

::::::: Uhh... AzaToth just wrote the code? He now only has to locate it somewhere (in his userspace or at [[WP:US]] for example) in list it at [[WP:US]]. —''[[User:Ruud Koot|Ruud]]'' 19:46, 8 April 2007 (UTC)

::::::: Yeah, it doesn't exist now. [[User:Gracenotes|<fontspan colorstyle="color:#960;">Grace</fontspan><fontspan colorstyle="color:#000;">notes</fontspan>]]^{[[User talk:Gracenotes|<fontsup colorstyle="color:#960;">T</fontsup>]]} § 22:45, 8 April 2007 (UTC)

As to show you why it's so "complicated", I'm using it for example to create things like this (though I'm usually tries to make it asyncronus, it's syncrone here for the ease of typing):