Module talk:Random slideshow: Difference between revisions

Revision as of 18:07, 30 September 2022

Latest revision as of 18:36, 20 August 2024

(10 intermediate revisions by 2 users not shown)

Line 1:

{{WikiProject Portals}}

{{central|text=the talk pages for the following templates redirect here:

<div style="font-size:95%">{{flatlist|

Line 5 ⟶ 4:

*{{tl|Transclude&nbsp;files&nbsp;as&nbsp;random&nbsp;slideshow}}

}}</div>

}}

{{WikiProject banner shell|

{{WikiProject Portals}}

}}

{{archives|age=60|small=no|bot=Lowercase sigmabot III}}

Line 77 ⟶ 79:

Note the undesirable presence of <code><nowiki>thumb|</nowiki></code> in the former example. It looks like the module attempts to strip out "thumb" and similar parameters from gallery entries, but in this case, it appears to have failed. This "thumb" problem appears to be happening in a just a couple of Portal pages, but there are similar errors in [https://en.wikipedia.org/wiki/Special:LintErrors/bogus-image-options?namespace=100 a dozen or so Portal pages], so fixing it in the module would be best. There are a few more instances of complex markup in image captions failing to be stripped or parsed correctly (e.g. "Map of counties in Missouri by racial plurality, per the 2020 US Census" from [[Missouri]]). I'm hoping a change to the regex in the module will be sufficient. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 20:43, 16 September 2022 (UTC)

:{{ping|Jonesey95}} In the case of the lastMarine issuehabitats, that appearance of <code>thumb</code> appears to be more of a case of [[GIGO]] than the module's fault. The image causing issues there is from a {{tag|gallery}}, and images in galleries do not support the <code>|thumb|</code> option (or at least not as far as I can tell), so the module never expects to have to remove it. I've removed the occurance of it from the article it's on, but correct me if I'm wrong on this call. [[User:Aidan9382|Aidan9382]] _{([[User talk:Aidan9382|talk]])} 18:07, 30 September 2022 (UTC)

::As for the errors appearing on some of the other portal pages, like [[Portal:Pennsylvania]] (the issue lies in <code>File:Pennsylvania Counties by race (2020 census).svg</code> from [[Pennsylvania]]) is because of the fact that the description includes tables and templates, which, due to one reason or another (potentially due to the more limited form of gallery compared to files, but im not sure), isn't going to work or display nicely in the slideshow. In terms of fixing that, I'm not exactly sure what to recommend, as what the issue is ''specifically'' is hard to pin down. Any ideas? [[User:Aidan9382|Aidan9382]] _{([[User talk:Aidan9382|talk]])} 18:58, 30 September 2022 (UTC)

:::As I suggested in the other discussion, maybe one solution is to render the file on its own, then insert a line break and then render the caption without any processing, outside of the File: invocation. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 20:25, 30 September 2022 (UTC)

::::I have created [[Template:Transclude files as random slideshow/testcases2]] to demonstrate two of these errors. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 14:01, 2 October 2022 (UTC)

:::::Came across this issue again while investigating something else, so I decided to take a look. The primary issue lies in how galleries work, and how they don't respect tables that well, and unfortunately I'm not sure if this has a simple solution. I've left my findings on what I've noticed on [[Special:Permalink/1116592103|this page]] with examples, which should explain it well. As for solutions, the only idea I have is preventing the expansion of templates, but I have yet to test this, and I'm not sure if the expansion is currently intentional for a different reason. [[User:Aidan9382|Aidan9382]] _{([[User talk:Aidan9382|talk]])} 10:16, 17 October 2022 (UTC)

::::::{{ping|Jonesey95}} Good news - after quite a touch up today with how the module works and some more light work yesterday, I've mostly fixed the 2 main causes of the bogus file option linter errors, bringing down the total number of errors from what I think was ~140 to ''10'' (and a few are human errors, not the module). I'm going to do a minor look into weird upright inclusion behaviour after this post, but as far as I can see the new version is working fine, though if you notice any issues or have suggestions, do tell me. Hope this helps. [[User:Aidan9382|Aidan9382]] _{([[User talk:Aidan9382|talk]])} 12:16, 4 November 2022 (UTC)

::::::...iiiiif I didn't run into issues, which apparently seems to be impossible with me :). Turns out [[Module:Excerpt slideshow]] was quite unhappy with what I tried and blew up on the spot, so I also now have to go fix that. If the linter errors are back to below 15, I've found a fix before you've seen this. If not, hopefully I will soon after. [[User:Aidan9382|Aidan9382]] _{([[User talk:Aidan9382|talk]])} 12:31, 4 November 2022 (UTC)

:::::::Thanks for continuing to work on it. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 13:16, 4 November 2022 (UTC)

== Link to transcluded article ==