Wikipedia:Bots/Requests for approval/TFA Protector Bot: Difference between revisions
Content deleted Content added
Josh Parris (talk | contribs) →Trial: I'm Josh Parris, and I approved this edit |
m Fix Linter errors. |
||
| (2 intermediate revisions by 2 users not shown) | |||
Line 60:
*:Alternatively, [[WP:FAP]] could be revived, cascade protected and the bot could transclude all the templates from TFA onto that page, instead of protecting each template. <strong style="font-variant:small-caps">[[User:WJBscribe|WJBscribe]] [[User talk:WJBscribe|(talk)]]</strong> 22:51, 9 May 2013 (UTC)
*::That sounds like a better idea to me. I think that we should stick to just move protection for this task, and look into using [[WP:FAP]] in another BRFA. [[User:Legoktm|Legoktm]] ([[User talk:Legoktm|talk]]) 04:21, 13 May 2013 (UTC)
*I'm hopeless at python, and I still am not used to legoktm being highlighted blue now. but I don't see any issues with this bot.—[[User:C678|<span style="color:green;font-family:Neuropol">cyberpower</span>]] [[User talk:C678|<sup style="color:olive;font-family:arnprior">Chat</sup>]]<sub style="margin-left:-4.4ex;color:olive;font-family:arnprior">Online</sub> 03:17, 10 May 2013 (UTC)
I reviewed the code, and I have the following comments/questions:
Line 66:
# I see the bot is supposed to run at 5 minutes before midnight. If this is somehow delayed, it looks like the bot will skip today and go protect tomorrow's FA instead.
# What happens if the listed FA title happens to be a redirect? Will it move-protect the page or the redirect? For that matter, what makes sense for it to do there? Off the top of my head, it seems that move-protecting the page and both move- and edit-protecting the redirect would make the most sense.
# I note the query you are performing will set the protections to just move protection, removing any other protection (e.g. edit protection). This is obviously not right. <small>While {{
# I wonder if the bot should try to restore the old move semi-protection after the page is off the main page.
Item #4 is a blocking problem. HTH. [[User:Anomie|Anomie]][[User talk:Anomie|⚔]] 12:32, 13 May 2013 (UTC)
Line 107:
@[[User:Legoktm|Legoktm]] any progress on #3 and 4? Apart from those I'm happy to approve the bot for a trial. --[[User_talk:Chris G|<span style="color:Green; font-weight: bold;">Chris</span>]] 13:02, 24 June 2013 (UTC)
:Responded above. [[User:Legoktm|Legoktm]] ([[User talk:Legoktm|talk]]) 08:11, 26 June 2013 (UTC)
*Ooh, this new (to me me at least :P) notification feature is cool. I uploaded the source code for my old bot [[user:east718/tfabot|here]], maybe you can crib some ideas like IRC notifications or move vandalism done shortly before the protection cronjob. I know for sure that questions #3 and #4 are accounted for in my bot, I learned those mistakes the hard way. Be aware that my code is uncommented, messy (and that's being charitable), and was built on top of a fork of a now five year old version of pywikipedia. Good luck with your bot. <span style="white-space:nowrap">— [[user:east718|<
**Thanks! If the bot protects as soon as the page is selected, it should reduce the chance of page-move vandalism, but a separate IRC bot notifying that it was recently moved is a good idea. I'll try and write a bot to do that soon. [[User:Legoktm|Legoktm]] ([[User talk:Legoktm|talk]]) 08:11, 26 June 2013 (UTC)
{{tlx|OperatorAssistanceNeeded|D}} Is this still an active bot request or has this gone stale? [[User:Hasteur|Hasteur]] ([[User talk:Hasteur|talk]]) 18:58, 31 July 2013 (UTC)
| |||