Content deleted Content added
→great and powerful script: new section |
|||
| (16 intermediate revisions by 6 users not shown) | |||
Line 81:
== Tests not failing when they should ==
I'm creating testcases for [[Module:GetShortDescription]] and [[Module:
:"Test methods like test_hello above must begin with 'test'". I knew that. <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 09:45, 27 January 2023 (UTC)
:Might I suggest not outputting "All tests passed." when no tests have been run? <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 11:18, 27 January 2023 (UTC)
Line 93:
::Sounds good to me! Definitely think of the maintainability of the code ahead of the minor convenience of only having one option to consider. Personally; I think <code>combined</code> is better. Thank you for your consideration 😊 <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 09:46, 28 January 2023 (UTC)
:::{{ping|Fred Gandt}} I've managed to get some initial work done on this (currently got the main functions <code>preprocess_equals(_many)</code> and <code>preprocess_equals_preprocess(_many)</code> running under the new system idea in the sandbox) - Does the format I've given seen fine in your testcases? I don't want to start working on the more complicated to convert functions unless it's all working fine. You can test these by changing <code>require('Module:UnitTests')</code> to <code>require('Module:UnitTests/sandbox')</code> and specifying <code>combined</code> instead of <code>nowiki</code>. [[User:Aidan9382|Aidan9382]] <sub>([[User talk:Aidan9382|talk]])</sub> 14:41, 28 January 2023 (UTC)
::::Really; that looks great! Very neat table organisation. I hope all your effort is appreciated by more than just me, but rest assured I am impressed. Seeing the raw markup is great for technical analysis, but seeing the result is great for rapid detection of issues. Having them side by side (well over and under but same thing) like that is a quality of life improvement. Thank you 😊 <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 16:07, 28 January 2023 (UTC)
== Present failed tests together at the top ==
Line 99 ⟶ 100:
:I'll try theory this in the sandbox too. [[User:Aidan9382|Aidan9382]] <sub>([[User talk:Aidan9382|talk]])</sub> 09:37, 28 January 2023 (UTC)
::I will prepare a WikiLove goat for you! Seriously though; thanks again for you consideration ❤ <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 09:46, 28 January 2023 (UTC)
::Some wild yellow backgrounds have appeared 👀 😉 <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 16:13, 28 January 2023 (UTC)
:::Ooooh yes, forgot I implemented that. There was a feature only in preprocess_equals_preprocess where failed tests were highlighted orange/yellow so they were easier to spot - I decided to give it a test run in the sandbox to make it apply the highlighting to more functions and completely forgot I did so. I'll probably make it an opt-in argument of the <code>#invoke:</code> (maybe <code>|highlight=</code>, a bit like <code>|differs_at=</code>).
::::<small>(changed to an invoke option - [[User:Aidan9382|Aidan9382]] <sub>([[User talk:Aidan9382|talk]])</sub> 16:43, 28 January 2023 (UTC))</small>
:::Oh, and I'm currently working on doing the split of failed and successful results from above, though I'm gonna have to think about how to do multi tests if they fail in the middle (I'm not sure they split too well right now, but we'll see). [[User:Aidan9382|Aidan9382]] <sub>([[User talk:Aidan9382|talk]])</sub> 16:32, 28 January 2023 (UTC)
::::I understand and fully appreciate how complex it is; there's no hurry or even need for this nice-to-have feature request. Don't forget to have a good day while you're working on it. <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 16:44, 28 January 2023 (UTC)
:::::Alright, I've decided ''not'' to implement the splitting with headers - screwing with the positional layout, especially with functions that do multiple checks in one run, is a bit more complicated and finicky than I think it's worth. Hopefully the highlight feature helps enough with finding the errors enough in that regard. As for everything else, I'll be moving that from the sandbox version to the live version some point soon when im free, and I'll also make sure to update the doc page (it's missing both the new stuff and some already existing stuff). [[User:Aidan9382|Aidan9382]] <sub>([[User talk:Aidan9382|talk]])</sub> 18:56, 28 January 2023 (UTC)
::::::Understood. I hope it didn't trouble you too much trying, and again, I really appreciate the effort. I made a little helper script, [[User:Fred Gandt/moveFailedModuleTestsToTop.js|moveFailedModuleTestsToTop.js]], that shifts all the failures to the top on load. It's dirt simple and could do with extra qualification; would you mind if the tables include something like <code>class="wikitable module-unit-tests-result"</code> so the script can be more particular? I nearly went ahead and stuck it in there myself, but considered that might be a bit rude. I should have the script to pick out sets of tables where results of multiple invocations are present... <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 01:51, 29 January 2023 (UTC)
:::::::Don't worry about any trouble I had doing this, coding is a big hobby of mine and I enjoy fixing up stuff like this. I've gone ahead and added the class to the table headers and called it <code>unit-tests-result</code>. I don't think it would've been rude to add the class yourself, it's a simple minor improvement and it doesn't screw with the existing layout, so it's completely fine. [[User:Aidan9382|Aidan9382]] <sub>([[User talk:Aidan9382|talk]])</sub> 06:07, 29 January 2023 (UTC)
::::::::Many thanks again 😊 I know what you mean; I love coding too. I hoping one day to be good at it 😉 <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 07:48, 29 January 2023 (UTC)
== ID fix for all strip markers ==
@[[User:Pppery|Pppery]] Hello, I noticed you reverted my edit. Could you share an example of a test that should be failing passing. Thanks, <span class="nowrap">– [[User:BrandonXLF|<span style="color:blue;">Brandon</span><span style="color:green;">XLF</span>]] ([[User talk:BrandonXLF|talk]])</span> 16:34, 25 May 2023 (UTC)
: The case that brought this to my attention was [[Module talk:YouTubeSubscribers/testcases]], but AFAIK any test using preprocess_equals to compare unequal strings should trigger the bug. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 16:37, 25 May 2023 (UTC)
::I've reimplemented the stripping for the expected with the bug hopefully fixed (the expected was accidentally replaced with the actual, causing it to just see if equals itself). [[User:Aidan9382|Aidan9382]] <sub>([[User talk:Aidan9382|talk]])</sub> 17:04, 25 May 2023 (UTC)
:::Oh I didn't catch that, thanks! <span class="nowrap">– [[User:BrandonXLF|<span style="color:blue;">Brandon</span><span style="color:green;">XLF</span>]] ([[User talk:BrandonXLF|talk]])</span> 23:17, 25 May 2023 (UTC)
== great and powerful script ==
congratulations ! Thanks. -- [[User:Wladek92|Wladek92]] ([[User talk:Wladek92|talk]]) 08:43, 16 June 2025 (UTC)
| |||