Module talk:UnitTests: Difference between revisions

Revision as of 06:08, 29 January 2023

Latest revision as of 08:43, 16 June 2025

(8 intermediate revisions by 6 users not shown)

Line 81:

== Tests not failing when they should ==

I'm creating testcases for [[Module:GetShortDescription]] and [[Module:AnnotatedLinkAnnotated link]] and due to my own derping, left some copy-pasta typos which should have caused a series of tests to fail, but they did not. I fixed the typos but [[Special:Diff/1135864158/1135864279|purposefully altered one test to fail]] and it sailed through running <code><nowiki>{{#invoke:AnnotatedLink/testcases|run_tests}}</nowiki></code>. Am I doing something wrong, or is there a problem with this module? <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 09:42, 27 January 2023 (UTC)

:"Test methods like test_hello above must begin with 'test'". I knew that. <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 09:45, 27 January 2023 (UTC)

:Might I suggest not outputting "All tests passed." when no tests have been run? <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 11:18, 27 January 2023 (UTC)

Line 108:

::::::Understood. I hope it didn't trouble you too much trying, and again, I really appreciate the effort. I made a little helper script, [[User:Fred Gandt/moveFailedModuleTestsToTop.js|moveFailedModuleTestsToTop.js]], that shifts all the failures to the top on load. It's dirt simple and could do with extra qualification; would you mind if the tables include something like <code>class="wikitable module-unit-tests-result"</code> so the script can be more particular? I nearly went ahead and stuck it in there myself, but considered that might be a bit rude. I should have the script to pick out sets of tables where results of multiple invocations are present... <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 01:51, 29 January 2023 (UTC)

:::::::Don't worry about any trouble I had doing this, coding is a big hobby of mine and I enjoy fixing up stuff like this. I've gone ahead and added the class to the table headers and called it <code>unit-tests-result</code>. I don't think it would've been rude to add the class yourself, it's a simple minor improvement and it doesn't screw with the existing layout, so it's completely fine. [[User:Aidan9382|Aidan9382]] _{([[User talk:Aidan9382|talk]])} 06:07, 29 January 2023 (UTC)

::::::::Many thanks again 😊 I know what you mean; I love coding too. I hoping one day to be good at it 😉 <code style="background:#DFF;white-space:pre">[[User:Fred Gandt|Fred Gandt]] · [[User talk:Fred Gandt|talk]] · [[Special:Contributions/Fred Gandt|contribs]]</code> 07:48, 29 January 2023 (UTC)

== ID fix for all strip markers ==

@[[User:Pppery|Pppery]] Hello, I noticed you reverted my edit. Could you share an example of a test that should be failing passing. Thanks, <span class="nowrap">– [[User:BrandonXLF|<span style="color:blue;">Brandon</span><span style="color:green;">XLF</span>]] ([[User talk:BrandonXLF|talk]])</span> 16:34, 25 May 2023 (UTC)

: The case that brought this to my attention was [[Module talk:YouTubeSubscribers/testcases]], but AFAIK any test using preprocess_equals to compare unequal strings should trigger the bug. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 16:37, 25 May 2023 (UTC)

::I've reimplemented the stripping for the expected with the bug hopefully fixed (the expected was accidentally replaced with the actual, causing it to just see if equals itself). [[User:Aidan9382|Aidan9382]] _{([[User talk:Aidan9382|talk]])} 17:04, 25 May 2023 (UTC)

:::Oh I didn't catch that, thanks! <span class="nowrap">– [[User:BrandonXLF|<span style="color:blue;">Brandon</span><span style="color:green;">XLF</span>]] ([[User talk:BrandonXLF|talk]])</span> 23:17, 25 May 2023 (UTC)

== great and powerful script ==

congratulations ! Thanks. -- [[User:Wladek92|Wladek92]] ([[User talk:Wladek92|talk]]) 08:43, 16 June 2025 (UTC)