Talk:Aho–Corasick algorithm: Difference between revisions

Content deleted Content added
Tags: Mobile edit Mobile web edit Advanced mobile edit
 
(2 intermediate revisions by 2 users not shown)
Line 2:
{{WikiProject Computer science|importance=mid}}
}}
 
== Untitled ==
Something is wrong with the first sentence in the "Informally, the algorithm constructs a trie ..." paragraph -- some kind of copy-paste replacement error; haven't figured out exactly how to fix it yet. Looks like there isn't a clean version to go back to; the mismatched parenthetical expression hasn't changed since it was added (17:36, 27 July 2006). Anyone? [[User:Dvgrn|dvgrn]] 18:46, 19 September 2006 (UTC)
* Got rid of the obvious error, but may have introduced some subtle inaccuracy -- will have to study the algorithm some more to be sure. [[User:Dvgrn|dvgrn]] 20:40, 19 September 2006 (UTC)
Line 75 ⟶ 77:
:::::The output is a set of pairs (i,j) such that string i appears at index j. The number of such pairs may be (much) larger than the length of the input.
:::::Since you were not happy with my phrasing, could you please come up with a better phrasing communicating the same fact? In my opinion, the current state is a downgrade from the incorrect statement that there may be quadratically many matches, but at least that conveyed that the "number of matches" really has to be a part of the complexity. This has now gotten lost. [[User:Al-Quaknaa|Martin Koutecký]] ([[User talk:Al-Quaknaa|talk]]) 13:10, 23 October 2024 (UTC)
::::::I have no read-made language as I in turn do not understand your concern. My points are simple:
::::::# While it is easy for me to understand the meaning of words ''string "aaaaa" requires more space than "a"'', I cannot easily imagine a straightforward comparison of sizes of the same string "aaaaa" and of a [[tuple]] (1,1). Either the assumptions shall be listed or the comparison adjectives skipped.
::::::# Similarly, the generic meaning of ''quadratic'' describes a relationship between x and y of the form y = O(x*x). When declaring something to be quadratic, the text should identify not only y, but x also.
::::::# I am not an expert, but to the best of my knowledge AC algorithm is used primarily to find the threat patters in the network traffic. It does not appear to me that the "a", "aa", "aaa", ... is a typical dictionary for this application. I would like therefore to add something along the lines of "pathological" or "atypical" to the description of this example (this requires a [[WP:RS]], of course).
::::::[[User:Викидим|Викидим]] ([[User talk:Викидим|talk]]) 21:44, 24 October 2024 (UTC)