Module talk:WikiProject banner/Archive 16: Difference between revisions

Content deleted Content added
m Archiving 1 discussion(s) from Module talk:WikiProject banner) (bot
m Archiving 1 discussion(s) from Module talk:WikiProject banner) (bot
 
(6 intermediate revisions by the same user not shown)
Line 284:
:Will investigate &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 15:14, 31 January 2025 (UTC)
:{{fixed}} silly error which did not show itself on my test cases &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 20:50, 31 January 2025 (UTC)
 
== [[:Category:Disambig-Class List articles]] and others ==
 
@[[User:HouseBlaster|HouseBlaster]] and @[[User:R'n'B|R'n'B]] have pointed out a problem with the code for projects that have opted out of PIQA. We are using [[Module:Pagetype]] to detect whether a page is an article or some other type of page (e.g. disambiguation pages and redirects are not classified as articles), and this is used to determine whether to use "pages" or "articles" in the category name.
 
The problem occurs for opt-out projects because they can set their class to be whatever they wish, regardless of the page type. For example [[C2Cl2F4]] is a list article but WikiProject Lists classified it as a disambiguation page. Therefore it is going into [[:Category:Disambig-Class List articles]] rather than [[:Category:Disambig-Class List pages]]. &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 08:38, 15 January 2025 (UTC)
 
:We should distinguish between two things here. What a project classifies a page for their project, and what a page is. WP History can say that in their opinion an article is not the global quality of say "B" and they give it a "C", what they can't do, is say an article is a category. Same thing with disambiguation pages. A page is, or is not, a disambiguation page. That is something that is global. I'm opposed to any and all changes which let projects falsely identify pages. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 10:54, 20 January 2025 (UTC)
::It appears the articles in [[:Category:Disambig-Class List articles]] were just rookie mistakes. They are now in [[:Category:List-Class List articles]] (not [[:Category:Disambig-Class List pages]] since, as correctly stated, they are articles). [[User:Nurg|Nurg]] ([[User talk:Nurg|talk]]) 23:40, 20 January 2025 (UTC)
::There are projects that choose to define certain categories as Project-class because they are internal project categories rather than content categories. I'm not sure we should be enforcing such a strict interpretation, to stop them doing that &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 10:33, 21 January 2025 (UTC)
:::Well then, start an RfC and lets see where the consensus is. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 10:48, 21 January 2025 (UTC)
::::I'm not the one trying to change the status quo &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 21:36, 1 February 2025 (UTC)
See also related discussions at [[Template talk:WikiProject banner shell#Request: Class=Project to override other default allocations]] and [[Template talk:WikiProject Military history#Redlinked class-rating categories, again]]. I am thinking that we should keep a record of which classes are "pages" and which classes are "articles". Then opt-out projects can do whatever they like without messing up the category system &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 21:39, 1 February 2025 (UTC)
 
== DOC=auto Please see ==
 
Small inconsistency: in the [[Template:WikiProject Oceania#Deprecated parameters|#Deprecated parameters]] section, both listas & class bullets' 2nd sentence should start with either "Please see ..." or "See ..." and not both. This is the only instance of "Please see ..." I see, so preference goes to "See ...". &nbsp;&nbsp;<b>~</b>&nbsp;<span style="font-family:Monotype Corsiva; font-size:16px;">[[User:Tom.Reding|Tom.Reding]] ([[User talk:Tom.Reding|talk]] ⋅[[WP:DGAF|dgaf]])</span>&nbsp; 12:00, 8 February 2025 (UTC)
 
== Eliminating the remaining uses of [[Template:WPBannerMeta/hooks]] and its subpages ==
 
===Low hanging fruit===
* {{tfd links|WPBannerMeta/hooks}}
* {{tfd links|WPBannerMeta/hooks/collapsed}}
* {{tfd links|WPBannerMeta/hooks/notecounter}}
* {{tfd links|WPBannerMeta/hooks/notes}}
* {{tfd links|WPBannerMeta/hooks/taskforces}}
* {{tfd links|WPBannerMeta/hooks/taskforces/core}}
* {{tfd links|WPBannerMeta/hooks/tfnested}}
From what I can tell, I think we are all set to delete (under [[WP:T5]]) the templates listed above, but I am asking here before actually pushing the button. <b>[[User:HouseBlaster|House]][[Special:Contributions/HouseBlaster|<span style="color:#7D066B;">Blaster</span>]]</b>&nbsp;([[User talk:HouseBlaster|talk]]&nbsp;•&nbsp;he/they) 02:48, 11 February 2025 (UTC)
 
:[[Template:WPBannerMeta/hooks/notecounter]] is mentioned at [[Module:WikiProject banner/templatepage#L-24]]. Other than that, the few transclusions left for the others can be deleted. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 09:39, 11 February 2025 (UTC)
::<s>I don't want to break that module; can that line just be deleted per [[WP:BEANS]]? [[User:HouseBlaster|House]][[Special:Contributions/HouseBlaster|'''Blaster''']]&nbsp;([[User talk:HouseBlaster|talk]]&nbsp;•&nbsp;he/they) 23:46, 26 February 2025 (UTC)</s>
:::Figured out [[Special:Diff/1278003814|how to remove it]]. [[User:HouseBlaster|House]][[Special:Contributions/HouseBlaster|'''Blaster''']]&nbsp;([[User talk:HouseBlaster|talk]]&nbsp;•&nbsp;he/they) 23:31, 27 February 2025 (UTC)
 
===[[Template:WPBannerMeta/hooks/cats]]===
The other remaining subtemplate – {{tfd links|WPBannerMeta/hooks/cats}} – is [https://en.wikipedia.org/wiki/Special:WhatLinksHere?target=Template%3AWPBannerMeta%2Fhooks%2Fcats&namespace=10&hidelinks=1&limit=50 still in use] at [[Template:WikiProject U.S. Roads/cats]]. I can see of several possible solutions, in order of increasing complexity:
#Leave it be.
#*Pros: Very easy
#*Cons: Feels like we are inviting further use of a deprecated template
#Move it to [[Template:WikiProject U.S. Roads/cats/core]] (or some other subpage)
#*Pros: Easy, prevents use of the template in other locations
#*Cons: Still leaves around some technical debt
#Merge its functionality with [[Template:WikiProject U.S. Roads/cats]]
#*Pros: Marginally decreases technical debt; impossible to continue to use any of the hooks
#*Cons: More challenging; [[Template:WikiProject U.S. Roads/cats]] still exists
I lean towards option 2. Best, <b>[[User:HouseBlaster|House]][[Special:Contributions/HouseBlaster|<span style="color:#7D066B;">Blaster</span>]]</b>&nbsp;([[User talk:HouseBlaster|talk]]&nbsp;•&nbsp;he/they) 02:48, 11 February 2025 (UTC)
 
:2 will be the easiest for now and will allow to decouple it from the parent template. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 10:01, 11 February 2025 (UTC)
::I have actioned option 2. [[User:HouseBlaster|House]][[Special:Contributions/HouseBlaster|'''Blaster''']]&nbsp;([[User talk:HouseBlaster|talk]]&nbsp;•&nbsp;he/they) 23:32, 27 February 2025 (UTC)
 
== NA class category warnings ==
 
While processing a move request for [[Template:WikiProject Song Contests]], and then updating the categories (for the first time), I was caught unaware of the changes to the NA-related categories, [[Wikipedia:Categories_for_discussion/Log/2024_December_7#Category:Category-Class_articles]]. This led to an eventual deletion of [[:Category:NA-importance Song Contests articles]] and [[:Category:NA-Class Song Contests articles]] as these became redirects to the now non-existent Eurovision categories.
 
Then in the [[Template:WikiProject Song Contests]] page, warnings came up, requesting to create the 'articles' categories, leading to me recreating the redirects to suppress the warnings (cc: @[[User:Liz|Liz]]). Can these warnings be suppressed outright in the module codes since the articles are being automatically set to the 'pages' categories already? [[User:Robertsky|– robertsky]] ([[User talk:Robertsky|talk]]) 23:09, 13 February 2025 (UTC)
 
:Yes I will update those, thanks for the reminder &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 10:41, 14 February 2025 (UTC)
:{{done}}, finally got round to this &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 16:09, 22 March 2025 (UTC)
 
== Pre-load templates ==
 
We are still using the following templates:
* [[Template:WPBannerMeta/templatepage/preloadqual]]
* [[Template:WPBannerMeta/templatepage/preloadimp]]
* [[Template:WPBannerMeta/templatepage/preloadmeta]]
* [[Template:WPBannerMeta/templatepage/editintro]]
and these are also using:
* [[Template:WPBannerMeta/templatepage/deduceclass]]
* [[Template:WPBannerMeta/templatepage/deduceimportance]]
* [[Template:WPBannerMeta/templatepage/impheader]]
* [[Template:WPBannerMeta/templatepage/qualheader]]
I would firstly like to move these to a more suitable ___location (as [[Template:WPBannerMeta]] is no longer in use) and also to update and simplify this whole family of templates, because things can be done a lot more easily these days &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 16:16, 22 March 2025 (UTC)
 
:{{done}}. I have moved the three preload templates to [[Template:WikiProject banner preload template]] and deleted all the rest which are no longer needed &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 18:14, 26 March 2025 (UTC)
 
== To do adjustments ==
 
I have [https://en.wikipedia.org/w/index.php?title=Module%3AWikiProject_banner%2Fauxiliary%2Fsandbox&diff=1274014600&oldid=1268570995 made a few adjustments] to the to do related code in /auxiliary/sandbox.
# Converted the presentational table to a more appropriate div.
# Use a dark mode token for the background.
# Removed support for setting custom styles. [[Template:WikiProject Freemasonry]] is the only project which uses them ([https://en.wikipedia.org/w/index.php?search=insource:/TODO_STYLE/%20-intitle:/(\/sandbox|\/doc)/&title=Special:Search&profile=advanced&fulltext=1&ns10=1&ns828=1 TODO_STYLE] [https://en.wikipedia.org/w/index.php?search=insource:/TODO_TITLE_STYLE/%20-intitle:/(\/sandbox|\/doc)/&title=Special:Search&profile=advanced&fulltext=1&ns10=1&ns828=1 TODO_TITLE_STYLE]), and the way in which they are used is not friendly for dark mode, though the particular color flavor happens to be readable. [https://en.wikipedia.org/w/index.php?title=Template%3AWikiProject_NASCAR&diff=1274014111&oldid=1175978317 I removed another] which was using the default in light mode.
 
It looks like [[Module:WikiProject banner/templatepage]] needs removal of the parameters of interest. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 02:10, 5 February 2025 (UTC)
 
:Great, thanks for the info. I can deal with /templatepage &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 18:15, 5 February 2025 (UTC)
:@[[User:Izno|Izno]] there is a slight spacing inconsistency with the new divs, which you can observe on [[Template:WikiProject Japan/sandbox]]. Are you able to line up the text on the left and the [show] links on the right? &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 16:43, 22 March 2025 (UTC)
::Playing around with the left/right padding on the container seems to do it. Adding 2px on the left and another 2px on the right I think got it. Basically what's happening is that tables have a natural border-spacing (not coincidentally it's 2px) which is padding like but applied slightly differently. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 16:53, 22 March 2025 (UTC)
:::Padding is always inside the border. The spacing outside the border is the margin. See [https://www.w3.org/TR/css-box-3/#box-model The CSS Box Model]. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] &#x1f339; ([[User talk:Redrose64|talk]]) 23:27, 22 March 2025 (UTC)
::::Tables are special in that they have the border-spacing property. The point I was making is that in fact there is more to the box model than just padding and margin. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 00:58, 23 March 2025 (UTC)
:::::I don't see any changes to the sandbox and the example is still looking the same? If you can fix the spacing in the sandbox, I suggest we change all of the collapsible boxes in the module to use div boxes, to keep things consistent &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 08:46, 24 March 2025 (UTC)
:::::@[[User:Izno|Izno]] are you still interested in this? &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 20:48, 28 March 2025 (UTC)
::::::I didn't make any adjustments, which is why you do not see any changes.
::::::I didn't change the other collapsible boxes because they're more or less fairly marked up as tables, from memory (and memory may be wrong of course). [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 21:30, 28 March 2025 (UTC)
:::::::In that case I can't really see a benefit to converting the table to a div, as it will introduce an inconsistency. I have removed the style parameters from /templatepage, so these will now be treated as unknown parameters &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 18:53, 30 March 2025 (UTC)
 
== Tidy up intersecting categories ==
 
I am looking at tidying up the intersecting quality/importance categories and there seem to be 3 types:
* [[:Category:Draft-Class Ireland articles of Low-importance]] - this is a valid category but should be renamed to [[:Category:Draft-Class Ireland pages of Low-importance]] in line with the move of [[:Category:Draft-Class pages]]. This is under discussion [[Wikipedia:Categories for discussion/Log/2025 March 28#Category:Redirect-Class 20th Century Studios articles of Low-importance|here]] - please comment if you can.
* [[:Category:FM-Class Palaeontology articles of NA-importance]] seems entirely redundant because all FM-class pages are rated as NA-class, so it will be an exact copy of [[:Category:FM-Class Palaeontology pages]]. I have nominated for deletion [[Wikipedia:Categories for discussion/Log/2025 March 28#Category:Category-Class 20th Century Studios articles of NA-importance|here]] - please comment if you can.
* [[:Category:NA-Class glass articles of Unknown-importance]] is invalid because it will never be used (NA-class will always default to NA-importance not Unknown-importance), so I will tag it for speedy deletion under {{tl|db-c1}}.
&mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 07:52, 2 April 2025 (UTC)