Module talk:Disambiguation: Difference between revisions

Browse history interactively

← Previous edit

Content deleted Content added

VisualWikitext

Add topic

Revision as of 06:45, 16 August 2024 edit StradBot (talk \| contribs) Bots 166 edits m Bot: create edit request to update disambiguation template list ← Previous edit		Latest revision as of 14:49, 28 July 2025 edit undo Pppery (talk \| contribs) Interface administrators, Administrators 117,347 edits →Request update of Module:Disambiguation/templates (28 July 2025): Done
(18 intermediate revisions by 6 users not shown)
Line 434: == Request update of Module:Disambiguation/templates (16 August 2024) == {{edit fully-protected\|Module:Disambiguation/templates\|answered=noyes}} Bot comment: StradBot has detected that [[Module:Disambiguation/templates]] needs to be updated. This is due to a template being added or removed from [[:Category:Disambiguation message boxes]], or to a redirect to one of those templates being added or removed. The bot has saved the new page content in [[Module:Disambiguation/templates/sandbox]] ([https://en.wikipedia.org/w/index.php?title=Special:ComparePages&page1=Module%3ADisambiguation%2Ftemplates&page2=Module%3ADisambiguation%2Ftemplates%2Fsandbox diff]). Please review this and update the module if necessary. [[User:StradBot\|StradBot]] ([[User talk:StradBot\|talk]]) 06:45, 16 August 2024 (UTC) :{{done}}<!-- Template:EP --> — Martin <small>([[User:MSGJ\|MSGJ]] · [[User talk:MSGJ\|talk]])</small> 19:18, 18 August 2024 (UTC) == Request update of Module:Disambiguation/templates (19 August 2024) == {{edit fully-protected\|Module:Disambiguation/templates\|answered=yes}} Bot comment: StradBot has detected that [[Module:Disambiguation/templates]] needs to be updated. This is due to a template being added or removed from [[:Category:Disambiguation message boxes]], or to a redirect to one of those templates being added or removed. The bot has saved the new page content in [[Module:Disambiguation/templates/sandbox]] ([https://en.wikipedia.org/w/index.php?title=Special:ComparePages&page1=Module%3ADisambiguation%2Ftemplates&page2=Module%3ADisambiguation%2Ftemplates%2Fsandbox diff]). Please review this and update the module if necessary. [[User:StradBot\|StradBot]] ([[User talk:StradBot\|talk]]) 06:45, 19 August 2024 (UTC) :{{done}}<!-- Template:EP --> — Martin <small>([[User:MSGJ\|MSGJ]] · [[User talk:MSGJ\|talk]])</small> 07:15, 19 August 2024 (UTC) == Request update of Module:Disambiguation/templates (16 September 2024) == {{edit fully-protected\|Module:Disambiguation/templates\|answered=yes}} Bot comment: StradBot has detected that [[Module:Disambiguation/templates]] needs to be updated. This is due to a template being added or removed from [[:Category:Disambiguation message boxes]], or to a redirect to one of those templates being added or removed. The bot has saved the new page content in [[Module:Disambiguation/templates/sandbox]] ([https://en.wikipedia.org/w/index.php?title=Special:ComparePages&page1=Module%3ADisambiguation%2Ftemplates&page2=Module%3ADisambiguation%2Ftemplates%2Fsandbox diff]). Please review this and update the module if necessary. [[User:StradBot\|StradBot]] ([[User talk:StradBot\|talk]]) 06:45, 16 September 2024 (UTC) :{{done}}<!-- Template:EP --> [[User:Elli\|Elli]] ([[User_talk:Elli\|talk]] \| [[Special:Contributions/Elli\|contribs]]) 23:20, 26 September 2024 (UTC) == Edit request 18 January 2025 - Speed improvements == {{edit fully-protected\|answered=yes}} Replaces the recently added nowiki/comment removal code with a module that does the same thing but a bit faster (~30% faster overall, though the general performance hit isn't much anyways). Normally wouldn't worry about it too much, but this module is decently used and might have good reason to be invoked more than one time on a page. [[User:Aidan9382\|Aidan9382]] <sub>([[User talk:Aidan9382\|talk]])</sub> 20:46, 18 January 2025 (UTC) :@[[User:Aidan9382\|Aidan9382]]It feels counter-intuitive to import over a whole module to see a slight performance gain, maybe you could copy over only the relevant parts ? and replace the gsub code ? [[User:Sohom Datta\|<b class="skin-invert" style="color:#795cb2; display: inline-block; transform: rotate(1deg)">Sohom</b>]] ([[User talk:Sohom Datta\|<span class="skin-invert" style="color: #36c;">talk</span>]]) 14:56, 22 January 2025 (UTC) ::{{ping\|Sohom Datta}} The entire point of the module used is that "doing it fast" is an involved process, since there's no gsub that can reasonably capture both nowiki and html comments at the same time, so you instead have to do some rather involved matching to do it in just one scan of the content. Copying over the relevant parts is something I want to directly avoid because it's a decent chunk of code and duplicating it everywhere would get incredibly messy fast, and that's why I made that module in the first place. And I don't get what you mean by "replacing the gsub code", since that's what the module is doing here, so I've already done that(?). Not quite sure what you mean there. [[User:Aidan9382\|Aidan9382]] <sub>([[User talk:Aidan9382\|talk]])</sub> 15:23, 22 January 2025 (UTC) :::Fair enough, but my primary concern is that we are transforming a slightly slow but maintainable and readable module into one that requires specialized Lua knowledge to debug. By introducing a dependency on a highly complex and intricate module, we risk increasing the likelihood that errors related to <code>PrepareText</code> will be hard to debug for passing administrators and instead demand the expertise of someone really familiar with the inner working of the Wikitext parsing module. [[User:Sohom Datta\|<b class="skin-invert" style="color:#795cb2; display: inline-block; transform: rotate(1deg)">Sohom</b>]] ([[User talk:Sohom Datta\|<span class="skin-invert" style="color: #36c;">talk</span>]]) 16:58, 22 January 2025 (UTC) ::::That's fair. I've annotated it with a comment to at least explain what it does functionally so that any person reading it should be able to figure out why something might be (intentionally) not getting picked up. If you're worried about the parsing module itself bugging, it's already used in a couple commonly used modules with no bugs reported yet, so it shouldn't be the direct cause of any bugs itself, though I understand the concern. I'm fine with this being rejected if you think the simplicity is worth, since the performance hit isn't incredibly significant. [[User:Aidan9382\|Aidan9382]] <sub>([[User talk:Aidan9382\|talk]])</sub> 17:31, 22 January 2025 (UTC) :::::I am intending to deploy the code, unless anyone objects. The current code is doing something which can be done better by an existing module. I'm not seeing a huge benefit in trying to keep this module simple — Martin <small>([[User:MSGJ\|MSGJ]] · [[User talk:MSGJ\|talk]])</small> 20:52, 28 January 2025 (UTC) :{{done}}<!-- Template:EP --> — Martin <small>([[User:MSGJ\|MSGJ]] · [[User talk:MSGJ\|talk]])</small> 08:22, 4 February 2025 (UTC) == Request update of Module:Disambiguation/templates (4 February 2025) == {{edit fully-protected\|Module:Disambiguation/templates\|answered=yes}} Bot comment: StradBot has detected that [[Module:Disambiguation/templates]] needs to be updated. This is due to a template being added or removed from [[:Category:Disambiguation message boxes]], or to a redirect to one of those templates being added or removed. The bot has saved the new page content in [[Module:Disambiguation/templates/sandbox]] ([https://en.wikipedia.org/w/index.php?title=Special:ComparePages&page1=Module%3ADisambiguation%2Ftemplates&page2=Module%3ADisambiguation%2Ftemplates%2Fsandbox diff]). Please review this and update the module if necessary. [[User:StradBot\|StradBot]] ([[User talk:StradBot\|talk]]) 06:45, 4 February 2025 (UTC) :{{done}}<!-- Template:EP --> this is just a reordering of the same list, but I have done it to keep the bot happy — Martin <small>([[User:MSGJ\|MSGJ]] · [[User talk:MSGJ\|talk]])</small> 08:21, 4 February 2025 (UTC) == Request update of Module:Disambiguation/templates (1 March 2025) == {{edit fully-protected\|Module:Disambiguation/templates\|answered=yes}} Bot comment: StradBot has detected that [[Module:Disambiguation/templates]] needs to be updated. This is due to a template being added or removed from [[:Category:Disambiguation message boxes]], or to a redirect to one of those templates being added or removed. The bot has saved the new page content in [[Module:Disambiguation/templates/sandbox]] ([https://en.wikipedia.org/w/index.php?title=Special:ComparePages&page1=Module%3ADisambiguation%2Ftemplates&page2=Module%3ADisambiguation%2Ftemplates%2Fsandbox diff]). Please review this and update the module if necessary. [[User:StradBot\|StradBot]] ([[User talk:StradBot\|talk]]) 06:45, 1 March 2025 (UTC) : {{done}} [[User:Pppery\|* Pppery ]] [[User talk:Pppery\|<sub style="color:#800000">it has begun...</sub>]] 21:17, 5 March 2025 (UTC) == Request update of Module:Disambiguation/templates (28 July 2025) == {{edit fully-protected\|Module:Disambiguation/templates\|answered=yes}} Bot comment: StradBot has detected that [[Module:Disambiguation/templates]] needs to be updated. This is due to a template being added or removed from [[:Category:Disambiguation message boxes]], or to a redirect to one of those templates being added or removed. The bot has saved the new page content in [[Module:Disambiguation/templates/sandbox]] ([https://en.wikipedia.org/w/index.php?title=Special:ComparePages&page1=Module%3ADisambiguation%2Ftemplates&page2=Module%3ADisambiguation%2Ftemplates%2Fsandbox diff]). Please review this and update the module if necessary. [[User:StradBot\|StradBot]] ([[User talk:StradBot\|talk]]) 06:48, 28 July 2025 (UTC) : {{done}} [[User:Pppery\| Pppery *]] [[User talk:Pppery\|<sub style="color:#800000">it has begun...</sub>]] 14:49, 28 July 2025 (UTC)