Module talk:Location map/Archive 11: Difference between revisions

Revision as of 16:28, 30 April 2025

Latest revision as of 16:23, 16 August 2025

(2 intermediate revisions by the same user not shown)

Line 709:

::{{ping|Pppery}} The change you made [https://en.wikipedia.org/w/index.php?title=Module:Location_map/multi&diff=prev&oldid=1221445143] includes the base Location map sandbox suffix require 😅. [[User:Alexiscoutinho|Alexis Coutinho]] ([[User talk:Alexiscoutinho|talk]]) ^{[''[[WP:PING|ping me]]'']} 01:21, 30 April 2024 (UTC)

::: Fixed. Sorry, I really should know better given I'm the guy systematically removing inappropriate sandbox uses. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 01:23, 30 April 2024 (UTC)

== Linter errors with <code>span</code> ==

{{ping|Jonesey95}} In your recent revert in the sandbox, do you mean if a user passes a label like this: <code><nowiki>label=<div style="color:green">New York</div></nowiki></code> (when using module syntax)? [[User:Alexiscoutinho|Alexis Coutinho]] ([[User talk:Alexiscoutinho|talk]]) 16:23, 20 May 2024 (UTC)

:Yes. A span tag cannot wrap a div tag. Many real-world examples appear in [https://en.wikipedia.org/w/index.php?search=hastemplate%3A%22Location+map%22+insource%3A%2Flabel%5C%3D%5C%3Cdiv%2F&title=Special:Search&profile=advanced&fulltext=1&ns0=1&ns4=1&ns10=1&ns12=1 these search results]. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 20:23, 20 May 2024 (UTC)

::👍 [[User:Alexiscoutinho|Alexis Coutinho]] ([[User talk:Alexiscoutinho|talk]]) 20:44, 20 May 2024 (UTC)

== Map label background bug in dark mode ==

The map labels in dark mode have a black background and black text. The background should either be transparent on maps where the label text colour has sufficient contrast with the background or white so the black text has sufficient contrast. Here are three examples from [[Moulins, Allier]], and [[Con Mine]].

[[File:Con Min map label bug.png|thumb]]

[[File:Con mine screenshot.png|thumb]]

[[File:Screen_shot_of_moulins,_allier_wiki_page_in_dark_mode.png|thumb]] [[User:JScherer-WMF|JScherer-WMF]] ([[User talk:JScherer-WMF|talk]]) 21:18, 29 May 2024 (UTC)

:In case this helps debugging: I noticed that the maps in [[Grand Canyon]] use the same template but do not have the bug. [[User:JScherer-WMF|JScherer-WMF]] ([[User talk:JScherer-WMF|talk]]) 16:55, 30 May 2024 (UTC)

::Hey @[[User:JScherer-WMF|JScherer-WMF]] this should be fixed now with the recent additions to [[Module:Location_map/styles.css]]. <span style="background:white; color: black;">🐸</span>&nbsp;[[User:Jdlrobson|Jdlrobson]] ([[User talk:Jdlrobson|talk]]) 04:35, 31 May 2024 (UTC)

:::I think these changes got broken again. See [[Caen]] [[User:Kabelsalat22|Kabelsalat22]] ([[User talk:Kabelsalat22|talk]]) 19:23, 13 June 2024 (UTC)

== Still not showing up ==

Hi! I tried using a map with like 27 locations on it, I followed it and it's still not showing up! help me! [[User:45BearsFan|45BearsFan]] ([[User talk:45BearsFan|talk]]) 03:43, 28 June 2024 (UTC)

:@[[User:45BearsFan|45BearsFan]] there was a <code>}}</code> missing at the end of your call to {{tl|Location map+}}. [[User:Ponor|Ponor]] ([[User talk:Ponor|talk]]) 13:00, 28 June 2024 (UTC)

::Now that I got the easy part out of the way. The dots aren't showing up in their places. [[User:45BearsFan|45BearsFan]] ([[User talk:45BearsFan|talk]]) 14:13, 28 June 2024 (UTC)

:::[[Special:Permalink/1231480913]] [[User:Ponor|Ponor]] ([[User talk:Ponor|talk]]) 14:31, 28 June 2024 (UTC)

::::Thank you so much!! [[User:45BearsFan|45BearsFan]] ([[User talk:45BearsFan|talk]]) 14:36, 28 June 2024 (UTC)

== {{tl|Location map~}} {{para|background}} is sometimes ignored when {{para|position|bottom}} or {{para|position|top}} ==

[[Special:Permalink/1237233339#Venues|Example here]] in which the label background color is ignored for one element:

:<code><nowiki>{{Location map~|France Paris and inner ring|lat=48.8737|long=2.2950|background = #ffcc7777|label=<div style="font-size:70%;">'''[[Arc de Triomphe]]'''<br />'''[[Place Charles de Gaulle]]'''</div>|position=top}}</nowiki></code>

In the above example, the color has partial alpha but that's irrelevant to the issue: I previewed {{para|background|#ffcc77}} and/or {{para|position|bottom}} with same problem; changing {{para|position|left}} or {{para|position|right}} work OK. likewise changing other elements' {{para|position}} broke them.

[[User:Jnestorius|jnestorius]]^{([[User talk:Jnestorius|talk]])} 20:26, 28 July 2024 (UTC)

* It's the <code><nowiki><div style="font-size:70%;"></nowiki></code>. [[Special:Diff/1237243334|My workaround]] was to use {{tl|resize}} instead, which is better practice anyway. The underlying issue may still be worth fixing, whenever. [[User:Jnestorius|jnestorius]]^{([[User talk:Jnestorius|talk]])} 21:00, 28 July 2024 (UTC)

== Buggy and unnecessary float ==

The {{para|float}} is causing infobox problems at [[2024_Wayanad_landslides]], see [[MediaWiki_talk:Gadget-switcher.js#Interface-protected_edit_request_on_1_August_2024_fix_floating_radio_buttons]].

According to the monthly parameter usage report, the {{para|float}} had only 1 use, which I removed. Furthermore, do we even need the CSS <code>float:right</code> when it's mostly in infoboxes, which are narrow? [[Special:Contributions/142.113.140.146|142.113.140.146]] ([[User talk:142.113.140.146|talk]]) 08:04, 1 August 2024 (UTC)

:So I tested on mobile and saw the display. It is unclear why the controls are to the left of the image. I haven't heard of any UI pattern like this layout. On mobile, we should be spacing things out on the page with plenty of padding, not trying to cram everything on one row. [[Special:Contributions/142.113.140.146|142.113.140.146]] ([[User talk:142.113.140.146|talk]]) 19:56, 1 August 2024 (UTC)

== Urgent: Please fix this template for printed content [[Module:Location map/sandbox/styles.css]]. ==

<div lang="en" dir="ltr">

Firstly, apologies for writing in English if this is not your first language (this is an automated message).

This template has been detected as one of 436 pages using styles that break the page when printed when the user is using dark mode. The fix is very straightforward - all your styles relating to dark mode must be scoped to. Since there is a high risk of this templates being copied to other wikis it is important this notice is acted on ASAP.

To fix this:

# Update `@media (prefers-color-scheme: dark` to `@media screen and (prefers-color-scheme: dark`

# Wrap any styles relating to `html.skin-theme-clientpref-night` in `@media screen`

If this message has not been acted on in 7 days, this will be fixed by an automated script. Thank you for your help fixing this important issue.

For any questions feel free to ask them at [[phab:T369874]].

[[User:Jon (WMF)|Jon (WMF)]] ([[User talk:Jon (WMF)|talk]]) 18:22, 2 August 2024 (UTC) on behalf of the web team.

</div>