Content deleted Content added
BrandonXLF (talk | contribs) |
→Unexpected error in infobox: new section |
||
| (45 intermediate revisions by 14 users not shown) | |||
Line 1:
{{Permanently protected}}
== Template-protected edit request on 20 September 2018 ==
{{edit template-protected|Module:ISO 3166|answered=
Replace the liver version with the sandbox version [[Module:ISO 3166/sandbox]]. The sandbox allows for more inputs to be converted to usable inputs as seen at the test cases [[Module_talk:ISO_3166/testcases]] and I indented all the code so it's more organized and easier to read, as well as fixing a few comments. – [[User:BrandonXLF|<span style="color:#0011ff;font-family:Georgia;text-shadow: 0.15em 0.15em 0.15em #db3a00;'>'''BrandonXLF'''</span>]] [[User talk:BrandonXLF|<span style="color:blue;"><sup>'''(t@lk)'''</sup></span>]] 03:12, 20 September 2018 (UTC)
: done, will revert if I see any script errors popping up. [[User:Frietjes|Frietjes]] ([[User talk:Frietjes|talk]]) 13:44, 20 September 2018 (UTC)
== Deleted codes ==
Does the module currently handle codes that were deleted? [[User:Jc86035|Jc86035]] ([[User talk:Jc86035|talk]]) 11:26, 4 December 2018 (UTC)
== Some testcases didn't work ==
See [[Module talk:ISO 3166/testcases]](PRC and USA). --[[User:Vozhuo|Vozhuo]] ([[User talk:Vozhuo|talk]]) 08:53, 8 December 2018 (UTC)
== Flag template appears to cause "obscure country" category to be applied ==
The use of a flag template, as allowed in the documentation for {{Tl|Infobox settlement}}, appears to cause this template to apply {{cl|Wikipedia page with obscure country}}. See [[Belmont Village, Philadelphia]] for an example. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 06:13, 13 March 2019 (UTC)
== Please limit error checking to main (article) space ==
{{cl|Wikipedia page with obscure country}} is not limited to main (article) space, but it should be. Can someone who knows about Lua programming please place this limit on this and other tracking categories used by this module? Thanks. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 16:41, 28 April 2019 (UTC)
: [[User:Jonesey95|Jonesey95]], seems reasonable. I did the same for [[:Category:Wikipedia page with obscure subdivision]]. note that since namespace checking could add overhead, I put the checks inside the various if blocks so the check happens only if the category is to be added. if there were no overhead from checking the namespace, we could reduce the number of checks by a factor of 2. [[User:Frietjes|Frietjes]] ([[User talk:Frietjes|talk]]) 16:56, 28 April 2019 (UTC)
::Thanks. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 19:58, 28 April 2019 (UTC)
==Updates needed==
I see that [[:Module:ISO 3166/data]] still uses Swaziland rather than [[Eswatini]], that needs changing.[[User:Le Deluge|Le Deluge]] ([[User talk:Le Deluge|talk]]) 13:15, 8 March 2020 (UTC)
:Having compared the data page for the template with [https://www.iso.org/obp/ui/#search the official list] there's quite a few discrepancies. I'm well aware some of these are old favourites for discussion on Wikipedia, such as [[Macau]] versus Macao, Czechia and Viet Nam, but if the template is billing itself as ISO 3166 then surely it should give the official ISO 3166 names, or does that break too many things down the line? (pinging {{ping|SiBr4|Frietjes|BrandonXLF}} as main editors here)
{| class="wikitable"
|-
!Template
!ISO3166
!Template ({{para|isoname|yes}})
|-
|French Southern and Antarctic Lands
|French Southern Territories (the)
|French Southern Territories
|-
|Laos
|Lao People's Democratic Republic (the)
|Lao People's Democratic Republic
|-
|Republic of Congo
|Congo (the)
|Congo
|-
|Russia
|Russian Federation (the)
|Russian Federation
|-
|Syria
|Syrian Arab Republic (the)
|Syrian Arab Republic
|-
|United Kingdom
|United Kingdom of Great Britain and Northern Ireland (the)
|United Kingdom of Great Britain and Northern Ireland
|-
|United States
|United States of America (the)
|United States of America
|-
|Vatican City
|Holy See (the)
|Holy See
|-
|Bolivia
|Bolivia (Plurinational State of)
|Bolivia (Plurinational State of)
|-
|Caribbean Netherlands
|Bonaire, Sint Eustatius and Saba
|Bonaire, Sint Eustatius and Saba
|-
|Brunei
|Brunei Darussalam
|Brunei Darussalam
|-
|Democratic Republic of the Congo
|Congo (the Democratic Republic of the)
|Congo, Democratic Republic of the
|-
|Czech Republic
|Czechia
|Czechia
|-
|Swaziland
|Eswatini
|Eswatini
|-
|Iran
|Iran (Islamic Republic of)
|Iran (Islamic Republic of)
|-
|North Korea
|Korea (the Democratic People's Republic of)
|Korea (Democratic People's Republic of)
|-
|South Korea
|Korea (the Republic of)
|Korea, Republic of
|-
|Macau
|Macao
|Macao
|-
|Federated States of Micronesia
|Micronesia (Federated States of)
|Micronesia (Federated States of)
|-
|Moldova
|Moldova (the Republic of)
|Moldova, Republic of
|-
|Palestine
|Palestine, State of
|Palestine, State of
|-
|Saint-Martin
|Saint Martin (French part)
|Saint Martin (French part)
|-
|São Tomé and Príncipe
|Sao Tome and Principe
|Sao Tome and Principe
|-
|Sint Maarten
|Sint Maarten (Dutch part)
|Sint Maarten (Dutch part)
|-
|Taiwan
|Taiwan (Province of China)
|Taiwan, Province of China
|-
|Tanzania
|Tanzania, the United Republic of
|Tanzania, United Republic of
|-
|Venezuela
|Venezuela (Bolivarian Republic of)
|Venezuela (Bolivarian Republic of)
|-
|Vietnam
|Viet Nam
|Viet Nam
|-
|British Virgin Islands
|Virgin Islands (British)
|Virgin Islands (British)
|-
|United States Virgin Islands
|Virgin Islands (U.S.)
|Virgin Islands (U.S.)
|-
|
|Bahamas (the)
|-
|
|British Indian Ocean Territory (the)
|-
|
|Cayman Islands (the)
|-
|
|Central African Republic (the)
|-
|
|Cocos (Keeling) Islands (the)
|-
|
|Comoros (the)
|-
|
|Cook Islands (the)
|-
|
|Dominican Republic (the)
|-
|
|Falkland Islands (the) [Malvinas]
|-
|
|Faroe Islands (the)
|-
|
|Gambia (the)
|-
|
|Marshall Islands (the)
|-
|
|Netherlands (the)
|-
|
|Niger (the)
|-
|
|Northern Mariana Islands (the)
|-
|
|Philippines (the)
|-
|
|Sudan (the)
|-
|
|Turks and Caicos Islands (the)
|-
|
|United Arab Emirates (the)
|-
|
|United States Minor Outlying Islands (the)
|}[[User:Le Deluge|Le Deluge]] ([[User talk:Le Deluge|talk]]) 14:58, 8 March 2020 (UTC)
:Eswatini is updated. As for the discrepancies, the module has a parameter {{para|isoname}} to toggle between common names and ISO names. The ISO names in the module (which I added to your table for comparison) don't include the article "(the)", though I note the [https://www.iso.org/obp/ui/#iso:code:3166:BS ISO site itself] doesn't consistently include it (or rather, it seems to consistently include it only in the "Short name lower case" field and not in the all-caps "Short name"). Similarly, the standard's two short names of the [https://www.iso.org/obp/ui/#iso:code:3166:CD DRC], [https://www.iso.org/obp/ui/#iso:code:3166:KR South Korea] and [https://www.iso.org/obp/ui/#iso:code:3166:TW Taiwan] differ in the use of commas vs. parentheses, with the module being consistent with the uppercase names. [[User:SiBr4|<span title="User:SiBr₄">SiBr<sub>4</sub></span>]] ([[User talk:SiBr4|<span title="User talk:SiBr₄">talk</span>]]) 19:42, 8 March 2020 (UTC)
== Kosovo? ==
Looks like Kosovo (XK) is missing? [[User:Le Deluge|Le Deluge]] ([[User talk:Le Deluge|talk]]) 23:40, 24 August 2020 (UTC)
:Still missing — [[User:GhostInTheMachine|GhostInTheMachine]] <sup>[[User talk:GhostInTheMachine|talk to me]]</sup> 11:06, 5 February 2025 (UTC)
::@[[User:GhostInTheMachine|GhostInTheMachine]], [[User:Le Deluge|Le Deluge]]: XK is not actually in ISO 3166. There would need to be some consensus here before adding it (although it has been mentioned a few times over the years). <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 18:02, 5 February 2025 (UTC)
:::I know, but this module is used in a number of contexts where the absence of XK does cause problems — [[User:GhostInTheMachine|GhostInTheMachine]] <sup>[[User talk:GhostInTheMachine|talk to me]]</sup> 18:07, 5 February 2025 (UTC)
::::@[[User:GhostInTheMachine|GhostInTheMachine]] I went ahead and added it, we'll see if anyone complains. <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 18:48, 5 February 2025 (UTC)
:::::{{kitty}} Did they also define any subdivision codes? — [[User:GhostInTheMachine|GhostInTheMachine]] <sup>[[User talk:GhostInTheMachine|talk to me]]</sup> 18:53, 5 February 2025 (UTC)
::::::@[[User:GhostInTheMachine|GhostInTheMachine]] I'm not aware of any standardized ones. <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 19:38, 5 February 2025 (UTC)
:::::::Thanks. I could not find any either. At least the error messages have changed — [[User:GhostInTheMachine|GhostInTheMachine]] <sup>[[User talk:GhostInTheMachine|talk to me]]</sup> 20:26, 5 February 2025 (UTC)
== substitutable? ==
I tried to subst {{tlx|Country name}} and I got a bare invoke instead of the output. Is there a way to subst these templates? –[[User:Fredddie|Fredddie]][[User talk:Fredddie|™]] 06:03, 2 January 2022 (UTC)
:@[[User:Fredddie|Fredddie]], you could just subst the underlying module instead of using the template, and that should (?) work. If it's tested enough, we could change the code from <code><nowiki>{{#invoke:ISO 3166|name}}</nowiki></code> to <code><nowiki>{{safesubst:<noinclude/>#invoke:ISO 3166|name}}</nowiki></code>, which would allow substitution via the template. <span style="color:#AAA"><small>{{u|</small><span style="border-radius:9em;padding:0 5px;background:#088">[[User:Sdkb|<span style="color:#FFF">'''Sdkb'''</span>]]</span><small>}}</small></span> <sup>[[User talk:Sdkb|'''talk''']]</sup> 20:53, 17 March 2022 (UTC)
== Guinea-Bissau error ==
Currently, <code><nowiki>{{ISO 3166 code-3|Guinea-Bissau}}</nowiki></code> does not return anything, despite seemingly being listed [[Module:ISO 3166/data/National|in the module]]. Could anyone figure out the error and resolve it? <span style="color:#AAA"><small>{{u|</small><span style="border-radius:9em;padding:0 5px;background:#088">[[User:Sdkb|<span style="color:#FFF">'''Sdkb'''</span>]]</span><small>}}</small></span> <sup>[[User talk:Sdkb|'''talk''']]</sup> 20:51, 17 March 2022 (UTC)
:It might be the hyphen. "GuineaBissau" works as input, even though it shouldn't. Also, invalid values return nothing instead of an error message. See [[:Template:ISO 3166 code-3/testcases]]. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 17:42, 18 March 2022 (UTC)
::@[[User:Jonesey95|Jonesey95]], hmm, yeah. Any idea what it is about the hyphen that's leading to the bug? <span style="color:#AAA"><small>{{u|</small><span style="border-radius:9em;padding:0 5px;background:#088">[[User:Sdkb|<span style="color:#FFF">'''Sdkb'''</span>]]</span><small>}}</small></span> <sup>[[User talk:Sdkb|'''talk''']]</sup> 01:16, 23 March 2022 (UTC)
:::<syntaxhighlight lang="lua">
::: if string.find(code1,"%-") then
::: code1, code2 = string.match(code1,"^([^%-]*)%-(.*)$")
::: end
:::</syntaxhighlight>
:::This is the problamtic piece of code. It splits "Guinea-Bissau" into "Guinea" and "Bissau". I'm not sure what the design rational behind that was though. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 16:27, 31 March 2022 (UTC)
::::It's to handle the format <code><COUNTRY>-<SUBDIVISION></code>, like 'United Kingdom-England' — [[User:Wqnvlz|wqnvlz]] ([[User talk:Wqnvlz|talk]] '''·''' [[Special:Contributions/Wqnvlz|contribs]]) 17:08, 31 March 2022 (UTC)
:::::It looks like the code should check to see if "Xxxx-Yyyy" matches a valid country name first, then fall back to "Country-Subdivision". – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 19:31, 31 March 2022 (UTC)
:Continued from the [[WP:VPT#Help needed at Module talk:ISO 3166|this]] discussion.
:Let's try to finish up the fix for this so it can be used [[WP:Request a query#Map of countries by GAs/FAs per capita|where it was discovered]].
:*I made it also handle multiple hyphens. Overall, the [[Module talk:ISO 3166/testcases|tests page]] shows what has and hasn't changed (some older cases are commented out for runtime).
:*Hyphens are now significant, so input like 'GuineaBissau' no longer works. However, I'm not sure if this is really desired because quite a few subdivisions have hyphenated names that look like they might be used with spaces informally. For example, I can see one instance in the refs of [[Stoke-on-Trent]].
:**For reference, {{sl |insource:/[A-z]-[A-z]/ prefix:Module:ISO 3166/data |here's a search}} for all hyphenated names in the data
:*The way the UK data is stored ([[Module:ISO 3166/data/GB|here]]) makes the individual countries indistinguishable, so subdivisions belonging to the incorrect country like <code><nowiki>{{#invoke:ISO 3166|name|England|Glasgow}}</nowiki></code> work. How did this work in the original ISO standard?
:*Even though the top-level behaviour as seen in the tests remains largely unchanged, some of the underlying functions now handle things like <code>nil</code> vs <code>'<nowiki />'</code> differently. This might break direct invocations in other modules/templates (Hyrum's law, I suppose). Some searches for invocations:
:**{{sl |module: insource:"Module ISO 3166" |in modules}}
:**{{sl |template: insource:"invoke ISO 3166" |in templates}}
:**{{sl |all: insource:"invoke ISO 3166" |everywhere}}
:*An error message that wasn't showing up now does—is this desirable or are we relying on the template to fail silently? There are other cases that still don't have messages.
:*Profiling time varies widely; the testcase page is around 6 s with only main and 2 s with only sandbox.
: — [[User:Wqnvlz|wqnvlz]] ([[User talk:Wqnvlz|talk]] '''·''' [[Special:Contributions/Wqnvlz|contribs]]) 01:23, 2 April 2022 (UTC)
::According to those searches, the only significant direct callers of the module are {{tl|Infobox road}} & {{tl|Infobox country}} (which use the return values as-is) and {{tl|Infobox settlement}} (which uses geocoordinsert(), which ''has no testcases'').
::Regarding the section above, I don't see what about <code>safesubst:</code> wouldn't work; for good measure, I tested at {{diff||1080938489||Template:ISO 3166 code-3/testcases}} and it looks fine.
::I noticed [[Module talk:ISO 3166/testcases/core]] and [[Module talk:ISO 3166/testcases/test]] are some sort of framework for wikitext-only tests, but they're mostly broken for some reason (including a case that regressed with the sandbox changes): {{tlx|Module_talk:ISO_3166/testcases/test|name}}
::I'm not sure if that's cause for concern. {{ping|Sdkb|Jonesey95|Trappist the monk|Johnuniq}} —[[User:Wqnvlz|wqnvlz]] ([[User talk:Wqnvlz|talk]] '''·''' [[Special:Contributions/Wqnvlz|contribs]]); 19:34, 5 April 2022 (UTC)
:::Those testcases are failing because /test puts the input as argument 3, core puts it as argument 2, and then [[Module:Arguments]] is blending the frame args and the parent frame args and the input is getting duplicated (it's as if you entered {{mlx|ISO 3166|name|Canada|Canada}}). <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 17:23, 16 August 2024 (UTC)
:@[[User:Jonesey95|Jonesey95]] I implemented your suggestion to remove the hyphen only after the initial lookup fails in the sandbox at [[Special:Diff/1100609312/1240674198]]. The logic ended up being a little more complicated since the lookup is done differently depending on whether there is a second parameter:
:# If there is no second parameter and the lookup fails, then split it on the hyphen and try again
:# If there is a second parameter and the first parameter lookup succeeds and the second parameter lookup fails, and the second parameter is hyphenated, move the first part back to the first parameter (so if #1 split "Guinea-Bissau-Leste" into "Guinea" and "Bissau-Leste", try again with "Guinea-Bissau" and "Leste")
:# If there is a second parameter and the first parameter lookup fails, try stripping everything after the hyphen in the first parameter (so if #1 split "UK-ENG-Greenwich" into "UK" and "ENG-Greenwich", and #2 changed it to "UK-ENG" and "Greenwich", try again with "UK" and "Greenwich")
:All the [[Module_talk:ISO_3166/testcases|testcases]] seem to show improvement. Also pinging {{u|Frietjes}}, since he's the last to edit the module. <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 17:48, 16 August 2024 (UTC)
::<code><nowiki>{{ISO 3166 code-3|Guinea-Bissau}}</nowiki></code> still returns nothing. I think the sandbox code may still need to be moved to the live module. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 01:04, 5 February 2025 (UTC)
:::@[[User:Jonesey95|Jonesey95]] {{done}} <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 18:07, 5 February 2025 (UTC)
== Kosovo still missing ==
3 years ago asked at [[#Kosovo?]] and still relevant. I'm unfamiliar with these modules so would rather not edit and break anything here. Can this be added please? [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 13:36, 11 January 2024 (UTC)
:XK is not listed in ISO 3166 <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 20:45, 15 August 2024 (UTC)
== geocoordinsert ==
Template:Infobox settlement uses <nowiki>{{#invoke:ISO 3166|geocoordinsert}}</nowiki>, but this option is not explained on the documentation page for this module. Is it possible for someone to explain the parameters that can be used and what the output should look like for this option? [[User:Redheadkelly|Redheadkelly]] ([[User talk:Redheadkelly|talk]]) 03:11, 17 February 2024 (UTC)
== alt name does not appear to be working for "People's Republic of China" pulled from Wikidata ==
<syntaxhighlight lang=wikitext inline>{{ISO 3166 code|{{{country|{{#property:P17}}}}}}}</syntaxhighlight> is code used in {{tl|Infobox station}}. At [[Qiziwan railway station]], <code>#property:P17</code> pulls "People's Republic of China" from property 17 for that article's Wikidata item, but the ISO template returns nothing. This appears to cause the article to be placed in {{cl|Wikipedia page with obscure country}} unnecessarily.
[[Module:ISO 3166/data/National]] contains "People's Republic of China" as one of China's <code>altnames</code>. <syntaxhighlight lang=wikitext inline>{{ISO 3166 code|Ivory Coast}}</syntaxhighlight> correctly returns "CI", apparently using an altname from that same module subpage. I haven't been able to figure out where this process is failing for "People's Republic of China". Any ideas? – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 01:09, 5 February 2025 (UTC)
:I think I figured out one thing. The property call to Wikidata is returning "<syntaxhighlight lang=wikitext inline>People's Republic of China</syntaxhighlight>", using an HTML entity for the apostrophe. Now I don't know where to ask about troubleshooting that problem. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 01:15, 5 February 2025 (UTC)
::@[[User:Jonesey95|Jonesey95]] {{fixed}} [[Special:Diff/1274160458|here]]. <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 19:33, 5 February 2025 (UTC)
:::Wonderful. Thanks for figuring out where and how to fix it. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 20:45, 5 February 2025 (UTC)
== Unexpected error in infobox ==
Please see description of a bug, at [[Template talk:Infobox officeholder#ISO 3166-1 related error]]. <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 11:42, 19 August 2025 (UTC)
| |||