|
| archive = Module talk:Footnotes/Archive %(counter)d
| algo = old(180d)
| counter = 23
| maxarchivesize = 200k
| minthreadsleft = 8
| minthreadstoarchive = 2
}}
== Big ole whitelist request ==
[[Template:Cite Cambridge History of China]] (which I've had no involvement in yet) is needing the module-level whitelisting to avoid miscategorisation. There are (to date) seventeen volumes, so there are a lot of things.{{pb}}{{ping|Renata3}} can you add (*deep breath*):{{pb}}['CITEREFLoeweShaughnessy1999'] = {'Cite Cambridge History of China'}, ['CITEREFDienKnapp2019'] = {'Cite Cambridge History of China'}, ['CITEREFPeterson2016'] = {'Cite Cambridge History of China'}, ['CITEREFChaffeeTwitchett2015'] = {'Cite Cambridge History of China'}, ['CITEREFTwitchettSmith2009'] = {'Cite Cambridge History of China'}, ['CITEREFPeterson2002'] = {'Cite Cambridge History of China'}, ['CITEREFTwitchettMote1998'] = {'Cite Cambridge History of China'}, ['CITEREFMoteTwitchett1998'] = {'Cite Cambridge History of China'}, ['CITEREFFrankeTwitchett1994'] = {'Cite Cambridge History of China'}, ['CITEREFMacFarquharFairbank1991'] = {'Cite Cambridge History of China'}, ['CITEREFMacFarquharFairbank1987'] = {'Cite Cambridge History of China'}, ['CITEREFTwitchettLoewe1986'] = {'Cite Cambridge History of China'}, ['CITEREFFairbankFeuerwerker1986'] = {'Cite Cambridge History of China'}, ['CITEREFFairbank1983'] = {'Cite Cambridge History of China'}, ['CITEREFFairbankLiu1980'] = {'Cite Cambridge History of China'}, ['CITEREFTwitchett1979'] = {'Cite Cambridge History of China'}, ['CITEREFFairbank1978'] = {'Cite Cambridge History of China'}{{pb}} Thanks in advance and sorry. (Noting for clarity that "TwitchettMote1998" alongside "MoteTwitchett1998" is not an error) [[User:Folly Mox|Folly Mox]] ([[User talk:Folly Mox|talk]]) 14:58, 19 October 2024 (UTC)
:Oh actually it turns out I'm the most recent contributor to that template 🫠 I added a parameter two months ago and forgot all about it. Anyway though [[User:Folly Mox|Folly Mox]] ([[User talk:Folly Mox|talk]]) 17:01, 19 October 2024 (UTC)
Sure, {{done}}. [[User:Renata3|Renata]]•[[User talk:Renata3|3]] 00:41, 20 October 2024 (UTC) ▼
:Oh my gosh I'm so stupid! I actually went to cite one of the two relevant volumes today, and it turns out both the CITEREFs I specifically called out as {{tqq|not errors}} '''are errors'''. I must have fatfingered 1998 for 1988 and copypasted it three times without double checking the publication information.{{pb}}I feel like I heard there is a new process for the whitelist, but now I'm requesting an alteration rather than an addition, so I don't know if anyone other than {{u|Renata3}} can perform it. Can '{{!xt|CITEREFTwitchettMote1998}}' be changed to 'CITEREFTwitchettMote19'''8'''8' and '{{!xt|CITEREFMoteTwitchett1998}}' changed to 'CITEREFMoteTwitchett19'''8'''8'? The relevant books are {{doi|10.1017/CHOL9780521243339}} and {{doi|10.1017/CHOL9780521243322}}, in case anyone understandably wants to check my work.{{pb}}Sorry again. [[User:Folly Mox|Folly Mox]] ([[User talk:Folly Mox|talk]]) 14:41, 25 January 2025 (UTC)
:{{Done}}. It's an easy edit of [[Module:Footnotes/whitelist]] which can be done by any template editor. — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 15:24, 25 January 2025 (UTC)
::Thank you, {{u|hike395}}! (a road I've not exactly hiked from, but definitely camped near){{Pb}}In [[Special:Diff/1271758480]] I undid the manual {{para|ref}} I added to counteract the previously incorrect whitelist CITEREFs, but my {{tl|harvc}}s are still throwing {{red|no target}} errors. Are you able to tell what I'm doing wrong? [[User:Folly Mox|Folly Mox]] ([[User talk:Folly Mox|talk]]) 15:34, 25 January 2025 (UTC)
:::You've done nothing wrong: there's some other problem. I'm investigating. (Camping on the Sierra side of US395 can be delightful, also; some people like the solitude of the Great Basin, though). — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 16:20, 25 January 2025 (UTC)
::::{{ping|Folly Mox}} The problem is in [[Module:Harvc]]. It doesn't use the whitelist/wrapper mechanism in this module. For now, I would set {{para|ignore_err|yes}} in {{tl|Harvc}} to suppress the spurious errors. I'll think about whether we can use the mechanism here over there. — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 18:36, 25 January 2025 (UTC)
:::::Huh! Ok, thank you so much for identifying the issue! Using {{tl|harvc}} was a pretty big reason I wanted to whitelist the ''[[Cambridge History of China]]'' CITEREFs above (duplicating all that bibliographic information for each chapter is pretty bloaty), and I feel like it used to work?{{pb}}Anyway, thanks again and I'll just hide the errors, like when the building inspector comes round. [[User:Folly Mox|Folly Mox]] ([[User talk:Folly Mox|talk]]) 19:17, 25 January 2025 (UTC)
::::::{{tq|I feel like it used to work?}} It did used to work. I guess I gotta wonder if all of this churn was a good idea.
::::::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 19:26, 25 January 2025 (UTC) ▼:::::::{{ping|Trappist the monk}} I'm not sure how {{tl|harvc}} could have used the whitelist? Take a look at target_check() at line 21 in [[Module:Harvc]] (which is called from {{tl|harvc}}). It is completely separate code from target_check() in [[Module:Footnotes]]: the comment in that function explicitly says that it does not work with wrapped templates. If I'm misunderstanding something, please let me know.
:::::::Fortunately, the two functions are similar enough where we can call the [[Module:Footnotes]] target_check() from [[Module:Harvc]]. I have a version of this working in [[Module:Harvc/sandbox]], but just puzzling out how to test it. Advice is welcome. — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 19:40, 25 January 2025 (UTC)
::::::::You may be correct; I would have expected that it looked in [[Module:Footnotes/whitelist]] but apparently it doesn't do that but only looks at locally constructed anchor ids. If you have a fix, apply it.
::::::::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 20:46, 25 January 2025 (UTC)
:::::::::Oops, I just asked for comments over at [[Template talk:Harvc#Adding whitelist/wrapper template handling to this template]], not having seen your comment here. Not sure if anyone else will respond. Is it ok to wait a day or two? — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 21:32, 25 January 2025 (UTC)
::::::::::Posting here because it's the tab that spawned when I closed the last one, with the acknowledgement of the ping to the other discussion.{{pb}}I'm also favouring an immediate implementation; if new errors arise as a consequence, a rollback is easy, and no one is likely to weigh in against an update pitched as a pure bugfix. [[User:Folly Mox|Folly Mox]] ([[User talk:Folly Mox|talk]]) 15:29, 26 January 2025 (UTC)
{{Implemented}} Please let me know if you see anything odd. — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 16:14, 26 January 2025 (UTC) ▼
== Push to clear the last few ones. ==
:[[User:Andy02124|Andy02124]] ([[User talk:Andy02124|talk]]) 12:08, 9 July 2025 (UTC)
::Thanks you guys for looking into it. Btw the Category has now inched up to 85.'''1'''% fixed/empty. Seems like it had been at a straight 85% for forever... - [[User:Shearonink|Shearonink]] ([[User talk:Shearonink|talk]]) 15:14, 9 July 2025 (UTC)
== Two additions ==
I use these templates pretty often and have had [[Talk:European rabbit#broken footnotes|several issues]] that have led me here. Can the following be added to the whitelist: [[Template:Lagomorphs2018]], [[Template:HMW2016 Volume 6]]
['CITEREFSmithJohnstonAlvesHackländer2018'] = {'Lagomorphs2018'}
['CITEREFWilsonLacherMittermeier2016'] = {'HMW2016 Volume 6'} -- [[User:Reconrabbit|<span style="color:#4E8321">Recon</span>]][[User talk:Reconrabbit|<span class="skin-invert" style="color:#073131">rabbit</span>]] 17:24, 10 July 2025 (UTC)
▲{{Implemented}}:[[File:Lionhead Pleaserabbit letDobby.jpg|frameless|x50px|alt=Rabbit meindicating know if you see anything odd.done]] — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 1603: 1441, 2611 JanuaryJuly 2025 (UTC)
::Thank you! I'll be back in a long while once I'm done with the lagomorphs, since by that point I'll be using Volume 7 for the rodents. -- [[User:Reconrabbit|<span style="color:#4E8321">Recon</span>]][[User talk:Reconrabbit|<span class="skin-invert" style="color:#073131">rabbit</span>]] 12:02, 11 July 2025 (UTC)
== Template:Efloras and Template:BONAP ==
The [[:Template:Efloras|first template]] is sort of whitelisted, but it isn't working correctly. There are 4 lines dedicated to it in the whitelist variable, but this template handles citations to a number of floras published on efloras.org. The most-cited are ''Flora of North America'' and ''Flora of China'', published in many volumes with different authors and dates for each. It seems like it needs an entry in wrapper_templates to get it working properly. The [[:Template:BONAP|second template]] is simpler; it should always produce 'CITEREFKartesz2014'. (In theory the year could change in the future but it should be stable in practice.) [[User:Choess|Choess]] ([[User talk:Choess|talk]]) 20:14, 12 July 2025 (UTC)
:And as long as I'm requesting whitelisting of botany wrapper templates, [[:Template:Jepson eFlora]] can also take many different authors and will probably need to be handled in wrapper_templates. [[User:Choess|Choess]] ([[User talk:Choess|talk]]) 21:30, 12 July 2025 (UTC)
::{{ping|Choess}} I fixed {{tl|BONAP}}, but when I search for [https://petscan.wmcloud.org/?psid=38011880 harv errors] caused either by {{tl|Efloras}} or {{tl|Jepson eFlora}}, I find no errors caused by either template <s>(the one error returned by PetScan is caused by other templates)</s>. Is there a particular article you are concerned about? — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 01:59, 20 August 2025 (UTC)
== Pair skating ==
Hello,
I keep getting false positive errors for a source in [[Pair skating]]. It's for just one source, even though the code looks exactly like other sources that use the snfp template.
Looks like this: [[Pair skating#CITEREFKestnbaum2003|Kestnbaum (2003)]], p. 218. sfnp error: multiple targets (2×): CITEREFKestnbaum2003 ([[:Category:Harv and Sfn template errors|help]]) Harv error: CITEREFKestnbaum2003 has multiple targets (2×).
Hopefully, someone will assist. I've tried to resolve the problem myself, but so far have been unsuccessful. It's very frustrating! [[User:Figureskatingfan|Christine (Figureskatingfan)]] ([[User talk:Figureskatingfan|talk]]) 00:34, 17 August 2025 (UTC)
:You might want to replace [[Special:Permalink/1306289786#cite_note-94|ref 86 (permalink)]] with an appropriate {{tlx|sfnp}} template because Kestnbaum 2003 is also listed under [[Special:Permalink/1306289786#Works cited|§Works cited (permalink)]].
▲::::::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 1900: 2646, 2517 JanuaryAugust 2025 (UTC)
::@[[User:Trappist the monk|Trappist the monk]], that did it! It was a simple solution all along, I guess I just needed a second pair of eyes to see it. Thanks so much, especially for your quick response. You're a gem! [[User:Figureskatingfan|Christine (Figureskatingfan)]] ([[User talk:Figureskatingfan|talk]]) 04:45, 17 August 2025 (UTC)
== Yet another Tolkien to whitelist ==
['CITEREFTolkien2024'] = template_names['ME-ref']
Thanks,
[[User:Andy02124|Andy02124]] ([[User talk:Andy02124|talk]]) 18:25, 19 August 2025 (UTC)
▲Sure, :{{ doneDone}} . — [[User: Renata3Hike395| Renatahike395]] • ([[User talk: Renata3Hike395| 3talk]] ) 0001: 4151, 20 OctoberAugust 20242025 (UTC)
| 