Module talk:Footnotes: Difference between revisions

Revision as of 13:41, 19 June 2018

Latest revision as of 11:32, 20 August 2025

Line 1:

{{talk header}}

==This doesn't work properly in Template:Sfn==

{{permanently protected}}

Please see [[Template talk:Sfn#Lua version is broken]]. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] ([[User talk:Redrose64|talk]]) 22:43, 2 April 2013 (UTC)

{{User:MiszaBot/config

| archive = Module talk:Footnotes/Archive %(counter)d

| algo = old(180d)

| counter = 3

| maxarchivesize = 200k

| minthreadsleft = 8

| minthreadstoarchive = 2

}}

== Push to clear the last few ones. ==

== Broken parameter ==

See [[Wikipedia:Bot requests#Help clear Category:Harv and Sfn no-target errors]].

Please see [[Template talk:Harvard citation no brackets#Broken parameter]]. Similar templates are probably similarly broken. [[User:Wtmitchell|Wtmitchell]] [[User talk:Wtmitchell|(talk)]] <small>(earlier ''Boracay Bill'')</small> 07:13, 28 April 2013 (UTC)

&#32;<span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 22:05, 25 January 2025 (UTC)

:This should be fixed. [[User:Dragons flight|Dragons flight]] ([[User talk:Dragons flight|talk]]) 10:18, 28 April 2013 (UTC)

== More"n.d.a" thanvs. six"n.d. parametersa" ==

It would help if the code was more compatible with CS1. At the moment it does not handle more than four authors elegantly. See [[Module talk:Citation/CS1#CITEREF and harvnb and CITEREF and CS1]]. -- [[User:PBS|PBS]] ([[User talk:PBS|talk]]) 13:09, 21 December 2013 (UTC)

At [[Capri-Sun]], I have two references that I'd written as <code><nowiki>{{harvnb|Capri Sun Group|n.d. a}}</nowiki></code> and <code><nowiki>{{harvnb|Capri Sun Group|n.d. b}}</nowiki></code>. I could've sworn they worked as intended when they were added, but maybe I just overlooked this before, because I don't spot anything relevant in the history. Either way, as it stands, these render as "[[Capri-Sun#CITEREFCapri Sun Groupn.d. a|Capri Sun Group & n.d. a]]" and ""[[Capri-Sun#CITEREFCapri Sun Groupn.d. b|Capri Sun Group & n.d. b]]", which appears to be because [[Module:Footnotes#L-131|L131]] is expecting no space before the disambiguating letter. But I don't think most people would write "n.d.a", which looks like the ''a'' is part of an acronym. "n.d. a" is much clearer. I would suggest that both should be allowed, as should "nd a" in contrast to "nda". I believe all we'd have to do is add a <code> ?</code> before the <code>%l</code> on lines 65, 66, 131, and 132. <span style="font-family:courier"> -- [[User:Tamzin|<span style="color:#E6007A">Tamzin</span>]]</span><sup class="nowrap">&#91;[[User talk:Tamzin|<i style="color:#E6007A">cetacean needed</i>]]]</sup> <small>([[User:Tamzin/🤷|they&#124;xe&#124;🤷]])</small> 03:06, 7 April 2025 (UTC)

== Markup ==

:Those references appear to be working as expected and I'm seeing them displayed with a space between n.d. and the disambiguation. What error message are you seeing? It may have to do with the script you're using -- <small>LCU</small> '''[[User:ActivelyDisinterested|A<small>ctively</small>D<small>isinterested</small>]]''' <small>''«[[User talk:ActivelyDisinterested|@]]» °[[Special:Contributions/ActivelyDisinterested|∆t]]°''</small> 11:12, 7 April 2025 (UTC)

The Lua CS1 templates strip markup, such as bold or italics, where this module does not. Thus if markup is used in {{tl|sfn}} or variant, then the link and anchor will not match. --<span style="color:Turquoise">''''' &nbsp;[[User:Gadget850|Gadget850]]'''''^{[[User talk:Gadget850|&nbsp;''talk'']]}</span> 11:28, 6 March 2014 (UTC)

::@[[User:ActivelyDisinterested|ActivelyDisinterested]]: The issue isn't the space falling to render; it's the ampersand showing up because the module reads "n.d. a" as a name rather than a date <span style="font-family:courier"> -- [[User:Tamzin|<span style="color:#E6007A">Tamzin</span>]]</span><sup class="nowrap">&#91;[[User talk:Tamzin|<i style="color:#E6007A">cetacean needed</i>]]]</sup> <small>([[User:Tamzin/🤷|they&#124;xe&#124;🤷]])</small> 14:27, 7 April 2025 (UTC)

:::{{harvnb|Capri Sun Group|n.d.a}}

:::{{harvnb|Capri Sun Group|n.d.b}}

:::{{harvnb|Capri Sun Group|1997a}}

:::Without spaces &uarr;

:::{{harvnb|Capri Sun Group|n.d. a}}

:::{{harvnb|Capri Sun Group|n.d. b}}

:::{{harvnb|Capri Sun Group|1997 a}}

:::With spaces &uarr; [[User:Rjjiii|<span style="font-variant:small-caps;">Rjjⁱⁱⁱ</span>]] ([[User talk:Rjjiii|talk]]) 14:31, 7 April 2025 (UTC)

::::Yes, a space makes the module read it as a name rather than a date, and this put an ampersand before it. What I'm saying is that, while that's reasonable for years like 1997a, for n.d. in particular a space should be understood as part of the date. <span style="font-family:courier"> -- [[User:Tamzin|<span style="color:#E6007A">Tamzin</span>]]</span><sup class="nowrap">&#91;[[User talk:Tamzin|<i style="color:#E6007A">cetacean needed</i>]]]</sup> <small>([[User:Tamzin/🤷|they&#124;xe&#124;🤷]])</small> 15:01, 7 April 2025 (UTC)

:::::Sorry misconstrued the issue. -- <small>LCU</small> '''[[User:ActivelyDisinterested|A<small>ctively</small>D<small>isinterested</small>]]''' <small>''«[[User talk:ActivelyDisinterested|@]]» °[[Special:Contributions/ActivelyDisinterested|∆t]]°''</small> 15:10, 7 April 2025 (UTC)

::::::I think the pre-module version of the harv/sfn templates always treated the final parameter as the year, [[User:Rjjiii|<span style="font-variant:small-caps;">Rjjⁱⁱⁱ</span>]] ([[User talk:Rjjiii|talk]]) 20:54, 7 April 2025 (UTC)

::::::@[[User:Tamzin|Tamzin]] & [[User:ActivelyDisinterested|ActivelyDisinterested]]:

::::::[https://blog.apastyle.org/apastyle/2011/10/reference-twins.html APA uses n.d.-x]. It seems like [https://files.taylorandfrancis.com/tf_chicagoad.pdf Chicago] and [https://libguides.jcu.edu.au/HarvardAGSM/dates Harvard] referencing do as well. I've added the pattern for that to the sandbox module:

::::::;Live

::::::{{harvnb|Capri Sun Group|n.d.-a}}

::::::;Sandbox

::::::{{Harvard citation no brackets/sandbox|Capri Sun Group|n.d.-a}}

::::::But you'd also need to add support in [[Module:Citation/CS1]]. Right now it gives an error if you suffix anything to n.d. separated by a hyphen or space (only {{harvnb|Capri Sun Group|n.d.a}} works):

::::::* {{citation|author=Capri Sun Group |date=n.d. |title=Frequently Asked Questions |work=Capri-Sun.com |mode=cs1}}

::::::* {{citation|author=Capri Sun Group |date=n.d.a |title=Frequently Asked Questions |work=Capri-Sun.com |mode=cs1}}

::::::* {{citation|author=Capri Sun Group |date=n.d. a |title=Frequently Asked Questions |work=Capri-Sun.com |mode=cs1}}

::::::* {{citation|author=Capri Sun Group |date=n.d.-a |title=Frequently Asked Questions |work=Capri-Sun.com |mode=cs1 |ref={{sfnref|Capri Sun Group|n.d.-a}}}}

::::::Also some stats while thinking about changes:

::::::* 5,041,630 pages [https://en.wikipedia.org/wiki/Special:Search?go=Go&search=hastemplate%3Acite_web&ns0=1&ns1=1&ns2=1&ns3=1&ns4=1&ns5=1&ns6=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1&ns100=1&ns101=1&ns118=1&ns119=1&ns126=1&ns127=1&ns710=1&ns711=1&ns828=1&ns829=1 with cite web]

::::::* 15,112 pages [https://en.wikipedia.org/wiki/Special:Search?go=Go&search=hastemplate%3Acite_web+insource%3A%22date%3Dn.d.%22&ns0=1&ns1=1&ns2=1&ns3=1&ns4=1&ns5=1&ns6=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1&ns100=1&ns101=1&ns118=1&ns119=1&ns126=1&ns127=1&ns710=1&ns711=1&ns828=1&ns829=1 with cite web using n.d.]

::::::* 45 pages [https://en.wikipedia.org/wiki/Special:Search?go=Go&search=hastemplate%3Acite_web+insource%3A%22date%3Dn.d.a%22&ns0=1&ns1=1&ns2=1&ns3=1&ns4=1&ns5=1&ns6=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1&ns100=1&ns101=1&ns118=1&ns119=1&ns126=1&ns127=1&ns710=1&ns711=1&ns828=1&ns829=1 with cite web and n.d.a] (without spaces)

::::::* 55% of cite web invocations [https://bambots.brucemyers.com/TemplateParam.php?wiki=enwiki&template=Cite+web have no date parameter] (not an issue without author-date short citations)

::::::I'd support adding support to both modules for "n.d.-" if that's the norm in published citation styles. [[User:Rjjiii|<span style="font-variant:small-caps;">Rjjⁱⁱⁱ</span>]] ([[User talk:Rjjiii|talk]]) 11:01, 8 April 2025 (UTC)

:::::::Continued at: [[Help_talk:Citation_Style_1#"n.d.a",_"n.d._a",_or_"n.d.-a"]] [[User:Rjjiii|<span style="font-variant:small-caps;">Rjjⁱⁱⁱ</span>]] ([[User talk:Rjjiii|talk]]) 03:31, 12 April 2025 (UTC)

::::::::So far, no response at all over there. Idk if it's a good idea to add support for a type of date in only one of the modules. [[User:Rjjiii|<span style="font-variant:small-caps;">Rjjⁱⁱⁱ</span>]] ([[User talk:Rjjiii|talk]]) 04:36, 21 April 2025 (UTC)

== Re [[:Category:Harv and Sfn no-target errors]] ==

== Protected edit request on 27 June 2014 ==

I've been trying to whack down the amount of articles in this Category and have come across a List that I can't find any Harv errors or Harv warnings in, and yet here is [[List of fictional diseases]] listed amongst the error'fied articles. Can anyone tell me why? Thanks - [[User:Shearonink|Shearonink]] ([[User talk:Shearonink|talk]]) 03:33, 9 July 2025 (UTC)

{{edit protected|Module:Footnotes|answered=yes}}

<!-- Begin request -->

:It's a false positive, because {{tl|Cite MW}} is a template that wraps {{tl|cite web}}, and this module didn't know about it yet. I'll fix. Please feel free to report any such mysterious false positives here. Thanks for cleaning all of this up! — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 07:19, 9 July 2025 (UTC)

[[Module:Citation/CS1]] runs <code>mw.uri.anchorEncode()</code> on <code>options.id</code> before generating the <code><span id="</code>... line. For compatibility between generated <code>id</code> in that module and the <code>#CITEREF</code> generated here, I think [https://en.wikipedia.org/w/index.php?title=Module%3ASandbox%2F%D8%AF%D8%A7%D9%84%D8%A8%D8%A7%2FSandbox&diff=614605646&oldid=614604084 this change] needs to be applied on this module."></span></code>

:The Trappist script doesn’t flag false positives but the css modification (as described on the error page) does.

:[[User:Andy02124|Andy02124]] ([[User talk:Andy02124|talk]]) 12:08, 9 July 2025 (UTC)

::Thanks you guys for looking into it. Btw the Category has now inched up to 85.'''1'''% fixed/empty. Seems like it had been at a straight 85% for forever... - [[User:Shearonink|Shearonink]] ([[User talk:Shearonink|talk]]) 15:14, 9 July 2025 (UTC)

== Two additions ==

([https://en.wikipedia.org/w/index.php?title=User:%D8%AF%D8%A7%D9%84%D8%A8%D8%A7/test1&oldid=614606123 Here] is an example footnote which is not linked to it's citation and I think it's because of the above mentioned problem.)

<!-- End request -->

<span style="border:solid 2px #1E90FF;border-radius:3px">[[user:دالبا|Dalba]]</span> 07:38, 27 June 2014 (UTC)

:[[File:Yes check.svg|20px|link=]] '''Done'''<!-- Template:EP --> Thanks for the fix! — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr. Stradivarius</span>]]''''' ^{[[User talk:Mr. Stradivarius|♪ talk ♪]]} 12:15, 27 June 2014 (UTC)

I use these templates pretty often and have had [[Talk:European rabbit#broken footnotes|several issues]] that have led me here. Can the following be added to the whitelist: [[Template:Lagomorphs2018]], [[Template:HMW2016 Volume 6]]

== Template:sfnp ==

['CITEREFSmithJohnstonAlvesHackländer2018'] = {'Lagomorphs2018'}

['CITEREFWilsonLacherMittermeier2016'] = {'HMW2016 Volume 6'} -- [[User:Reconrabbit|<span style="color:#4E8321">Recon</span>]][[User talk:Reconrabbit|<span class="skin-invert" style="color:#073131">rabbit</span>]] 17:24, 10 July 2025 (UTC)

{{tl|sfnp}} could usefully be implemented within this module as well as {{tl|sfn}}. As far as I can see, <code>function f.sfnp( frame )</code> would simply duplicate <code>function f.sfn( frame )</code> with the addition of:

:<code>args.bracket_year_left = "(";</code>

:<code>args.bracket_year_right = ")";</code>

An oddity at present is that {{para|postscript|none}} works for {{tl|sfn}} but not for {{tl|sfnp}}. [[User:Peter coxhead|Peter coxhead]] ([[User talk:Peter coxhead|talk]]) 20:21, 15 December 2014 (UTC)

:[[File:Lionhead rabbit Dobby.jpg|frameless|x50px|alt=Rabbit indicating done]] — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 03:41, 11 July 2025 (UTC)

:It does in a sort of round-about way:

::Thank you! I'll be back in a long while once I'm done with the lagomorphs, since by that point I'll be using Volume 7 for the rodents. -- [[User:Reconrabbit|<span style="color:#4E8321">Recon</span>]][[User talk:Reconrabbit|<span class="skin-invert" style="color:#073131">rabbit</span>]] 12:02, 11 July 2025 (UTC)

::{{tlx|sfnp}} calls {{tlx|Harvard citation/core}} calls [[Module:Footnotes]] function harvard_core().

== Template:Efloras and Template:BONAP ==

:Is {{para|postscript|none}} necessary for {{tld|sfnp}}? The code seems to indicate that {{tlx|sfn}} uses '.' for a default of postscript character. If {{para|postscript}} is empty or omitted, then {{tld|sfnp}} uses an empty string as the default postscript.

The [[:Template:Efloras|first template]] is sort of whitelisted, but it isn't working correctly. There are 4 lines dedicated to it in the whitelist variable, but this template handles citations to a number of floras published on efloras.org. The most-cited are ''Flora of North America'' and ''Flora of China'', published in many volumes with different authors and dates for each. It seems like it needs an entry in wrapper_templates to get it working properly. The [[:Template:BONAP|second template]] is simpler; it should always produce 'CITEREFKartesz2014'. (In theory the year could change in the future but it should be stable in practice.) [[User:Choess|Choess]] ([[User talk:Choess|talk]]) 20:14, 12 July 2025 (UTC)

:—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 20:38, 15 December 2014 (UTC)

:And as long as I'm requesting whitelisting of botany wrapper templates, [[:Template:Jepson eFlora]] can also take many different authors and will probably need to be handled in wrapper_templates. [[User:Choess|Choess]] ([[User talk:Choess|talk]]) 21:30, 12 July 2025 (UTC)

::{{ping|Choess}} I fixed {{tl|BONAP}}, but when I search for [https://petscan.wmcloud.org/?psid=38011880 harv errors] caused either by {{tl|Efloras}} or {{tl|Jepson eFlora}}, I find no errors caused by either template <s>(the one error returned by PetScan is caused by other templates)</s>. Is there a particular article you are concerned about? — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 01:59, 20 August 2025 (UTC)

== Pair skating ==

::Nope, <code><nowiki>{{sfnp|James|2004}}</nowiki></code> generates the following footnote.{{sfnp|James|2004}}

::(After the tweak noted below, <code><nowiki>{{sfnp|Smith|2005|ps=none}}</nowiki></code> generates the following footnote.{{sfnp|Smith|2005|ps=none}})

{{reflist-talk}}

::So as a CS2 user, I end up with <code><nowiki>{{sfnp|ps=|...}}</nowiki></code> but would prefer {{para|ps|none}} for same reason as you (well, actually I'd prefer another template, and did once create one, but the consensus was to delete it).

::Doing things in a "round-about way" is a sure recipe for software errors (at least that's what I used to teach in first-year software engineering). The complexity of the current code is shown by the fact that it isn't easy to work out what {{tl|sfnp}} actually does. A separate function is clearer and easier to maintain. Or perhaps better still (because more modular), pass appropriate parameters to <code>f.sfn()</code>. [[User:Peter coxhead|Peter coxhead]] ([[User talk:Peter coxhead|talk]]) 21:13, 15 December 2014 (UTC)

Hello,

:::Right, it gets it's postscript from the template call to {{tlx|Harvard citation/core}}. [[Module:Footnotes]] tweaked and I tweaked your example.

I keep getting false positive errors for a source in [[Pair skating]]. It's for just one source, even though the code looks exactly like other sources that use the snfp template.

:::You'll get no argument from me in support of round-about code. Every line must be maintained. I'll think about integrating {{tlx|sfnp}} in the module.

Looks like this: [[Pair skating#CITEREFKestnbaum2003|Kestnbaum (2003)]], p. 218. sfnp error: multiple targets (2×): CITEREFKestnbaum2003 ([[:Category:Harv and Sfn template errors|help]]) Harv error: CITEREFKestnbaum2003 has multiple targets (2×).

:::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 22:02, 15 December 2014 (UTC)

Hopefully, someone will assist. I've tried to resolve the problem myself, but so far have been unsuccessful. It's very frustrating! [[User:Figureskatingfan|Christine (Figureskatingfan)]] ([[User talk:Figureskatingfan|talk]]) 00:34, 17 August 2025 (UTC)

::::Ok, tweaked {{tlx|sfnp/sandbox}} to pass the bracket defaults as {{para|bracket_year_left|(}} and {{para|bracket_year_right|)}} to <code>f.sfn()</code> in [[Module:Footnotes/sandbox]] where those parameters override the defaults normally used by {{tlx|sfn}}:

:You might want to replace [[Special:Permalink/1306289786#cite_note-94|ref 86 (permalink)]] with an appropriate {{tlx|sfnp}} template because Kestnbaum 2003 is also listed under [[Special:Permalink/1306289786#Works cited|§Works cited (permalink)]].

:::::Some text using {{tlx|sfnp}}.{{sfnp|Smith|2005|ps=none}}

:—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 00:46, 17 August 2025 (UTC)

:::::Some text using {{tlx|sfnp/sandbox}}.{{sfnp/sandbox|Smith|Jones|2005}}

::@[[User:Trappist the monk|Trappist the monk]], that did it! It was a simple solution all along, I guess I just needed a second pair of eyes to see it. Thanks so much, especially for your quick response. You're a gem! [[User:Figureskatingfan|Christine (Figureskatingfan)]] ([[User talk:Figureskatingfan|talk]]) 04:45, 17 August 2025 (UTC)

:::::Some text using {{tlx|sfnp/sandbox|ps{{=}}none}}.{{sfnp/sandbox|Smith|Jones|Babcock|2005|ps=none}}

{{reflist-talk}}

== Yet another Tolkien to whitelist ==

::::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 13:08, 16 December 2014 (UTC)

['CITEREFTolkien2024'] = template_names['ME-ref']

:::::A much more elegant approach than the current version; hopefully soon to be deployed. [[User:Peter coxhead|Peter coxhead]] ([[User talk:Peter coxhead|talk]]) 18:56, 16 December 2014 (UTC)

Thanks,

::::::Done.

[[User:Andy02124|Andy02124]] ([[User talk:Andy02124|talk]]) 18:25, 19 August 2025 (UTC)

::::::{{Done}} — [[User:Trappist the monkHike395|Trappist the monkhike395]] ([[User talk:Trappist the monkHike395|talk]]) 0001:3851, 1720 DecemberAugust 20142025 (UTC)

::::::Thanks! [[User:Peter coxhead|Peter coxhead]] ([[User talk:Peter coxhead|talk]]) 16:54, 17 December 2014 (UTC)

== Dashes and hyphens, oh my ==

A number of threads have shown up on [[WT:VPT]] (e.g. [[WP:VPT#Help in fixing a "cite error"]]) and elsewhere regarding the change in MediaWiki to output an error where the same names are used in a reference but where the reference is defined differently.

It seems to me that a basic level of checking for that could be implemented in this module, either (namely) to treat (example) {{para|p}} and {{para|pp}} the same before outputting the reference for [[Template:sfn]] or to do some basic level of sanity checking e.g. where {{para|p}} uses a dash/hyphen (and should not) or where {{para|pp}} doesn't use one of the set: <code>(,|-)</code> (or similar).

Thoughts? --[[User:Izno|Izno]] ([[User talk:Izno|talk]]) 17:17, 14 November 2015 (UTC)

:Only that there's a need to be careful not to exclude electronic publications which increasingly have "page" numbers with non-numerical characters in them. [[User:Peter coxhead|Peter coxhead]] ([[User talk:Peter coxhead|talk]]) 17:26, 14 November 2015 (UTC)

::My suggestion would be only to look for certain punctuation. --[[User:Izno|Izno]] ([[User talk:Izno|talk]]) 17:40, 14 November 2015 (UTC)

:::And then do what once the detector detects whatever it is set to detect?

:::This is difficult. {{para|p|A-1}} or {{para|p|17-6}} are legitimate page numbers.

:::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 18:10, 14 November 2015 (UTC)

::::Precisely. [[User:Peter coxhead|Peter coxhead]] ([[User talk:Peter coxhead|talk]]) 22:05, 14 November 2015 (UTC)

== Auto-formatting dashes in parameter "pages" ==

[[Module:Citation/CS1]] based templates automatically replace hyphens (-) with endashes (–) when hyphens are typed in the <code>|pages=</code> parameter. Is it possible to implement this feature into this module?<br />[[User:Αντιγόνη|Αντιγόνη]] ([[User talk:Αντιγόνη|talk]]) 07:24, 28 September 2016 (UTC)

:Yes, we can do that here if there is sufficient support for it. If we do add it, I would like to see us adopt some sort of mechanism that allows editors to override the auto-conversion. [[Template talk:Citation/Archive 8#Hyphens in page ranges and subsections within edited-volume chapters|Elsewhere]] I suggested a couple of ways that this might be accomplished. Those proposals were not taken up.

:—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 10:40, 28 September 2016 (UTC)

::So what would happen with something like {{para|pp|A-1–A-15}}? Entirely possible with electronic publications. [[User:Peter coxhead|Peter coxhead]] ([[User talk:Peter coxhead|talk]]) 14:15, 28 September 2016 (UTC)

:::Which is why I suggested {{para|pp|((A-1–A-15))}} or {{para|pp|A--1-A--15}} as ways to tell the module to 'do it this way': pp.&nbsp;A-1–A-15.

:::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 14:48, 28 September 2016 (UTC)

::::Well, either there has to be some special mechanism, as you suggest, or no automatic replacement, which I prefer. [[User:Peter coxhead|Peter coxhead]] ([[User talk:Peter coxhead|talk]]) 15:24, 28 September 2016 (UTC)

== Last change broke date=n.d. ==

Please add a condition in function core to avoid adding the ampersand before the date when date=n.d.: <code><nowiki>{{harv|Author|n.d.}}</nowiki></code> results in {{harv|Author|n.d.}}. [[Special:Contributions/72.43.99.146|72.43.99.146]] ([[User talk:72.43.99.146|talk]]) 00:30, 18 October 2016 (UTC)

:Amendment: even though it should be obvious anyway, I should have stated that any iteration of an undated reference gets similar treatment ("undated", "no date" etc.) since the module thinks that these are author names. [[Special:Contributions/72.43.99.146|72.43.99.146]] ([[User talk:72.43.99.146|talk]]) 00:40, 18 October 2016 (UTC)

== test cases ==

Hi. I've just run the test cases against some small changes to the code in the sandbox, with lamentable results. I reverted my changes and the test cases still fail. Is this expected? Alternatively, should I copy the main code into the sandbox to ensure that the sandbox code is up to date? I don't want to damage anyone else's work. Regards, [[User:Martin of Sheffield|Martin of Sheffield]] ([[User talk:Martin of Sheffield|talk]]) 22:40, 21 August 2017 (UTC)

:The {{tlx|sfn}} tests have never 'passed' as far as I know because two {{tld|sfn}} templates with identical input parameters must be separately distinguishable from each other else the back-links won't work. Two instances of the same template:

::<code><nowiki>{{sfn|brown|red|orange|2017}}</nowiki></code>

:produce:

::<code><nowiki><sup id="cite_ref-FOOTNOTEbrownredorange2017_1-0" class="reference"><a href="#cite_note-FOOTNOTEbrownredorange2017-1">&amp;#91;1&amp;#93;</a></sup></nowiki></code>

::<code><nowiki><sup id="cite_ref-FOOTNOTEbrownredorange2017_1-1" class="reference"><a href="#cite_note-FOOTNOTEbrownredorange2017-1">&amp;#91;1&amp;#93;</a></sup></nowiki></code>

:I suspect that the values used in the comparison made by the test code are the values of two stripmarkers:

::<code>'"`UNIQ--ref-0000000A-QINU`"'</code>

::<code>'"`UNIQ--ref-0000000C-QINU`"'</code>

:Stripmarkers are replaced with actual content long after the template and module code has run.

:—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 09:48, 22 August 2017 (UTC)

== Page needed ==

Have recent changes to this template caused the use of {{tlx|page needed}} as a value for the parameter "p=" caused a break. If so it has broken many pages. See for example [https://en.wikipedia.org/w/index.php?title=Second_Boer_War&diff=next&oldid=763280920 this edit] (Revision as of 09:56, 2 February 2017) mentioned in this section [[Talk:Second Boer War#Fixing style/layout errors]].

*<nowiki>{{sfn|Haydon|1964|p={{page needed|date=February 2017}} }}</nowiki>

*{{sfn|Haydon|1964|p={{page needed|date=February 2017}} }}

{{reflist talk}}

If so please revert the and discuss how to fix it, as the change as this will have broken many pages, and the fix of placing page needed outside the short citation is not appropriate. -- [[User:PBS|PBS]] ([[User talk:PBS|talk]]) 20:03, 7 December 2017 (UTC)

:No recent changes. Last change was 18 September as you can see from the [https://en.wikipedia.org/w/index.php?title=Module:Footnotes&action=history history]. What is interesting is that if you were to rewrite that example without a date, it appears to function correctly. <code><nowiki>{{sfn|Haydon|1964|p={{page needed}} }}</nowiki></code>{{sfn|Haydon|1964|p={{page needed}} }}

<div style="margin-left:3.2em">{{reflist talk}}</div>

:Something mysteriously wrong with {{tlx|page needed}}?

:—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 21:20, 7 December 2017 (UTC)

::{{tlx|Page needed}} needs a date (a bot will added it). It seems to work now, so (as always) as we do not use version numbers the broken text no longer shows an error. So for the record/archive what was fixed? -- [[User:PBS|PBS]] ([[User talk:PBS|talk]]) 19:54, 10 December 2017 (UTC)

:::{{diff|Template:Fix|814292698|713657347|This}}; described [[Wikipedia:Village pump (technical)#Either Template:Sfn or some_subtemplate of it appears to be broken|here]].

:::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 03:13, 11 December 2017 (UTC)

::::Thanks. For the record now the above is now archived: [[Wikipedia:Village pump (technical)/Archive 161#Either Template:Sfn or some subtemplate of it appears to be broken]]. -- [[User:PBS|PBS]] ([[User talk:PBS|talk]]) 18:41, 18 December 2017 (UTC)

== Logic error in handling of "n.d." ==

The conditional statement in lines 70-72 ("{{tq|prevent double periods when date is 'n.d.'}}{{-"}}). It forces {{para|ps|none}} (<code>"then args.postscript = <nowiki>''</nowiki>"</code>). Please fix. [[Special:Contributions/108.182.15.109|108.182.15.109]] ([[User talk:108.182.15.109|talk]]) 13:26, 19 June 2018 (UTC)

:The error is harder to see because it is only visible when the in-source ___location is absent. [[Special:Contributions/108.182.15.109|108.182.15.109]] ([[User talk:108.182.15.109|talk]]) 13:33, 19 June 2018 (UTC)

::Can you provide a clear example of what you mean?

::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 13:41, 19 June 2018 (UTC)