Content deleted Content added
m Archiving 1 discussion(s) to Module talk:Mapframe/Archive 2) (bot |
|||
| (714 intermediate revisions by 98 users not shown) | |||
Line 1:
{{Permanently protected}}
{{talk header|custom_header=This is the [[WP:TPG|talk page]] for discussing improvements to the [[Module:Mapframe|Mapframe]] module, and the related [[Template:Maplink|Maplink]] template.}}
{{faq|see also=[[mw:Help:Extension:Kartographer]]|collapsed=no}}
{{central|text=[[Template talk:Maplink]] and related subpages redirect here}}
{{User:MiszaBot/config
| algo = old(150d)
| archive = Module talk:Mapframe/Archive %(counter)d
| counter = 2
| maxarchivesize = 150K
| archiveheader = {{Aan}}
| minthreadstoarchive = 1
| minthreadsleft = 3
}}
== Thumbnail rendering issue in [[José Salvador Alvarenga]] ==
Point 1 and most of the line not visible, something to do with the 180th meridian line. Same issue on the [[:fr:José_Salvador_Alvarenga|fr]] and [[:zh:荷西·薩爾瓦多·阿爾瓦倫加|zh]] pages. Also is there a way to make the 180 line not visible? [[User:Sohryu Asuka Langley Not Shikinami|Sohryu Asuka Langley Not Shikinami]] ([[User talk:Sohryu Asuka Langley Not Shikinami|talk]]) 05:28, 29 April 2025 (UTC)
:@[[User:Sohryu Asuka Langley Not Shikinami|Sohryu Asuka Langley Not Shikinami]] This is a bug. Only happens in "View mode". But I propose you to take some screenshot of OSM map, for this track, modify that and upload it using template OpenStreetMap in WikiCommons. Best regards. [[User:Hooman Mallahzadeh|Hooman Mallahzadeh]] ([[User talk:Hooman Mallahzadeh|talk]]) 06:19, 29 April 2025 (UTC)
== How not dispay top right square for "Show in full screen" ==
Hi, is there anyway to avoid showing top right while square ([ ]) for "Show in full screen"? Sometime this square disrupts the map. Thanks, [[User:Hooman Mallahzadeh|Hooman Mallahzadeh]] ([[User talk:Hooman Mallahzadeh|talk]]) 13:41, 5 May 2025 (UTC)
:Don't think you can. Just increase the height of the frame to accommodate the map. Regs, [[User:The Equalizer|The Equalizer]] ([[User talk:The Equalizer|talk]]) 20:10, 7 May 2025 (UTC)
::@[[User:The Equalizer|The Equalizer]] Implementation of "Hide" does not seem so hard. Just add an argument named "|hide square=yes" and then in the span of OSM map apply this style "display: none;".
::Hiding
:::I thought the box is also a subtle hint that it's a clickthrough and scalable, not just a static picture. But propose the removal via Phab if desired. [[User:The Equalizer|The Equalizer]] ([[User talk:The Equalizer|talk]]) 18:34, 8 May 2025 (UTC)
::::@[[User:The Equalizer|The Equalizer]] No need for request of Phabricator. We should set "display:none;" CSS property for ".mw-kartographer-fullScreen" class. I tested it successfully in the inspector view my inspector of my browser.
::::I think it can be implemented by modifying this template only.
::::Line 1108 add
<syntaxhighlight>
displaysquare = util.getParameterValue(args, "displaySquare") or L10n.defaults.displaySquare,
</syntaxhighlight>
::::and line 962 add
<syntaxhighlight>
if options.displaySquare == "no" then
local whiteSquare = assert(document:getElementsByClassName("mw-kartographer-fullScreen"))
whiteSquare:css("display", "none")
</syntaxhighlight> [[User:Hooman Mallahzadeh|Hooman Mallahzadeh]] ([[User talk:Hooman Mallahzadeh|talk]]) 04:03, 9 May 2025 (UTC)
:I think this square is not required at all, therefore we can remove it as a default setting. Because there exists a tooltip for this purpose. [[User:Hooman Mallahzadeh|Hooman Mallahzadeh]] ([[User talk:Hooman Mallahzadeh|talk]]) 14:27, 9 May 2025 (UTC)
== Failure to set frame-align=none ==
As the alignment of thumbnail images can be set to <code>none</code> (see [[Help:Pictures]]), its reasonable to let this module get support as well. Unfortunately, if I set {{para|frame-align|none}}, I see this notice: <nowiki><mapframe>: Attribute "align" has an invalid value</nowiki>. -- [[User:Great Brightstar|Great Brightstar]] ([[User talk:Great Brightstar|talk]]) 10:29, 20 May 2025 (UTC)
:This map does not allow thumbnail-sized images yet. See [[Module_talk:Mapframe/Archive_2#Can_this_map_be_scaled_to_match_readers'_thumbnail_size_preferences?|this archived discussion from 2023]], and a [[Template_talk:Infobox_mapframe#How_do_I_set_the_mapframe_width_to_the_reader's_thumb_size_preference?|similar archived discussion from March 2025]]. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 00:48, 22 May 2025 (UTC)
== Edit request 28 May 2025 ==
{{Edit template-protected|answered=yes}}
'''Description of suggested change:'''
On line 94, change "paramter" to "parameter."
'''Diff:'''
{{TextDiff|1=valid values for type paramter|2=valid values for type parameter}} [[User:Shonebrooks|ShoneBrooks]] ([[User talk:Shonebrooks|talk]]) 15:00, 28 May 2025 (UTC)
:{{complete2}}. '''''[[User:Paine Ellsworth|<span style="font-size:92%;color:darkblue;font-family:Segoe Script">P.I. Ellsworth</span>]]''''' , [[Editor|<span style="color:black">ed.</span>]] [[User talk:Paine Ellsworth|<sup>put'er there</sup>]] <small>20:29, 28 May 2025 (UTC)</small>
== Display in title ==
There's this comment in the code, saying "[display=title] makes maplink wikitext that will be located in the top-right of the title of the page (the same place where coords with display=title are positioned)." That does not seem to work: the styles associated with id=coordinates cannot do that. Is this option even useful? I'm wondering if it should be removed from the template's documentation, it seems misleading. [[User:Ponor|Ponor]] ([[User talk:Ponor|talk]]) 20:30, 10 June 2025 (UTC)
:[[Special:Diff/1294960231|'''This edit''']] will put the display=title marker in the indicator area, which seems to work for all desktop skins, as can be seen at [[Template:Maplink/sandbox]] (as long as the module sandbox change is on). Is that what we want? [[User:Ponor|Ponor]] ([[User talk:Ponor|talk]]) 21:21, 10 June 2025 (UTC)
----
{{edit template-protected|answered=yes}}
A naive search shows that there aren't that many articles that use {{tlx|mapframe|display{{=}}title}}, maybe no more than [https://en.wikipedia.org/w/index.php?title=Special:Search&limit=100&offset=0&ns0=1&search=hastemplate%3AMaplink+insource%3Adisplay+insource%3Atitle+insource%3A%2F%5BMm%5Daplink%5B%5E%7D%7B%5D%2Bdisplay+%2A%3D+%2A%5B%5E%7C%7D%5D%2Atitle%2F 50]. So I think it's safe to make [[Special:Diff/1294958307/1295035531|'''this change''']]. With it
* the module and template will do what they're supposed to do with {{para|display|title}}: the inline+title markers won't be shown next to each other in Vector-2022 (<span class="plainlinks">[https://en.wikipedia.org/wiki/Silver_Comet_Trail?useskin=vector-2022]</span>) nor the 'title' one will be placed on top of the infobox in Vector (<span class="plainlinks">[https://en.wikipedia.org/wiki/Silver_Comet_Trail?useskin=vector]</span>)
* the 'title' marker will be placed as the last of the [[:mw:Help:Page status indicators|indicators]] (the code added is mostly from that page)
* the resulting html code seems clean, and in line with what {{tlx|coord}} already does
{| class="wikitable plainlinks center"
! !!Vector 2022 !!Vector !!Monobook !!Timeless
|-
|[[TM:Maplink]]||[https://en.wikipedia.org/wiki/Template:Maplink?useskin=vector-2022] {{cross}} ||[https://en.wikipedia.org/wiki/Template:Maplink?useskin=vector] {{cross}} ||[https://en.wikipedia.org/wiki/Template:Maplink?useskin=monobook] {{tick}} ||[https://en.wikipedia.org/wiki/Template:Maplink?useskin=timeless] {{tick}}
|-
|[[TM:Maplink/sandbox]]||[https://en.wikipedia.org/wiki/Template:Maplink/sandbox?useskin=vector-2022] {{tick}} ||[https://en.wikipedia.org/wiki/Template:Maplink/sandbox?useskin=vector] {{tick}} ||[https://en.wikipedia.org/wiki/Template:Maplink/sandbox?useskin=monobook] {{tick}} ||[https://en.wikipedia.org/wiki/Template:Maplink/sandbox?useskin=timeless] {{tick}}
|}
Thanks, [[User:Ponor|Ponor]] ([[User talk:Ponor|talk]]) 13:50, 11 June 2025 (UTC)
:{{done}}<!-- Template:ETp --> Thanks, I had noticed this being broken a while ago and just did not want to deal with it at all. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 02:48, 28 June 2025 (UTC)
== Inconsistent map box ==
The same source produces a correct result on [[User:OceanLoop/sandbox/map]] but not [[Indian Creek (Elwha River tributary)]]: the frame is not positioned properly. Does anyone know why this happens? [[User:OceanLoop|OceanLoop]] ([[User talk:OceanLoop|talk]]) 00:55, 24 July 2025 (UTC)
:Fixed. Regs, [[User:The Equalizer|The Equalizer]] ([[User talk:The Equalizer|talk]]) 19:10, 24 July 2025 (UTC)
== How avoid text that appears when hover mouse cursor over the map? ==
{{maplink|frame=yes|type=line|id=Q2879655|text=Site of Cook's death in Kealakekua Bay |zoom=14|type3=point|coord3={{coord|19.48124|N|155.93325|W}}|title3=Point|description3=Site of death |frame-coordinates={{coord|19.48134|N|155.93025|W}}}}
In Talk page at [[Talk:Death_of_James_Cook#Comments_from_Noleander]] I put a map. I've replicated the map here. When the mouse cursor is hovered over the map (desktop computer; Windows OS, Firefox browser) a popup window appears containing the text "The intuitive WP:UE/WP:COMMONNAME page title for this would probably be Death of James Cook. Just saying." which is the text (unreleated to the map) at the top of that Talk page.
That text popup window does not appear here, in this Talk page, when hovering over the map.
Does anyone know why that text is appearing? and if there is a way to prevent that popup from appearing? [[User:Noleander|Noleander]] ([[User talk:Noleander|talk]]) 18:29, 10 August 2025 (UTC)
:Likely have the [[Wikipedia:Tools/Navigation popups]] gadget switched on in your preferences, as that line is the very first topic on the talk page. Regs, [[User:The Equalizer|The Equalizer]] ([[User talk:The Equalizer|talk]]) 19:21, 10 August 2025 (UTC)
::You are correct ... that fixed it. Thanks. [[User:Noleander|Noleander]] ([[User talk:Noleander|talk]]) 19:36, 10 August 2025 (UTC)
:::{{tl|maplink}} could probably set the 'nopopups' class to avoid that navigation popups triggers. —[[User:TheDJ|Th<span style="color: green">e</span>DJ]] ([[User talk:TheDJ|talk]] • [[Special:Contributions/TheDJ|contribs]]) 08:10, 11 August 2025 (UTC)
::::If there is a way to disable this popup issue, permanently, by a change to the maplink template, that would prevent this issue from arising in the future for other editors & readers ... so it seems like a good idea. [[User:Noleander|Noleander]] ([[User talk:Noleander|talk]]) 12:33, 11 August 2025 (UTC)
| |||