Module talk:Mapframe: Difference between revisions

Revision as of 12:05, 3 August 2019

Latest revision as of 20:29, 20 August 2025

(695 intermediate revisions by 96 users not shown)

Line 1:

{{Permanently protected}}

{{ping|Evad37}} For bnwiki, i want to add bengali parameter but at same time i don't want to remove english parameter. How can i add this <nowiki>{{{title|{{{শিরোনাম|}}}}}}</nowiki> in lua? ([https://bn.wikipedia.org/w/index.php?title=%E0%A6%AE%E0%A6%A1%E0%A6%BF%E0%A6%89%E0%A6%B2%3A%E0%A6%AE%E0%A6%BE%E0%A6%A8%E0%A6%9A%E0%A6%BF%E0%A6%A4%E0%A7%8D%E0%A6%B0%E0%A7%87%E0%A6%B0_%E0%A6%95%E0%A6%BE%E0%A6%A0%E0%A6%BE%E0%A6%AE%E0%A7%8B&type=revision&diff=3015010&oldid=3004471 this isn't working])--[[User:Aftabuzzaman|আফতাব]] ([[User talk:Aftabuzzaman|talk]]) 16:50, 26 May 2018 (UTC)

{{talk header|custom_header=This is the [[WP:TPG|talk page]] for discussing improvements to the [[Module:Mapframe|Mapframe]] module, and the related [[Template:Maplink|Maplink]] template.}}

:Its not yet possible without heavily modifying the module code. But storing alternate parameter names in a table is a good idea, I just need to make a helper function so the lua code knows what to do with them. - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 01:19, 27 May 2018 (UTC)

{{faq|see also=[[mw:Help:Extension:Kartographer]]|collapsed=no}}

:@[[User:Aftabuzzaman|আফতাব]]: {{Done}} here [https://en.wikipedia.org/w/index.php?title=Module%3AMapframe&type=revision&diff=843165859&oldid=842263085], you can make a similar edit on bnwiki and then it should work - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span>

{{central|text=[[Template talk:Maplink]] and related subpages redirect here}}

::{{ping|Evad37}} Thanks. --[[User:Aftabuzzaman|আফতাব]] ([[User talk:Aftabuzzaman|talk]]) 17:55, 27 May 2018 (UTC)

{{User:MiszaBot/config

:::Hi {{ping|Evad37}} just let you know that <code>coord</code> parameter does not support aliases. <code> coord = { "coord", "anything" },</code> (line 20) gives error. --[[User:Aftabuzzaman|আফতাব]] ([[User talk:Aftabuzzaman|talk]]) 18:50, 29 May 2018 (UTC)

| algo = old(150d)

::::@[[User:Aftabuzzaman|আফতাব]]: {{Fixed}} here with [https://en.wikipedia.org/w/index.php?title=Module%3AMapframe&type=revision&diff=843579359&oldid=843165859 this edit] - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 02:25, 30 May 2018 (UTC)

| archive = Module talk:Mapframe/Archive %(counter)d

| counter = 2

| maxarchivesize = 150K

| archiveheader = {{Aan}}

| minthreadstoarchive = 1

| minthreadsleft = 3

}}

== Thumbnail rendering issue in [[José Salvador Alvarenga]] ==

== Sandbox error?? ==

Point 1 and most of the line not visible, something to do with the 180th meridian line. Same issue on the [[:fr:José_Salvador_Alvarenga|fr]] and [[:zh:荷西·薩爾瓦多·阿爾瓦倫加|zh]] pages. Also is there a way to make the 180 line not visible? [[User:Sohryu Asuka Langley Not Shikinami|Sohryu Asuka Langley Not Shikinami]] ([[User talk:Sohryu Asuka Langley Not Shikinami|talk]]) 05:28, 29 April 2025 (UTC)

There seems to be an error at [[The Simpsons house]] in [[Module:Mapframe/sandbox]]. That should not be happening, not just the error but in particular the transclusion of the sandbox, as the sandbox or a template or module is normally an unprotected page that anyone can edit, and that editors are encouraged to try things out in even if they break things. Any code in there therefore is especially vulnerable and should not be used in articles, especially in templates that are already used in a large number of articles. Pinging {{U| Evad37}} who seems to be the one working on this.--<small>[[User:JohnBlackburne|JohnBlackburne]]</small>^{[[User_talk:JohnBlackburne|words]]}<sub style="margin-left:-2.0ex;">[[Special:Contributions/JohnBlackburne|deeds]]</sub> 02:32, 31 July 2018 (UTC)

:Thanks for alerting me. I've turned off the mapframe in that article with {{para|mapframe|no}}, and fixed the code that was loading the sandbox version of the module by mistake (in [[Module:Infobox mapframe]]). The error itself comes from this module not being prepared for the coordinates property on a Wikidata item being set to 'no value'. I'm looking into fixing this now. - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 02:54, 31 July 2018 (UTC)

:{{ping|JohnBlackburne}} {{Fixed}}, and requested protection for Infobox mapframe at [[WP:RFPP]] - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 03:31, 31 July 2018 (UTC)

::Thanks. I noticed your changes already to the Simpsons house article. An interesting test case as there can’t be many other articles for wholly fictional buildings.--<small>[[User:JohnBlackburne|JohnBlackburne]]</small>^{[[User_talk:JohnBlackburne|words]]}<sub style="margin-left:-2.0ex;">[[Special:Contributions/JohnBlackburne|deeds]]</sub> 03:35, 31 July 2018 (UTC)

:@[[User:Sohryu Asuka Langley Not Shikinami|Sohryu Asuka Langley Not Shikinami]] This is a bug. Only happens in "View mode". But I propose you to take some screenshot of OSM map, for this track, modify that and upload it using template OpenStreetMap in WikiCommons. Best regards. [[User:Hooman Mallahzadeh|Hooman Mallahzadeh]] ([[User talk:Hooman Mallahzadeh|talk]]) 06:19, 29 April 2025 (UTC)

== Error using decimal format ==

== How not dispay top right square for "Show in full screen" ==

{{Maplink||type=point|zoom=14|frame=yes|coord={{coord|37.7891838|-122.4033522}}|text=Using DD format: 37.7891838, -122.4033522

}}

Hi, is there anyway to avoid showing top right while square ([ ]) for "Show in full screen"? Sometime this square disrupts the map. Thanks, [[User:Hooman Mallahzadeh|Hooman Mallahzadeh]] ([[User talk:Hooman Mallahzadeh|talk]]) 13:41, 5 May 2025 (UTC)

{{Maplink||type=point|zoom=14|frame=yes|coord={{coord|37|47|21.06|N|122|24|12.07|W}}|text=Using DMS: 37° 47′ 21.06″ N, 122° 24′ 12.07″ W

}}

:Don't think you can. Just increase the height of the frame to accommodate the map. Regs, [[User:The Equalizer|The Equalizer]] ([[User talk:The Equalizer|talk]]) 20:10, 7 May 2025 (UTC)

{{ping|Evad37}} or someone else watching this module: Could you take at look at this? There currently seems to be an error when computing the latitude using the decimal format. In this example right here, when entering 37.7891838, -122.4033522 (the coordinates for the Wikimedia Foundation headquarters), the map currently displays instead '''37.8212''', -122.4033. The DMS equivalent seems fine. Thanks. [[User:Zzyzx11|Zzyzx11]] ([[User talk:Zzyzx11|talk]]) 05:51, 28 August 2018 (UTC)

::@[[User:The Equalizer|The Equalizer]] Implementation of "Hide" does not seem so hard. Just add an argument named "|hide square=yes" and then in the span of OSM map apply this style "display: none;".

:{{ping|Zzyzx11}} {{Fixed}} - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 06:15, 28 August 2018 (UTC)

::Hiding itthis square is displayingvery +dec_latuseful whenfor themany inputWikipedia ismaps, aespecially -dec_lat,for Japansmall insteadones. ofSo Mitagongit worths implementation. Thanks, [[User:DaveHooman RaveMallahzadeh|DaveHooman RaveMallahzadeh]] ([[User talk:DaveHooman RaveMallahzadeh|talk]]) 0804:2301, 128 NovemberMay 20182025 (UTC)

:::I thought the box is also a subtle hint that it's a clickthrough and scalable, not just a static picture. But propose the removal via Phab if desired. [[User:The Equalizer|The Equalizer]] ([[User talk:The Equalizer|talk]]) 18:34, 8 May 2025 (UTC)

::::@[[User:The Equalizer|The Equalizer]] No need for request of Phabricator. We should set "display:none;" CSS property for ".mw-kartographer-fullScreen" class. I tested it successfully in the inspector view my inspector of my browser.

::::I think it can be implemented by modifying this template only.

::::Line 1108 add

<syntaxhighlight>

displaysquare = util.getParameterValue(args, "displaySquare") or L10n.defaults.displaySquare,

</syntaxhighlight>

::::and line 962 add

<syntaxhighlight>

if options.displaySquare == "no" then

local whiteSquare = assert(document:getElementsByClassName("mw-kartographer-fullScreen"))

whiteSquare:css("display", "none")

</syntaxhighlight> [[User:Hooman Mallahzadeh|Hooman Mallahzadeh]] ([[User talk:Hooman Mallahzadeh|talk]]) 04:03, 9 May 2025 (UTC)

:I think this square is not required at all, therefore we can remove it as a default setting. Because there exists a tooltip for this purpose. [[User:Hooman Mallahzadeh|Hooman Mallahzadeh]] ([[User talk:Hooman Mallahzadeh|talk]]) 14:27, 9 May 2025 (UTC)

== Failure to set frame-align=none ==

As the alignment of thumbnail images can be set to <code>none</code> (see [[Help:Pictures]]), its reasonable to let this module get support as well. Unfortunately, if I set {{para|frame-align|none}}, I see this notice: <nowiki><mapframe>: Attribute "align" has an invalid value</nowiki>. -- [[User:Great Brightstar|Great Brightstar]] ([[User talk:Great Brightstar|talk]]) 10:29, 20 May 2025 (UTC)

:This map does not allow thumbnail-sized images yet. See [[Module_talk:Mapframe/Archive_2#Can_this_map_be_scaled_to_match_readers'_thumbnail_size_preferences?|this archived discussion from 2023]], and a [[Template_talk:Infobox_mapframe#How_do_I_set_the_mapframe_width_to_the_reader's_thumb_size_preference?|similar archived discussion from March 2025]]. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 00:48, 22 May 2025 (UTC)

== Edit request 28 May 2025 ==

{{Edit template-protected|answered=yes}}

'''Description of suggested change:'''

On line 94, change "paramter" to "parameter."

'''Diff:'''

{{TextDiff|1=valid values for type paramter|2=valid values for type parameter}} [[User:Shonebrooks|ShoneBrooks]] ([[User talk:Shonebrooks|talk]]) 15:00, 28 May 2025 (UTC)

:{{complete2}}. '''''[[User:Paine Ellsworth|<span style="font-size:92%;color:darkblue;font-family:Segoe Script">P.I.&nbsp;Ellsworth</span>]]'''''&thinsp;,&nbsp;[[Editor|<span style="color:black">ed.</span>]]&nbsp;[[User talk:Paine Ellsworth|^{put'er&nbsp;there}]]&nbsp;<small>20:29, 28 May 2025 (UTC)</small>

== Display in title ==

There's this comment in the code, saying "[display=title] makes maplink wikitext that will be located in the top-right of the title of the page (the same place where coords with display=title are positioned)." That does not seem to work: the styles associated with id=coordinates cannot do that. Is this option even useful? I'm wondering if it should be removed from the template's documentation, it seems misleading. [[User:Ponor|Ponor]] ([[User talk:Ponor|talk]]) 20:30, 10 June 2025 (UTC)

:[[Special:Diff/1294960231|'''This edit''']] will put the display=title marker in the indicator area, which seems to work for all desktop skins, as can be seen at [[Template:Maplink/sandbox]] (as long as the module sandbox change is on). Is that what we want? [[User:Ponor|Ponor]] ([[User talk:Ponor|talk]]) 21:21, 10 June 2025 (UTC)

----

{{edit template-protected|answered=yes}}

A naive search shows that there aren't that many articles that use {{tlx|mapframe|display{{=}}title}}, maybe no more than [https://en.wikipedia.org/w/index.php?title=Special:Search&limit=100&offset=0&ns0=1&search=hastemplate%3AMaplink+insource%3Adisplay+insource%3Atitle+insource%3A%2F%5BMm%5Daplink%5B%5E%7D%7B%5D%2Bdisplay+%2A%3D+%2A%5B%5E%7C%7D%5D%2Atitle%2F 50]. So I think it's safe to make [[Special:Diff/1294958307/1295035531|'''this change''']]. With it

* the module and template will do what they're supposed to do with {{para|display|title}}: the inline+title markers won't be shown next to each other in Vector-2022 (<span class="plainlinks">[https://en.wikipedia.org/wiki/Silver_Comet_Trail?useskin=vector-2022]</span>) nor the 'title' one will be placed on top of the infobox in Vector (<span class="plainlinks">[https://en.wikipedia.org/wiki/Silver_Comet_Trail?useskin=vector]</span>)

* the 'title' marker will be placed as the last of the [[:mw:Help:Page status indicators|indicators]] (the code added is mostly from that page)

* the resulting html code seems clean, and in line with what {{tlx|coord}} already does

{| class="wikitable plainlinks center"

! !!Vector 2022 !!Vector !!Monobook !!Timeless

|-

|[[TM:Maplink]]||[https://en.wikipedia.org/wiki/Template:Maplink?useskin=vector-2022] {{cross}} ||[https://en.wikipedia.org/wiki/Template:Maplink?useskin=vector] {{cross}} ||[https://en.wikipedia.org/wiki/Template:Maplink?useskin=monobook] {{tick}} ||[https://en.wikipedia.org/wiki/Template:Maplink?useskin=timeless] {{tick}}

|-

|[[TM:Maplink/sandbox]]||[https://en.wikipedia.org/wiki/Template:Maplink/sandbox?useskin=vector-2022] {{tick}} ||[https://en.wikipedia.org/wiki/Template:Maplink/sandbox?useskin=vector] {{tick}} ||[https://en.wikipedia.org/wiki/Template:Maplink/sandbox?useskin=monobook] {{tick}} ||[https://en.wikipedia.org/wiki/Template:Maplink/sandbox?useskin=timeless] {{tick}}

|}

Thanks, [[User:Ponor|Ponor]] ([[User talk:Ponor|talk]]) 13:50, 11 June 2025 (UTC)

:{{done}}<!-- Template:ETp --> Thanks, I had noticed this being broken a while ago and just did not want to deal with it at all. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 02:48, 28 June 2025 (UTC)

== Inconsistent map box ==

The same source produces a correct result on [[User:OceanLoop/sandbox/map]] but not [[Indian Creek (Elwha River tributary)]]: the frame is not positioned properly. Does anyone know why this happens? [[User:OceanLoop|OceanLoop]] ([[User talk:OceanLoop|talk]]) 00:55, 24 July 2025 (UTC)

:Fixed. Regs, [[User:The Equalizer|The Equalizer]] ([[User talk:The Equalizer|talk]]) 19:10, 24 July 2025 (UTC)

== How avoid text that appears when hover mouse cursor over the map? ==

== Bug - Can't click to expand map from articles ==

{{maplink|frame=yes|type=line|id=Q2879655|text=Site of Cook's death in Kealakekua Bay |zoom=14|type3=point|coord3={{coord|19.48124|N|155.93325|W}}|title3=Point|description3=Site of death |frame-coordinates={{coord|19.48134|N|155.93025|W}}}}

For articles where the Wikimedia map is placed, I can't click the dashed square button to expand the map, zoom around, or pan. I also noticed that I can't click the blue links to Wikimedia or to OpenStreetMap from these maps. I checked this using Firefox and Chrome. However, if I were to edit the article/section in which the mapframe map appears, I hit preview to preview my edit/null edit and I ''can'' expand the map and click the links. —'''[[User:Mr. Matté|Mr. Matté]]''' (^{[[User talk:Mr. Matté|Talk]]}/_{[[Special:Contributions/Mr. Matté|Contrib]]}) 16:29, 23 April 2019 (UTC)

:See [[phab:/T221439]]. --[[User:Lam-ang|Lam-ang]] ([[User talk:Lam-ang|talk]]) 17:29, 24 April 2019 (UTC)

::Thanks for the link; the bug has been fixed. —'''[[User:Mr. Matté|Mr. Matté]]''' (^{[[User talk:Mr. Matté|Talk]]}/_{[[Special:Contributions/Mr. Matté|Contrib]]}) 16:57, 25 April 2019 (UTC)

In Talk page at [[Talk:Death_of_James_Cook#Comments_from_Noleander]] I put a map. I've replicated the map here. When the mouse cursor is hovered over the map (desktop computer; Windows OS, Firefox browser) a popup window appears containing the text "The intuitive WP:UE/WP:COMMONNAME page title for this would probably be Death of James Cook. Just saying." which is the text (unreleated to the map) at the top of that Talk page.

== Too few points returned when using Wikidata ==

That text popup window does not appear here, in this Talk page, when hovering over the map.

I think this module should return more geopoints for a given object when using Wikidata as point source. Talking about usage via [[Template:Maplink]]. If you look at [[Interstate 70 in Pennsylvania]] and zoom the map a bit then the route is very simplified and does not trace the original very good. Can something be done with this? See the example here below. It is interesting that the WIWOSM tool does not seem to have such problems on the same object (see [https://tools.wmflabs.org/wiwosm/osm-on-ol/kml-on-ol.php?lang=wikidata&title=Q933614 example here]) and maybe renders even faster. So where is the problem? PS: ping [[User:Evad37]] --[[User:Kozuch|Kozuch]] ([[User talk:Kozuch|talk]]) 10:07, 21 June 2019 (UTC)

{{maplink|frame=yes|plain=yes|type=line|frame-align=center|frame-width=290|id=Q933614}}

:{{tracked|T155919}} This is a known bug with maplink/mapframe: [[phab:T155919]]. Nothing much we can do on-wiki, unfortunately. - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 01:23, 25 June 2019 (UTC)

Does anyone know why that text is appearing? and if there is a way to prevent that popup from appearing? [[User:Noleander|Noleander]] ([[User talk:Noleander|talk]]) 18:29, 10 August 2025 (UTC)

== Bug - does not ignore wd coordinates (P625) for type=line ==

:Likely have the [[Wikipedia:Tools/Navigation popups]] gadget switched on in your preferences, as that line is the very first topic on the talk page. Regs, [[User:The Equalizer|The Equalizer]] ([[User talk:The Equalizer|talk]]) 19:21, 10 August 2025 (UTC)

{{tracked|T227402}}

::You are correct ... that fixed it. Thanks. [[User:Noleander|Noleander]] ([[User talk:Noleander|talk]]) 19:36, 10 August 2025 (UTC)

{{ping|Evad37}} I think I identified a bug - the module does not ignore wikidata's "coordinate ___location" property (P625) for type=line which results in broken both the thumbnail map and the big map. I opened a ticket on Phabricator: T227402. My findings are simply when there is no P625 on wikidata the thumbnails/map/zooming etc. works ok. But when there is P625 these are broken, but I only tested type=line which is the only type that interests me. Can you fix it please? Thanks! --[[User:Kozuch|Kozuch]] ([[User talk:Kozuch|talk]]) 10:03, 27 July 2019 (UTC)

:::{{tl|maplink}} could probably set the 'nopopups' class to avoid that navigation popups triggers. —[[User:TheDJ|Th<span style="color: green">e</span>DJ]] ([[User talk:TheDJ|talk]] • [[Special:Contributions/TheDJ|contribs]]) 08:10, 11 August 2025 (UTC)

:{{ping|Kozuch}} I've fixed it in the sandbox: {{Maplink/sandbox|frame=yes|id=Q515443|type=line}}<pre>{{Maplink/sandbox|frame=yes|id=Q515443|type=line}}</pre> Can you check if the sandbox version works with some of the other maps you've been working on? - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 07:38, 3 August 2019 (UTC)

::::If there is a way to disable this popup issue, permanently, by a change to the maplink template, that would prevent this issue from arising in the future for other editors & readers ... so it seems like a good idea. [[User:Noleander|Noleander]] ([[User talk:Noleander|talk]]) 12:33, 11 August 2025 (UTC)

::{{ping|Evad37}} I set up a testing page at [https://en.wikipedia.org/w/index.php?title=User:Kozuch/Sandbox6&oldid=909139452 this link]. The problem on simple line objects like [[D52 motorway (Czech Republic)]] or interstates sections within states is fixed. For type=shape this seems also fixed (Pinelands National Reserve, Wharton State Forest). I recently discovered that type=line also works for type=shape (on some pages) as I do not want the infill on type=shape as the map inside is darker and can not be seen both in thumbnail and full screen map. Interestingly the fix works for Austria when type=line is used but it does not for Pinelands National Reserve and Wharton State Forest with type=line - do you know what is the issue? Also a long Interstate 5 does not work - I think this is because the master relation on OSM (https://www.openstreetmap.org/relation/2329642) has sub-relations and that simply does not work with Mapframe/Kartographer (but WIWOSM can show master relation! - I would appreciate that to work here too). I think you can push the Module from sandbox to production if you want. The "new" issues I raised (I will update the bug) are kind of additional in the context of the original bug. If you move it to production I can at least use what is working now and not need to use my module clone. --[[User:Kozuch|Kozuch]] ([[User talk:Kozuch|talk]]) 11:29, 3 August 2019 (UTC)

:: I just found [[Template:Maplink/testcases]] - looks like the new sandbox version fixed many more of the test examples. Nice to see such progress.--[[User:Kozuch|Kozuch]] ([[User talk:Kozuch|talk]]) 12:03, 3 August 2019 (UTC)