Module talk:Current events calendar: Difference between revisions

Revision as of 15:38, 3 February 2014

Latest revision as of 18:44, 1 September 2017

(5 intermediate revisions by 3 users not shown)

Line 2:

{{#invoke:Current events calendar|main}}

{{clear}}

== Nowiki ==

Might as well have a simple nowiki option for debugging:

{{#invoke:Current events calendar|main|nowiki = yes}}

[[User:Wnt|Wnt]] ([[User talk:Wnt|talk]]) 15:44, 3 February 2014 (UTC)

== Cells completed at end of the last week ==

{{ping|Mr. Stradivarius}} I replaced the break command in the script with a value assignment in order to have the cells completed for the final row of the calendar. The lack of such a complete set of cells becomes an issue when there is CSS that overrides the display=table with display=block. This is a step towards resolving the over-wide column on mobile. Please review at your convenience. [[User:RossO| — RossO]] ([[User talk:RossO|talk]]) 17:30, 28 August 2017 (UTC)

:Looks good to me. Nice work. :) — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr.&nbsp;Stradivarius</span>]]''''' ^{[[User talk:Mr. Stradivarius|♪&nbsp;talk&nbsp;♪]]} 13:06, 29 August 2017 (UTC)

== Cells completed at start of first week, loops combined ==

{{ping|Mr. Stradivarius}} I used the same technique as above to replace the colspan logic on the first week with real cells. The trick was to use a less-than-zero value for the cell counts. Once that was in place, I was able to create identical logic for the first week row as the remaining week rows. I then combined that logic into a single while loop, and removed ~20 lines of code, and eliminated a few local variables. Finally I used a ternary assignment to reduce some more overhead.

: Diff: [https://en.wikipedia.org/w/index.php?title=Special%3AComparePages&page1=Module%3ACurrent+events+calendar&page2=Module%3ACurrent+events+calendar%2Fsandbox]

Would you mind reviewing the sandbox and perhaps testing it against some problem months or scenarios? I don't think this applies any new logic but I don't have any test cases to proof against. Thank you (as always) for your time. Once I get your review, I will push it onto the live version. [[User:RossO|&#32;— RossO]] ([[User talk:RossO|talk]]) 19:55, 29 August 2017 (UTC)

{{ping|Mr. Stradivarius}} My spot testing shows that the calendar operates correctly for the current use on [[Portal:Current events]]. I have moved the Sandbox version to the production page. [[User:RossO|&#32;— RossO]] ([[User talk:RossO|talk]]) 18:44, 1 September 2017 (UTC)