User talk:Jack who built the house/Gadget-referenceTooltips.js: Difference between revisions
Content deleted Content added
→Two minor issues: Replying to Yair rand (reply-link) |
|||
| (6 intermediate revisions by 2 users not shown) | |||
Line 6:
:{{u|Yair rand}}, well noticed! Done. [[User:Jack who built the house|Jack who built the house]] ([[User talk:Jack who built the house|talk]]) 04:49, 31 December 2018 (UTC)
::{{Ping|Jack who built the house}} One more thing I just noticed: The extra style tags added via <code>mw.util.addCSS</code> when the tooltip is at the right edge aren't ever removed. Instead, they keep piling up in the head every time the user hovers over a reference, even if it's the same reference twice. I recommend removing the tags rather than just disabling them once they're no longer needed, or even better, set the styles to the element directly, rather than adding a style tag which I assume would be harder on performance. --[[User:Yair rand|Yair rand]] ([[User talk:Yair rand|talk]]) 06:22, 31 December 2018 (UTC)
:::{{u|Yair rand}}, thank you again, done. As I remember, the reason why I used {{code|mw.util.addCSS}} here at all was the fact that I was messing with pseudoelements, and you can't reach them from ''style'' attribute. At some moment, that changed, but the code was left untouched. [[User:Jack who built the house|Jack who built the house]] ([[User talk:Jack who built the house|talk]]) 07:13, 31 December 2018 (UTC)
::Also, the bit around line 425 should probably check whether COMMENTED_TEXT_CLASS is empty. <code>.</code> alone isn't a valid selector, so it breaks the script. --[[User:Yair rand|Yair rand]] ([[User talk:Yair rand|talk]]) 07:08, 31 December 2018 (UTC)
:::{{u|Yair rand}}, thanks, fixed. [[User:Jack who built the house|Jack who built the house]] ([[User talk:Jack who built the house|talk]]) 07:25, 31 December 2018 (UTC)
:{{u|Yair rand}}, hm, do settings work with the current version at all? I try to change them, only to see the same behaviour after page refresh. [[User:Jack who built the house|Jack who built the house]] ([[User talk:Jack who built the house|talk]]) 06:32, 31 December 2018 (UTC)
::{{re|Yair rand}} here, I'm talking about the current version of the ''gadget''. [[User:Jack who built the house|Jack who built the house]] ([[User talk:Jack who built the house|talk]]) 07:27, 31 December 2018 (UTC)
:::{{Ping|Jack who built the house}} (Tests.) It works for me... --[[User:Yair rand|Yair rand]] ([[User talk:Yair rand|talk]]) 07:29, 31 December 2018 (UTC)
::::Probably some cookie interfered. [[User:Jack who built the house|Jack who built the house]] ([[User talk:Jack who built the house|talk]]) 08:45, 31 December 2018 (UTC)
| |||