MediaWiki talk:DYK-nomination-wizard.js: Difference between revisions
Content deleted Content added
m SD0001 moved page User talk:SD0001/DYK-helper/withJsMode.js to MediaWiki talk:DYK-nomination-wizard.js: move the talk page as well |
|||
(21 intermediate revisions by 5 users not shown) | |||
Line 4:
Also, please apply some protection on [[Wikipedia:Did you know/Create new nomination]] – the page from which the script is invoked. ECP should be fine. – [[User:SD0001|<span style="font-weight: bold; color: #C30">SD0001</span>]] ([[User talk:SD0001|talk]]) 11:37, 3 November 2021 (UTC)
:{{done}}, although I upped the protection level to TE after reflection, since it looks like ECP is still only authorized in specific fields. [[User:Writ Keeper|Writ Keeper]] [[User Talk: Writ Keeper|⚇]][[Special:Contributions/Writ_Keeper|♔]] 16:46, 20 November 2021 (UTC)
== hlist moving from Common.css ==
At some point in the nearer rather than further future, <code>.hlist</code> styles will be removed from Common.css and Mobile.css in favor of TemplateStyles. This is a headsup to adjust what this script is doing. The replacement is at [[Template:Hlist/styles.css]] in case you wish to load the sheet in JavaScript instead. cc @[[User:SD0001|SD0001]] [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 03:39, 24 December 2022 (UTC)
:
{{edit interface-protected|answered=yes}}
please sync with [[User:SD0001/DYK-helper/withJsMode2.js]] ([https://en.wikipedia.org/wiki/Special:ComparePages?page1=MediaWiki%3ADYK-nomination-wizard.js&rev1=&page2=User%3ASD0001%2FDYK-helper%2FwithJsMode2.js&rev2=&action=&unhide=&diffmode=source diff]). This replaces use of <code>.hlist</code> with a hand-made bulleted list. cc @[[User:Izno|Izno]]. – [[User:SD0001|<span style="font-weight: bold; color: #C30">SD0001</span>]] ([[User talk:SD0001|talk]]) 05:20, 24 December 2022 (UTC)
:{{done}}<!-- Template:EIp --> [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 05:23, 24 December 2022 (UTC)
== Interface-protected edit request on 21 March 2024 ==
{{edit interface-protected|MediaWiki:DYK-nomination-wizard.js|answered=yes}}
Please sync the changes from [[User:SD0001/DYK-helper/withJsMode2.js]] ([https://en.wikipedia.org/wiki/Special:ComparePages?page1=MediaWiki%3ADYK-nomination-wizard.js&rev1=1129222187&page2=User%3ASD0001%2FDYK-helper%2FwithJsMode2.js&rev2=1214819942&action=&diffonly=&unhide=&diffmode=source diff]). The following change(s) have been done:
* Now shows the number of QPQs required in the interface, based on count of user's past nominations and whether the backlog mode is active.
<!-- via Template:Sandboxed_edit_request -->
– [[User:SD0001|<span style="font-weight: bold; color: #C30">SD0001</span>]] ([[User talk:SD0001|talk]]) 11:21, 21 March 2024 (UTC)
:{{done}}, noting this creates a dependency on [[User:SDZeroBot/DYK nomination counts.json]]. — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 13:24, 21 March 2024 (UTC)
== Interface-protected edit request on 24 March 2024 ==
{{edit interface-protected|MediaWiki:DYK-nomination-wizard.js|answered=yes}}
Please sync the changes from [[User:SD0001/DYK-helper/withJsMode2.js]] ([https://en.wikipedia.org/wiki/Special:ComparePages?page1=MediaWiki%3ADYK-nomination-wizard.js&rev1=1214831781&page2=User%3ASD0001%2FDYK-helper%2FwithJsMode2.js&rev2=1215361663&action=&diffonly=&unhide=&diffmode=source diff]). The following change(s) have been done:
* Improve performance by not loading the big page [[User:SDZeroBot/DYK nomination counts.json]] on the client. Instead do it on the server by invoking a lua function in [[Module:NewDYKnomination]]. The module only being semi-protected is not a problem as only two numeric outputs from it are used. We also validate that they are numeric.
<!-- via Template:Sandboxed_edit_request -->
– [[User:SD0001|<span style="font-weight: bold; color: #C30">SD0001</span>]] ([[User talk:SD0001|talk]]) 17:55, 24 March 2024 (UTC)
: {{Done}} [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 00:48, 31 March 2024 (UTC)
== Interface-protected edit request on 4 April 2024 ==
{{edit interface-protected|MediaWiki:DYK-nomination-wizard.js|answered=yes}}
Please change:
<syntaxhighlight lang="wikitext">' <small>Source: ' + params.source + '</small>'</syntaxhighlight>
To:
<syntaxhighlight lang="wikitext">'\n{{smalldiv|1= \n* Source: ' + params.source + '}}'</syntaxhighlight>
The intent is to add a new line and then wrap the "Source" portion in div tags. When someone puts a multi-line block of text into the "Source" field using the existing code, it creates Linter errors of a type that have been cleared from Template space (loosely related: what ever happened to moving DYK to Wikipedia space, where it belongs?). [https://en.wikipedia.org/w/index.php?title=Template%3ADid_you_know_nominations%2FHistory_of_Palestinian_journalism&diff=1217289847&oldid=1217287342 Here's a sample change that Lint-error-fixing gnomes need to make a few times per day].
I think that this change will work from a technical standpoint, but it may not be exactly the formatting that people want. It would be easier to just remove the small formatting entirely, but I don't know if people will go for that either. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 23:20, 4 April 2024 (UTC)
:@[[User:Jonesey95|Jonesey95]] In looking at the example [https://en.wikipedia.org/w/index.php?title=Template:Did_you_know_nominations/History_of_Palestinian_journalism&oldid=1217287342 before] and [https://en.wikipedia.org/w/index.php?title=Template:Did_you_know_nominations/History_of_Palestinian_journalism&oldid=1217289847 after]: frankly, the bulleted list layout is really a garbage fire in both cases -- but in the former the presentation suggests that the "Kominko, Maja" source was "reviewed", in the change it suggests that the topic "History of Palestinian journalism" has been "reviewed" - at best (the blist is a mess so it is still ambiguous). I'm not sure what this workflow is supposed to be showing to tell if this made things better or worse? Not blaming you for this, but would much prefer the entire layout got fixed if possible? — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 13:49, 9 April 2024 (UTC)
:: Neither was reviewed. The thing that "reviewed" pertains to in that case is [[Template:Did you know nominations/Dahiru Musdapher]]. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 14:34, 9 April 2024 (UTC)
:::So you can see how the ___location of the bulleted list item makes it very confusing what parent object that statement is meant to be attached to. — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 15:50, 9 April 2024 (UTC)
::::If the GIGO formatting would not have been harmed by the proposed change, I would like to see it implemented. [https://en.wikipedia.org/w/index.php?title=Template%3ADid_you_know_nominations%2FThe_Star-Spangled_Man&diff=1218134565&oldid=1218133589 Here's another example] of the sort of error that needs to be fixed a couple of times per day. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 22:51, 9 April 2024 (UTC)
{{block indent|em=1.6|1=<small>Notified: [[Wikipedia talk:Did you know]]. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 03:47, 26 April 2024 (UTC)</small>}}<!-- Template:Notified -->
:{{done}} {{ping|Jonesey95}} try it out, ping me if problem requiring revert. Think this entire output could use a rework if someone gets around to it still. — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 09:44, 26 April 2024 (UTC)
== Interface-protected edit request on 4 September 2024 ==
{{edit interface-protected|answered=yes}}
Please sync the changes from [[User:SD0001/DYK-helper/withJsMode2.js]]: ([https://en.wikipedia.org/wiki/Special:ComparePages?page1=MediaWiki%3ADYK-nomination-wizard.js&rev1=1220854392&page2=User%3ASD0001%2FDYK-helper%2FwithJsMode2.js&rev2=1243986839&action=&diffonly=&unhide=&diffmode=source diff]).
Wording changes per [[Wikipedia_talk:Did_you_know#Usage_police]]. – [[User:SD0001|<span style="font-weight: bold; color: #C30">SD0001</span>]] ([[User talk:SD0001|talk]]) 13:14, 4 September 2024 (UTC)
:{{done}}<!-- Template:EIp --> [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 16:28, 4 September 2024 (UTC)
== Interface-protected edit request on 15 September 2024 ==
{{edit interface-protected|answered=yes}}
Please sync the changes from [[User:SD0001/DYK-nomination-wizard.js]] ([https://en.wikipedia.org/wiki/Special:ComparePages?page1=MediaWiki%3ADYK-nomination-wizard.js&rev1=1244020421&page2=User%3ASD0001%2FDYK-nomination-wizard.js&rev2=1245868585&action=&diffonly=&unhide=&diffmode=source diff]). The following changes have been done:
*remove default value for date field, per [[Wikipedia talk:Did you know/Archive 201#c-TompaDompa-20240909181200-Narutolovehinata5-20240904012200]]
*add warning if no QPQ is provided, per [[Wikipedia talk:Did you know#c-Narutolovehinata5-20240915142700-SD0001-20240915141200]]
*formatting cleanup
– [[User:SD0001|<span style="font-weight: bold; color: #C30">SD0001</span>]] ([[User talk:SD0001|talk]]) 16:46, 15 September 2024 (UTC)
:{{done}}<!-- Template:EIp --> [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 05:44, 16 September 2024 (UTC)
|