Content deleted Content added
m Archiving 2 discussion(s) from Template talk:WPBannerMeta) (bot |
IronGargoyle (talk | contribs) m Reverted edits by 78.172.216.105 (talk): page blanking (HG) (3.4.10) |
||
| (15 intermediate revisions by 7 users not shown) | |||
Line 1:
{{Old RfD
{{Aan}}
Line 12:
:{{ping|Evolution and evolvability}} just wondering if my answer made any sense? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 08:10, 5 May 2020 (UTC)
::{{re|MSGJ}}. Woops, I meant to use {{para|TF_n_IMP}} rather than {{para|TF_n_QUALITY}} as the example. Because currently, if {{para|TF_n}} isn't filled in, the template will ignore {{para|TF_n_IMP}}. The template I'm working on is {{tlx|WikiProject_Molecular_Biology}}.
::Example: <code><nowiki>{{WikiProject Molecular Biology
{{WikiProject Molecular Biology|category=no
::but should really return:
{{WikiProject Molecular Biology|category=no
::So the query is more about whether we can automatically assume {{para|TF_n}} is yes if any of the {{para|TF_n_XYZ}} parameters are filled. [[User:Evolution and evolvability|T.Shafee(Evo<small>&</small>Evo)]]<sup>[[User talk:Evolution and evolvability|talk]]</sup> 12:26, 5 May 2020 (UTC)
:::Ah, I understand your point now. Typically the only taskforce parameter that is set at the article level is the importance. So you are saying that if {{para|biophysics-imp}} is set to any value, then we should assume that {{para|biophysics|yes}}? That would be fairly simple to implement. Are there any possible side effects of doing this? What if {{para|biophysics-imp|cheesecake}}, i.e. an unrecognised value - should that trigger the taskforce as well? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 13:38, 5 May 2020 (UTC)
Line 46:
The following is extremely jarring when encountered
{{WikiProject Skepticism|class=NA|category=no}}
{{WikiProject Homeopathy
{{WikiProject Alternative medicine
{{WikiProject Alternative Views
▲{{WikiProject Citizendium Porting}}
}}
The inactive project should be center-aligned just like the active ones. And the '''([[Wikipedia:WikiProject_Council/Guide#Dealing_with_inactive_WikiProjects|Inactive]])''' links should be at the same place as the '''(Raged X-class)'''.  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 16:06, 1 October 2020 (UTC)
Line 68 ⟶ 66:
::{{Re|MSGJ}}, the code you moved from the core to the main template needs to stay in core as the class and importance param values are normalised before being passed to the core template. See example below. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 20:04, 1 October 2020 (UTC)
{{WikiProject British Museum|class=xxx|importance=zzz|category=no}}
{{WikiProject British Museum/sandbox|class=xxx|importance=zzz|category=no}}
Line 87 ⟶ 85:
===Couple more===
There is one that still stands out, [[Template:MILHIST]]
{{WikiProject Military history|class=NA|category=no}}
{{WikiProject Military history/sandbox|class=NA|category=no}}
Line 96 ⟶ 90:
{{WikiProject Physics|class=NA|category=no}}
{{WikiProject U.S. Roads|class=NA|category=no}}
{{
{{WikiProject Citizendium Porting|category=no}}
▲{{WikiProject Citizendium Porting/sandbox|category=no}}
}}
 <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 14:35, 4 October 2020 (UTC)
Line 140 ⟶ 133:
When the image is narrower than the class rating, and notes are used, the columns do not align nicely.
{{WikiProject Portals|category=no|importance=low
On my browser the indentation for the final row is much less than for the other rows in the table. Is there a good way to fix this? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 14:25, 26 October 2020 (UTC)
: It's because the /Note template, or one of its immediate parent templates, creates its own sub-table in a cell which is 3 cells wide. That means it does not inherit the same widths as the cells in the rest of the table. --[[User:Izno|Izno]] ([[User talk:Izno|talk]]) 15:35, 26 October 2020 (UTC)
:The pertinent code is
<pre><tr><td colspan="3" style="padding:0;">{{#ifexpr:{{#switch:{
{{#ifeq:{{{attention}}}|yes|1|0}}+
{{#ifeq:{{{infobox}}}|yes|1|0}}+
Line 167 ⟶ 160:
::::I may have a play in the sandbox then — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 08:47, 27 October 2020 (UTC)
Testing sandbox code below. Uncollapsed version does not start a new table, so columns line up. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 22:23, 27 October 2020 (UTC)
{{WikiProject Portals/sandbox|category=no|importance=low
{{ping|Izno}} would you double-check my code please ([https://en.wikipedia.org/w/index.php?title=Template:WPBannerMeta/core/sandbox&diff=prev&oldid=985778587 diff])? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 13:31, 28 October 2020 (UTC)
:{{ping|MSGJ}} Yes, looks fine. (Rough, but such is the nature of wikitext.) --[[User:Izno|Izno]] ([[User talk:Izno|talk]]) 14:09, 28 October 2020 (UTC)
Line 333 ⟶ 325:
WikiProject Japan (well actually just Nihonjoe at the moment) are exploring putting some additional information in the collapsed banner, e.g. when a photo has been requested:
{{
I think it would be neater to have that icon after the quality/importance ratings. Would it cause any problems to just move the hook to be after the bracketed portion, because I don't think there is any banner using both of these simultaneously yet? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 14:45, 18 November 2020 (UTC)
:See also [[User:Headbomb/Sandbox/Banner#If_there_are_issues]] (3rd mockup, If there are issues), from a 2017 mockup. As well as 'Projects expanded' from mockup 2.  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 02:48, 19 November 2020 (UTC)
Line 438 ⟶ 430:
{{edit fully-protected|Template:WPBannerMeta/core|answered=yes}}
Remove the line <code><nowiki><td class="mbox-empty-cell"></td></nowiki></code> from [[Template:WPBannerMeta/core]] to resolve an issue with the border when the template is inside {{tl|WikiProject banner shell}}. It was orginally added by [[User:Happy-melon]] in revision [[Special:Permalink/301387726|301387726]] ([[Special:Diff/301387726/prev|diff]]) so the header and the body would have the same number of table cells since the header also had a <code>mbox-empty-cell</code> table cell that was used to contain the metadata. But now that the metadata was moved and the <code>mbox-empty-cell</code> in the header was removed by [[User:WOSlinker]] in revision [[Special:Permalink/982121201|982121201]] ([[Special:Diff/982121201/prev|diff]]), there is one extra table cell in the text row, causing the border issue. To fix this, the <code>mbox-empty-cell</code> should in the text row should also be removed. Here's the effect of the change (notice the border in the top right):
<!--<div class="wpbs-inner">
{{Center|Current}}
{{WPBannerMeta/core|PROJECT_NAME=CURRENT}}
{{Center|Proposed}}
{{WPBannerMeta/core/sandbox|PROJECT_NAME=SANDBOX}}
</div>--><span class="nowrap">– [[User:BrandonXLF|<span style="color:blue;">Brandon</span><span style="color:green;">XLF</span>]] ([[User talk:BrandonXLF|talk]])</span> 05:15, 31 March 2021 (UTC)
:{{done}} -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 07:46, 31 March 2021 (UTC)
Line 469 ⟶ 461:
There is a cosmetic problem when a WP banner appears within a narrow browser window. I reproduce an example banner from this template's documentation to help discuss this.
{{#invoke:WikiProject banner|main
|PROJECT = Tulips
|BANNER_NAME = Template:WikiProject Tulips
Line 648 ⟶ 640:
<nowiki>|class_values = {{{class_values|}}}</nowiki>
just above the line
<nowiki>|auto={{lc:{{{
This will allow the auto documentation to support an inline quality class. (I already made the corresponding change in {{tlx|WPBannerMeta/templatepage}}).
Line 681 ⟶ 673:
<nowiki>|tf 1 = {{{aviation|}}}</nowiki>
It seems that a talk page with <nowiki>{{WikiProject Military history|aviation=y}} </nowiki>, it'll get recognized, but <nowiki>
Is there any way around this, other than :
Line 690 ⟶ 682:
The context for this is that I'm trying to create a WPBannerMeta version of the MILHIST talk page banner. Some of its task forces have 15+ parameters, so it would be nice to avoid needing to add multiple variations of capitalization for each TF parameter.
Would there be any ''downsides'' to changing {{tl|WPBannerMeta/hooks/taskforces}} to make these case-insensitive by default? That would be rather nice, and would help catch a lot of errors we couldn't possibly add to templates, like <nowiki>
[[User:DFlhb|DFlhb]] ([[User talk:DFlhb|talk]]) 12:40, 11 February 2023 (UTC)
Line 726 ⟶ 718:
|category={{{category|¬}}}
|BANNER_NAME = Template:WikiProject United States
|cat 1={{{
|CAT_1 = Automatically assessed American cinema articles
|cat 2={{{attention|}}}
Line 947 ⟶ 939:
::::Great, I'll let you know if I find any more bugs. [[User:DFlhb|DFlhb]] ([[User talk:DFlhb|talk]]) 16:47, 22 June 2023 (UTC)
As a demonstration of the new capabilities I have simplified [[Template:WikiProject South America]] so the 17 task forces do not need any hooks — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 21:13, 22 June 2023 (UTC)
== Mobile Issue ==
Since the recent update, no WikiProject banners are viewable on mobile, being replaced with horizontal yellow lines. This affects all WikiProjects. Please fix this quickly! [[User:QuicoleJR|QuicoleJR]] ([[User talk:QuicoleJR|talk]]) 15:22, 23 June 2023 (UTC)
:{{ping|PresN}} You seem like you know a lot about the banners. Any ideas here? [[User:QuicoleJR|QuicoleJR]] ([[User talk:QuicoleJR|talk]]) 20:44, 24 June 2023 (UTC)
::I just worked out some configuration, no idea about the code itself. Did it work before, though? There's a big template on the doc page for this template saying "This template does not display in the mobile view of Wikipedia; it is desktop only. Read the documentation for an explanation." The documentation doesn't seem to have an explanation, though? --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 00:25, 25 June 2023 (UTC)
:::That said, that warning was [https://en.wikipedia.org/w/index.php?title=Template:WPBannerMeta/doc&diff=prev&oldid=978417297 put on] by a driveby editor with no further explanation in 2020. Also, I just pulled up [[Talk:Doom (1993 video game)]], and while the wikiproject boxes don't work (just the borders with no content or height), the Vital article template does show up, as does the overall Bannershell box (but with a ''tiny'' icon, so that's a bug too). I guess, {{u|QuicoleJR}} can you verify that it was working for you on mobile before the update? {{u|MSGJ}} was your understanding that mobile is not supported for this template? --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 00:30, 25 June 2023 (UTC)
::::Ok, yeah, [[Template_talk:WPBannerMeta/Archive_10#Mobile]] says that it was suppressed on mobile as far back as 2015. So the issue is not that its broken on mobile suddenly, it's that it shows up at all. --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 00:32, 25 June 2023 (UTC)
:::::It was fully visible before the recent update. [[User:QuicoleJR|QuicoleJR]] ([[User talk:QuicoleJR|talk]]) 00:33, 25 June 2023 (UTC)
::::::Hmm, digging through the code, and it seems like the new Lua code adds class=tmbox to the wikiproject banners (so they get suppressed), but not the overall box, while the old WPBannerMeta/core subtemplate used to put it on the box overall. Don't know why it would show up for you before, though? Either way, I think that it's possibly missing on the overall box, but we should wait for MSGJ to say what they intended to happen on mobile. --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 00:38, 25 June 2023 (UTC)
:::::::There was no intention to change any of the display. I will have a look through the code now. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 18:37, 25 June 2023 (UTC)
:::::::Please clarify what you mean by "the box overall". Which line of code are you looking at? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 18:50, 25 June 2023 (UTC)
::::::::Just wondering if it's anything to do with [[Module:WikiProject_banner#L-579|line 579]]? -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 22:37, 25 June 2023 (UTC)
:::::::::Not sure where the css('height', '0') came from - looks like it can safely be removed. I can't see any difference in mobile view. @[[User:QuicoleJR|QuicoleJR]]: any chance of a screenshot to show what you are seeing? Which browser are you using, etc.? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:23, 26 June 2023 (UTC)
::::::::::{{multiple image |align = right |image1 = Thin line WPBM banners - inside WPBS.jpg |caption1 = At [[Talk:Doom (1993 video game)]], WP banners inside shell appear as thin lines, just below vital banner. |image2 = Thin line WPBM banners - outside WPBS.jpg |caption2 = At this talk page, the only WP banner appear as thin line, between {{tl|central}} and number of formatting errors. |footer_align=center |footer = Demonstration of thin line problems. }}
::::::::::@[[User:MSGJ|MSGJ]]: Here are some screenshots. <span class="nowrap">—'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 08:00, 26 June 2023 (UTC)
:::::::::::Thanks for that, very helpful. Not seeing anything like that on Chrome for mobile. What browser is that? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 08:04, 26 June 2023 (UTC)
::::::::::::I'm on Chrome version 113.0.5672.132 on Android 13, Samsung Galaxy M13 5G. <span class="nowrap">—'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 08:07, 26 June 2023 (UTC)
::::::::::::BTW, I use the Google app. Not Chrome, just plain Google. [[User:QuicoleJR|QuicoleJR]] ([[User talk:QuicoleJR|talk]]) 14:14, 26 June 2023 (UTC)
::::::::{{re|MSGJ}} I'm wrong, I was referring to how [[Template:WPBannerMeta/core]] puts the tmbox css class on the table element itself and I didn't see that in the Lua code, but it's there in the actual html so I must have just missed it. --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 00:19, 26 June 2023 (UTC)
{{ping|MSGJ|PresN}} It appears to be working now. Thanks for the help! [[User:QuicoleJR|QuicoleJR]] ([[User talk:QuicoleJR|talk]]) 14:18, 26 June 2023 (UTC)
:The only thing I changed was to remove the css('height', '0') so you can thank @[[User:WOSlinker|WOSlinker]] for that — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 14:32, 26 June 2023 (UTC)
== Importance as ??? since module switch ==
{{Ping|MSGJ}} I don't know how wide spread for other project banners, but {{tl|WikiProject Video games}} is showing ???s for importance on all pages that have purged. See [[Talk:Diablo IV]] for an immediate example. {{Ping|Kung Fu Man}} noticed and brought to my attention on Discord. -- [[User:Ferret|ferret]] ([[User_talk:Ferret|talk]]) 00:21, 23 June 2023 (UTC)
:I can see on e.g. [[Talk:Doom (1993 video game)]] that it's not affecting all projects; presumably it is because video games has |QUALITY_CRITERIA=custom in its template while others do not. --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 01:19, 23 June 2023 (UTC)
::Nope, can't be that- [[Talk:Final Fantasy XVI]] has importance not working for Video games but working for Square Enix, but both templates use |QUALITY_CRITERIA=custom. --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 01:31, 23 June 2023 (UTC)
:::It's not that, it's the importance mask subpage ({{tl|WikiProject Video games/importance}}- removing it (as I just did in the template's subpage) fixes it. For some reason, ours was subst'd (by MSGJ, actually) years back instead of using {{tl|Importance mask}} like every other project that has a custom mask, so I'll play with it to figure out how to replicate it (e.g. figure out what we even have custom to start with, there's no doc page). --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 01:50, 23 June 2023 (UTC)
::::Ok, fixed. As far as I can tell, there was something odd in how it got subst'd that meant it returned some parameters as null/nil, and Lua choked on it where the standard template code didn't? Maybe? Anyway normal cases are now looking correct, and we weren't doing anything crazy with importance anyway (turning off Bottom-class and trying to set the default to Unknown, which I think is what it does anyway by default), but I'll keep an eye on it. --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 02:16, 23 June 2023 (UTC)
:Can't really remember what that was for, but there is related discussion at [[Template talk:WikiProject Video games/Archive 2#NA priority for drafts]]. In any case that custom mask does not seem to do anything special so you could probably remove {{para|IMPORTANCE_SCALE|subpage}} from the template and just use the standard mask. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 06:54, 23 June 2023 (UTC)
=== Astronomy ===
Project ratings, such as at [[Talk:Algol]] for a Top rated article are now displaying as ??? in the banner. Also see Wikipedia:WikiProject Astronomy/Article ratings which is suddenly weird. Is this an effect of the recent update? [[User:StarryGrandma|StarryGrandma]] ([[User talk:StarryGrandma|talk]]) 21:14, 25 June 2023 (UTC)
:Same issue as [[#Importance as ??? since module switch]] above, I presume. <span class="nowrap">—'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 21:19, 25 June 2023 (UTC)
::Looks like it. Compare the bot generated Astronomy table [[Special:Permalink/1161319714|from June 22]] with that [[Special:Permalink/1161478365|from June 23.]] [[User:StarryGrandma|StarryGrandma]] ([[User talk:StarryGrandma|talk]]) 21:29, 25 June 2023 (UTC)
:Not sure why that template ever worked in the past, but I have now fixed [[Template:WikiProject Astronomy/importance]] and it seems to be working again — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 21:32, 25 June 2023 (UTC)
::Thanks!! [[User:StarryGrandma|StarryGrandma]] ([[User talk:StarryGrandma|talk]]) 21:42, 25 June 2023 (UTC)
=== Chess ===
WikiProject Chess seems to suffer from the same issue, see for example: [[Talk:Blindfold_chess]] --[[User:Mika1h|Mika1h]] ([[User talk:Mika1h|talk]]) 12:46, 1 July 2023 (UTC)
:Fixed. As above, I don't know why or how it would have worked before. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 17:05, 1 July 2023 (UTC)
::Working from the results of an insource search, I also fixed six other .../importance pages that had this same problem. That may be all of them. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 17:12, 1 July 2023 (UTC)
| |||