Module talk:Coordinates: Difference between revisions

Revision as of 06:25, 29 July 2023

Latest revision as of 09:10, 14 August 2024

(10 intermediate revisions by 6 users not shown)

Line 303:

|maxarchivesize = 75K

|counter = 2

|minthreadsleft = 47

|minthreadstoarchive = 12

|algo = old(90d365d)

|archive = Module talk:Coordinates/Archive %(counter)d

}}

Line 381:

:::@[[User:Redrose64|Redrose64]] I added a new fix to the sandbox. I also added testcases to cover the issue, although they need to be checked manually. <span class="nowrap">– [[User:BrandonXLF|<span style="color:blue;">Brandon</span><span style="color:green;">XLF</span>]] ([[User talk:BrandonXLF|talk]])</span> 23:59, 28 May 2023 (UTC)

::::{{ty}} The live module is now working as expected. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] &#x1f339; ([[User talk:Redrose64|talk]]) 19:40, 5 June 2023 (UTC)

== Updating this module to use Kartographer ==

Please see [[Wikipedia:Village pump (proposals)#RfC: Updating Template:Coord to use Kartographer]]. [[User:Galobtter|Galobtter]] ([[User talk:Galobtter|talk]]) 06:24, 10 May 2023 (UTC)

== Lua errors ==

Recent edits to this module seem to have caused Lua errors to appear at a bunch of articles, such as [[Ferry Point International Bridge]] and [[Calvert Marine Museum]] [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 14:55, 21 May 2023 (UTC)

:I think it's due to switching to use the indicator tag. If coord is just using "display=title" then Module:Mapframe isn't seeing the the geohack url to parse. You can get the same error if you just used "coordinates=x" in the infobox. The article can be fixed by changing the coord params to "display=inline,title" but the Module:Mapframe should be improved to fail more gracefully when it can't find a coord value. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 15:22, 21 May 2023 (UTC)

:: Error handling aside, shouldn't that use case be supported? Presumably the same fix that worked for coordinsert above (which I don't fully understand) should work for this case too. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 18:23, 21 May 2023 (UTC)

::: There does seem to be a row in the infobox though with just Coordinates as a title and a blank area to the right of that if just the display=title option is used. So another option is to move the coords outside of the infobox if just the title option is desired. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 18:43, 21 May 2023 (UTC)

:: {{ping|BrandonXLF}} in case you are interested in this. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 18:24, 21 May 2023 (UTC)

:::@[[User:Pppery|Pppery]] The error is caused by the call to <code>frame:preprocess</code> at [[Module:Mapframe#L-599]], but I'm not sure why it's there in the first place. @[[User:Evad37|Evad37]] Do you know if it would be safe to remove the call to <code>frame:preprocess</code>? <span class="nowrap">– [[User:BrandonXLF|<span style="color:blue;">Brandon</span><span style="color:green;">XLF</span>]] ([[User talk:BrandonXLF|talk]])</span> 10:00, 22 May 2023 (UTC)

This problem appears to occur in general when the rare {{para|display|title}} is used rather than the much more common {{para|display|inline,title}}. I set [[German Museum of Technology]], which uses {{tl|Infobox museum}}, to use {{para|display|title}}, and it displays the error in preview. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 14:21, 23 May 2023 (UTC)

===LDS temples===

''I wrote the following before noticing this section, I guess this is the same issue?''<br>A recent edit has led to "Lua error in Module:Mapframe at line 384: attempt to perform arithmetic on local 'lat_d' (a nil value)" in many articles ([https://en.wikipedia.org/w/api.php?action=query&list=categorymembers&cmprop=title&cmlimit=500&cmnamespace=0&format=xml&cmtitle=Category:Pages_with_script_errors list]), for example [[Helsinki Finland Temple]] which uses {{tl|LDS Temple/Helsinki Finland Temple}} as in:

*<code><nowiki>{{ LDS Temple/Helsinki Finland Temple |format= Infobox LDS Temple }}</nowiki></code>

I guess the problem is that {{tl|Infobox LDS Temple}} includes <code><nowiki>{{coord|...|display=title}}</nowiki></code>. The article is somehow pulling the coordinates from {{Q|Q2603891}}. I'm dropping this here as a start for others to continue an investigation. [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 08:02, 22 May 2023 (UTC)

:Are you sure that the article is pulling "60°13'30"N, 24°46'54"E" from Wikidata and then displaying "Coordinates: 60°13′30.69479″N 24°46′54.42599″E", the value from {{tl|LDS Temple/Helsinki Finland Temple}}? That seems like it is not happening. Regardless, removing {{para|display|title}} from {{tl|LDS Temple/Helsinki Finland Temple}} makes the Lua error go away, but then the coordinates do not appear at the top of [[Helsinki Finland Temple]]. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 14:08, 23 May 2023 (UTC)

::Yes, you are right. I didn't look hard enough. Pretty weird situation but it's not really satisfactory to leave 150 articles with a big red error due to the recent change to this module. [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 03:16, 24 May 2023 (UTC)

:::I've fixed those. I made sure all the "Template:LDS Temple/" subpages has type:landmark in their coords params, then removed coordinsert from [[Template:Infobox LDS Temple]] and then updated those that just had display=title to also have inline. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 06:38, 24 May 2023 (UTC)

::::Thanks. I don't know how coordinsert works but you have probably seen my comment at 05:06, 24 May 2023 below where I mention that it receives an indicator strip marker rather than coordinates. I guess that some of its usages involve coordinates being directly passed to the function, while attempts to pass what Module:Coordinates produces will now fail. [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 07:18, 24 May 2023 (UTC)

== Coord2text ==

Line 496 ⟶ 472:

:::::No? [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 16:59, 6 June 2023 (UTC)

:::After the recent edit to Module:Coordinates and an low-substance edit on [[Australia (continent)]] the coordinates no longer appear. The [https://en.wikipedia.org/api/rest_v1/page/summary/Australia_(continent) REST endpoint] is still picking up the empty p and newlines: <code>extract: "\n\n"; extract_html: "&lt;p>\n\n&lt;/p>"</code>. Yes, I think it was changing it from a div to a span that did this particular line in. I think we can fix this by changing the hidden inline back to a div and then doing a second passover looking for a div in <code>coordinsert</code>, or changing the regex to be a bit more greedy at the beginning by removing its dependence on the tag. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 17:12, 6 June 2023 (UTC)

== Protected edit request on 28 September 2023 ==

{{edit fully-protected|Module:Coordinates|answered=yes}}

Add a format=dec4 function to output decimal degrees rounded to four places from data entered as either DMS or higher precision DEC format. The [[Geographical Names Board of Canada|Canadian Geographical Names Database]], [[Geographic Names Information System]], and [[Ordinance Survey]] provide ___location information with seven decimal degrees of precision. The dec4 format will permit the input data to be checked with the original data source while displaying the more reasonable and compact four decimal degrees of precision (+/- 10 m). [[User:Buaidh|<span style="color:white;background-color:#770022;font-weight:bold;">&nbsp;Buaidh&nbsp;</span>]]<span style="font-size:75%;vertical-align:middle;"> [[w:User talk:Buaidh|talk]] [[Special:EmailUser/Buaidh|e-mail]]</span> 21:57, 28 September 2023 (UTC)

: {{not done}} This is a repost of [[Module talk:Coordinates/Archive 2#Protected edit request on 14 September 2022]], which was closed as needing to be sandboxed and tested. We're a year and two weeks later, and this still hasn't AFAICS been sandboxed and tested. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 22:16, 28 September 2023 (UTC)

== Interface-protected edit request 27 December 2023 ==

{{sudo|Module:Coordinates|answered=yes}}

Please sync from [[Module:Coordinates/sandbox]] ([https://en.wikipedia.org/wiki/Special:ComparePages?page1=Module%3ACoordinates&rev1=1161270528&page2=Module%3ACoordinates%2Fsandbox&rev2=1192087921&action=&diffonly=&unhide=&diffmode=source diff]).

This adds a class and a data-gadget attribute to the span. For now, this is a no-op change. It is intended to facilitate a more performant way of loading the WikiMiniAtlas script, when coupled with the proposed changes in [[MediaWiki talk:Common.js#Class-triggered gadgets]]. – [[User:SD0001|<span style="font-weight: bold; color: #C30">SD0001</span>]] ([[User talk:SD0001|talk]]) 14:36, 27 December 2023 (UTC)

: {{done}} [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 16:54, 27 December 2023 (UTC)

{{sudo|Module:Coordinates|answered=yes}}

As MediaWiki now supports category-based gadget load, we can switch to that. Please sync from [[Module:Coordinates/sandbox]] ([[Special:Diff/1192107975/1226463973]]). For now, this is a no-op as the gadget isn't actually defined. – [[User:SD0001|<span style="font-weight: bold; color: #C30">SD0001</span>]] ([[User talk:SD0001|talk]]) 20:17, 30 May 2024 (UTC)

:: {{ping|BrandonXLFdone}} in case you are interested in this. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 1800:2422, 2131 May 20232024 (UTC)

== coordinsert problem? ==

@[[User:Jonesey95|Jonesey95]] I recently found your [[de:Benutzer_Diskussion:Plenz/OSM_for_Wiki#Errors_at_en:Hatfield_Chase|old question]] on German WP. It could be because of a malformed Geohack link: "Infobox UK place" uses coordinsert which generates a broken string when "coord" got a "title" parameter: https://geohack.toolforge.org/geohack.php?pagename=Hatfield_Chase&params=53.528_N_0.893_W_&title=Tunnel+Pits_region:GB_type:city (see the splitted "params" seperated by the "title" parameter).

"coordinsert" assumes "params" always as last parameter? Which isn't true when "title" is used. [[User:DB111|DB111]] ([[User talk:DB111|talk]]) 09:10, 14 August 2024 (UTC)