MediaWiki talk:Common.js: Difference between revisions
Content deleted Content added
→Signature: new section |
m Reverted changes by 188.122.121.153 (talk) to last version by EPIC Tag: Rollback |
||
| (139 intermediate revisions by 29 users not shown) | |||
Line 1:
{{process header
| title = MediaWiki talk:Common.js
| section =
| previous =
| next =
| shortcut =
| notes = Please use this talk page to propose and request changes to the [[MediaWiki:Common.js]]. Use {{tlx|editprotected}} to get attention from Meta-Wiki interface administrators. If your request is not handled in some days you may leave a message in the [[WM:RFH|administrators' noticeboard]]. Thank you.
}}
{{Autoarchive resolved section|age = 1 |archive = '((FULLPAGENAME))/Archives/((year))' | overview = [[MediaWiki talk:Common.js/Archives]] | latest archive = [[/Archives/{{CURRENTYEAR}}|{{CURRENTYEAR}}]]}}
== Local implementation of <code>importScript</code> ==
Can we remove this function <code>importScript</code>? Or maybe add <code>mw.log.deprecate</code> to it and use the default one if there is only one argument? [[b:pt:User:Helder.wiki|Helder.wiki]] 23:07, 25 July 2014 (UTC)
== Collapsible tables ==
Is [[MediaWiki:Common.js#L-3]] to 93 still needed? Since MW ≥ 1.18 [[:mw:Manual:Collapsible elements|collapsible elements]] are available in core. —[[User:MarcoAurelio|MarcoAurelio]] ([[User talk:MarcoAurelio|talk]]) 22:43, 12 March 2023 (UTC)
:@[[User:MarcoAurelio|MarcoAurelio]], these lines provide autocollapsing, which is not offered by core. en.wp reimplemented this in terms of mw-collapsible some time ago in lines [[w:MediaWiki:Common.js#L-73|73]] to 141, so I think it would be easy to crib what's there. I would not recommend importing inner/outer collapse, which look fairly easy to remove from the set of things implemented here.
:Additionally, it probably wouldn't be that hard to get rid of the 'collapsible' and 'collapsed' classes here in favor of pure mw-collapsible (it might confuse some people to start), which would allow us to skip lines 73 to 106 entirely and remove a few more lines in the other block. [https://meta.wikimedia.org/w/index.php?search=insource%3Acollapsible+inlanguage%3Aen+insource%3A%2F%28add%29%3F%5BCc%5Dlass.%7B0%2C25%7D%5B%5C%27%5C%22+%3D%5C%7C%5Dcollapsible%2F&title=Special%3ASearch&profile=advanced&fulltext=1&ns0=1&ns1=1&ns2=1&ns3=1&ns4=1&ns5=1&ns6=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1&ns200=1&ns201=1&ns202=1&ns203=1&ns206=1&ns207=1&ns470=1&ns471=1&ns482=1&ns483=1&ns710=1&ns711=1&ns828=1&ns829=1&ns866=1&ns867=1&ns1198=1&ns1199=1&ns1728=1&ns1729=1&ns2300=1&ns2301=1&ns2302=1&ns2303=1 Only about 600] pretty easy replacements, which is trivially within AWBable quantity. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 03:47, 13 March 2023 (UTC)
::I think it'd be better to replace with mw-collapsible/mw-collapsed where possible to avoid the maintenance burden. What do other people think? —[[User:MarcoAurelio|MarcoAurelio]] ([[User talk:MarcoAurelio|talk]]) 14:23, 13 March 2023 (UTC)
:::If I could get AWB and a flood flag if meta has one I'd be able to migrate everything to mw-collapsible/mw-collapsed. (I can do it without the flood flag ofc, I'll just have to take a bit longer not to swamp RC.)
:::Do you want autocollapse? It's not really obvious to me if you were still supportive of it. I think it makes sense as a general thing to keep with both [[Template:Navbox]] and [[Template:Sidebar with collapsible lists]] using it. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 03:17, 1 April 2023 (UTC)
== Shuffle for election candidates ==
See [[MediaWiki:Common.js#L-95]] to 126. I'm not sure there's any recent election using this? Can it be removed if no longer useful or needed? —[[User:MarcoAurelio|MarcoAurelio]] ([[User talk:MarcoAurelio|talk]]) 22:53, 12 March 2023 (UTC)
:[https://meta.wikimedia.org/w/index.php?title=Special:Search&limit=250&offset=0&ns0=1&ns1=1&ns2=1&ns3=1&ns4=1&ns5=1&ns6=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1&ns200=1&ns201=1&ns202=1&ns203=1&ns206=1&ns207=1&ns470=1&ns471=1&ns482=1&ns483=1&ns710=1&ns711=1&ns828=1&ns829=1&ns866=1&ns867=1&ns1198=1&ns1199=1&ns1728=1&ns1729=1&ns2300=1&ns2301=1&ns2302=1&ns2303=1&search=insource%3A%2Fdshuf%2F+inlanguage%3Aen Search lists a few from 2021 and 2022]. I do not think this is worth supporting. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 03:52, 13 March 2023 (UTC)
::In looking at pages like [[Template:WMF elections candidate/2021/candidates gallery]] - not even sure if it is working? — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 13:01, 13 March 2023 (UTC)
:::It works for me in [[Wikimedia Foundation elections/Board elections/2011/Candidates/en]]. While the Table of Contents itself do not get shuffled, the contents itself do at each page reload. —[[User:MarcoAurelio|MarcoAurelio]] ([[User talk:MarcoAurelio|talk]]) 14:41, 13 March 2023 (UTC)
:::The 2021 version does have randomization on the main page but it looks to have been set up using basic wiki functionality.
:::I think if that's available and apparently deemed acceptable, then this shuffling can be removed. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 22:01, 13 March 2023 (UTC)
== Gadgetize load CSS/JS with URL? ==
I updated this JS snipped to the latest version available on mediawiki.org (cf. [[MediaWiki:Common.js#L-326]]-361). However, I feel it'd be better to have this as an optional gadget for users that want to use it. While it would only work for pages in the MediaWiki namespace, it doesn't look like a feature that is used everyday; thus I feel there's no need to load this to every user. A gadget interested users can enable feels safer too. Thoughts? —[[User:MarcoAurelio|MarcoAurelio]] ([[User talk:MarcoAurelio|talk]]) 14:38, 13 March 2023 (UTC)
:@[[User:MarcoAurelio|MarcoAurelio]] need some searches, is it being used for some workflows like a single page form button somewhere? — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 15:50, 13 March 2023 (UTC)
::Agreed. I did a quick one but I want to re-run it later more calmly. We should also consider using the {{#tag:code|withgadget}} URL parametre when possible instead of this Snippet per [[Tech/News/2022/02]]. —[[User:MarcoAurelio|MarcoAurelio]] ([[User talk:MarcoAurelio|talk]]) 15:55, 13 March 2023 (UTC)
: Kind of a weird question, moving the JavaScript directly to a gadget doesn't really win anything (since Common.js is ResourceLoaded already -- just not on mobile, so maybe you gain something there). withgadget is maybe interesting.
:* [https://meta.wikimedia.org/w/index.php?search=insource%3AwithCSS+insource%3A%2F%5B%3F%26%5C%27%5C%22%5DwithCSS%2F+inlanguage%3Aen&title=Special%3ASearch&profile=advanced&fulltext=1&ns0=1&ns1=1&ns2=1&ns4=1&ns5=1&ns6=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1&ns200=1&ns201=1&ns202=1&ns203=1&ns206=1&ns207=1&ns470=1&ns471=1&ns482=1&ns483=1&ns710=1&ns711=1&ns828=1&ns829=1&ns866=1&ns867=1&ns1198=1&ns1199=1&ns1728=1&ns1729=1&ns2300=1&ns2301=1&ns2302=1&ns2303=1 withCSS is unused] except in Cat-a-lot and Common.js copies. In Cat-a-lot it looks to be an additional entry point that is unneeded from the rest of the wiki clearly.
:* [https://meta.wikimedia.org/w/index.php?limit=100&offset=0&profile=all&search=insource%3AwithJS+insource%3A%2F%5B%5C%27%5C%22%26%5C%3F%5DwithJS%2F&title=Special:Search&ns0=1&ns1=1&ns2=1&ns3=1&ns4=1&ns5=1&ns6=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1&ns200=1&ns201=1&ns202=1&ns203=1&ns206=1&ns207=1&ns470=1&ns471=1&ns482=1&ns483=1&ns710=1&ns711=1&ns828=1&ns829=1&ns866=1&ns867=1&ns1198=1&ns1199=1&ns1728=1&ns1729=1&ns2300=1&ns2301=1&ns2302=1&ns2303=1 withJS looks like a few uses].
:** [[Template:Wikidata translate]], uses [[MediaWiki:Mbabel.js]], only use of the template [[Met Open Access Artworks Challenge/Translations/EN]]
:** [[Template:Centralnotice-intro]] and [[Help:CentralNotice]], uses [[MediaWiki:CentralNotice Banner Template Intro.js]], unknown quantity of users (I don't understand why this exists, I'm pretty sure you could just use a preload??)
:** [[Help talk:Unified login/Archives/2020]], uses a page that doesn't exist locally and so the use could be removed
:** [[Template:Edit request/layout]], same
:** [[WikiConference North America/2020]], uses [[MediaWiki:Live-reload.js]]
:** [[Meta:Requests for help from a sysop or bureaucrat/Archives/2020-10]], uses [[MediaWiki:Gadget-AbstractWikipediaDraggableVoting.js]]
:* withModule is unused.
:[[User:Izno|Izno]] ([[User talk:Izno|talk]]) 21:01, 14 March 2023 (UTC)
== WMF template? ==
*Hello [[User:JPrakash-WMF]], can you explain a bit more why this script is needed here? What other options have been explored (e.g. templatescripts, etc). We generally take great effort to minimize global script loads. — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 15:57, 2 November 2023 (UTC)
*:I suggest this be reverted outright. Apart from maintenance by devs, WMF staff shouldn't be able to unilaterally inject scripts like this. [[User:Nardog|Nardog]] ([[User talk:Nardog|talk]]) 12:45, 3 November 2023 (UTC)
*As there has been no follow up communication, this has been reverted. If this is intended to be an [[Office actions|Office action]], please mark as such. Else, please discuss changes that impact all users first. — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 15:30, 3 November 2023 (UTC)
::Hello,
::Sorry for the delay in replying here–it took us a bit to discuss amongst ourselves and understand the issue. Firstly of course let me apologize for any disruption we’ve caused!
::As background, the work Jay is helping with is related to [[Communications/Movement Communications/Meta-Wiki presence|a project to make a better "front door" to the Foundation]], which comes from [[Special:MyLanguage/Movement communications insights/Report/Front door|requests from the community]] to better organize and structure Foundation pages so that people can more easily find the support they’re looking for (you can read about that background on the linked page above). A big part of this is an organized and maintained list of Foundation departments and teams and what they do. We built templates to better organize our information and help people navigate between pages. Our intention was to get these templates in place to have something concrete to show the community and invite discussion.
::It's a bit of a chicken and egg situation. It's hard to talk about visual changes without showing you. Since there are technical concerns and we don't want to show the Meta-wiki community broken pages, here's a few screenshots.
<gallery>
File:Meta Front Door - Header.jpg
File:Meta Front Door - Demo Department.jpg
File:Meta Front Door - Team One.jpg
File:Meta Front Door - User.jpg
</gallery>
::Given the complications, we’re wondering about the best path forward to get some of the elements you see here working. Mostly around the header navigation you see in the screenshots. The language picker, page indicators for team pages, moving the title, search box, and a few page elements as well.
::I copied the code we've been using in our development on Collab wiki [[User:CKoerner_(WMF)/WMF-Common.js|to this page]] if you want to see it all.
::We’d like to talk about this implementation and next steps. Where should we have a conversion on the technical bit? Is this the right venue? Thanks for any guidance you have on this! [[User:CKoerner (WMF)|Chris Koerner (Wikimedia Foundation) [he/him]]] ([[User talk:CKoerner (WMF)|talk]]) 20:16, 8 November 2023 (UTC)
:::@[[User:CKoerner (WMF)|CKoerner (WMF)]] Why do we need to run javascript for every single reader on every single page load to facilitate something like styling the userpages of foundation staffers? We wouldn't expect this sort of load for any other user group. For foundation pages that will be managed by staffers, the foundation wiki is already managed by WMF staffers and is right around the corner as well. — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 22:49, 8 November 2023 (UTC)
::::Hey @[[User:Xaosflux|Xaosflux]]
::::I'm sorry about this; it wasn’t fully clear to us that implementing some of these changes would need a site wide change, and if we’d realized that was an issue we would have started a conversation earlier. We’re happy to do that now, and to talk about alternatives that would accomplish the type of functionality that community members want on the Foundation’s Meta pages without being a burden. We’ve started talking as a team about alternatives but aren’t exactly sure yet, how to go about everything we need.
::::In talking to Jay who we contracted for development help, it seems it’ll be hard for things like the navigation functionality and styling to work without it, but of course we are open to alternatives, or to leaving behind some of these elements if needed. Jay's trying to be very cautious about how the code works, checking to see if the template exists first and then only running when appropriate.
::::I hear your concerns and I don't want to put more on you as a volunteer, but if after looking at the code, our project pages, and screenshots, you have suggestions of making this work better on Meta, I'd really welcome it. [[User:CKoerner (WMF)|Chris Koerner (Wikimedia Foundation) [he/him]]] ([[User talk:CKoerner (WMF)|talk]]) 15:43, 10 November 2023 (UTC)
:::::@[[User:CKoerner (WMF)|CKoerner (WMF)]] A good place to propose site-wide changes (as this is about teams wanting to install site-wide scripts) to the community is [[Meta:Babel]]. I think this is a bad idea for several reasons, but the community as a whole may be fine with it. My primary suggestion would be to attempt to present your content in the ways that the rest of the content on meta-wiki is presented, some examples of popular pages are [[Grants:Start]], [[Research:Index]]. Significant styling of sections may be able to be achieved with templatestyles. For wiki-style operations, but extensive niche customizations the [[:foundation:Home|foundation wiki]] may be a better home. If wiki-style page changes aren't needed for the "front door" the [https://wikimediafoundation.org/ foundation website] may also be a better home, and would allow for almost unlimited types of customization. — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 16:03, 10 November 2023 (UTC)
::::::@[[User:Xaosflux|Xaosflux]] Hi, some of these changes can be done via template styles (and already done so) but due to some limitations (e.g. you can't remove the header via template styles for security reasons hence the first line in that page), we might still need to load some js in some cases. That being said, it indeed doesn't need to be loaded unconditionally everywhere, Would adding something like this address your concerns?
<syntaxhighlight lang="javascript">
if ( mw.config.get('wgCategories').indexOf( 'WMF landing pages' ) != -1 ) {
importScript( 'MediaWiki:WMF_template/common.js' );
}
</syntaxhighlight>
::::::We definitely need to move more js to css as the current state can cause [[:w:Flash of unstyled content|FUC]] and is not desirable. [[User:ASarabadani (WMF)|ASarabadani (WMF)]] ([[User talk:ASarabadani (WMF)|talk]]) 18:16, 13 November 2023 (UTC)
:::::::@[[User:ASarabadani (WMF)|ASarabadani (WMF)]] I'm not convinced that "remove the header" is that important, but also this is creating technical debt for volunteers - getting bespoke scripts dropped in by staffers that ultimately won't end up being supported by staffers is something I see as undesirable (this is one of the bigger picture concepts that I think should be discussed at the Babel forum though). — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 18:40, 13 November 2023 (UTC)
::::::::@[[User:Xaosflux|Xaosflux]], thanks for the pointers, much appreciated. As Amir notes above we're looking at other solutions to implement some of these features for our work. We're not going to request any further changes to common.js for the moment. :)
::::::::Here's what I propose, let me know if this sounds good to you. We'll keep working on updating our templates to rely less on modifying common.js and more on other solutions that won't impact Meta-wiki as a whole. We (well, Amir!) have already made progress on this, there's an updated version of the code I shared above on Collab wiki.
::::::::Jay's going to continue moving the templates over from Collab wiki that don’t involve touching commons.js or other site-wide interface bits, so we can more easily share our work with the wider Meta-wiki community for feedback. We'll have some of the demo pages in the screenshots above set up so folks can not just see what we're working on, but interact with it too.
::::::::If, after exploring some different options, we do feel like we need to make site-wide changes for a few remaining things, we'll make a proposal for the changes and start a conversation at Babel.
::::::::FWIW I agree, we don't want to be creating technical debt! We plan to keep these templates – and more importantly, the documentation within – up-to-date and continue to improve them over time. The template will of course be available for remixing and reuse by others and may evolve outside of our purview and we want to build these in a way that can be iterated on. [[User:CKoerner (WMF)|Chris Koerner (Wikimedia Foundation) [he/him]]] ([[User talk:CKoerner (WMF)|talk]]) 16:19, 15 November 2023 (UTC)
:::::::::Sounds good, and having experienced developers author reusable code is a win for everyone! — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 16:55, 15 November 2023 (UTC)
| |||