Revision as of 07:38, 17 April 2023 edit MSGJ (talk \| contribs) Autopatrolled, Administrators 135,094 edits →Protected edit request on 16 April 2023: Reply Tag: Reply ← Previous edit		Revision as of 07:59, 17 April 2023 edit undo Johnuniq (talk \| contribs) Autopatrolled, Administrators 88,326 edits →Protected edit request on 16 April 2023: simple is good Next edit →
Line 236: :Has this been tested? Scibunto manual does not explicitly say that isRedirect will be true or false. — Martin <small>([[User:MSGJ\|MSGJ]] · [[User talk:MSGJ\|talk]])</small> 07:38, 17 April 2023 (UTC) :@Lemondoge: I have noticed your edits to sandbox modules that I monitor. Thanks for the tweaks and thanks for finding the bug noted [[Template talk:Navbox#Short-circuit in ternary expression at line 143\|here]]. However, I am not sure there is any benefit from optimizing code unless done as part of a significant effort by someone deeply invested in the particular module. Take this edit request—you are probably correct but who knows and who cares? It can be very challenging to verify rearrangements to boolean expressions. The original here is bulletproof. More importantly, it is easily seen to be bulletproof. I would leave it as is. It's not particularly important, but the edit request would result in uncertainty about what return values can occur while the original code removes any doubt. [[User:Johnuniq\|Johnuniq]] ([[User talk:Johnuniq\|talk]]) 07:59, 17 April 2023 (UTC)

Module talk:Redirect: Difference between revisions