Module talk:Coordinates: Difference between revisions

Revision as of 19:41, 5 June 2023

Revision as of 03:15, 6 June 2023

Line 492:

Copy the code from [[Module:Coordinates/sandbox]] to the main module. I adjusted the code so coordinsert works properly with the indicator in the title. The only difference to the output is that inline coordinates are now wrapped in a {{tag|span|attribs=class="geo-inline"}} tag, but I don't see anywhere where this would be an issue. I also added some manual testcases for when [[Module talk:Coordinates/testcases/manual/display t coordinsert|display=title]] and when [[Module talk:Coordinates/testcases/manual/display it coordinsert|display=inline title]] to verify the changes. The difference between the sandbox and module can be seen [https://en.wikipedia.org/w/index.php?title=Special%3AComparePages&page1=Module%3ACoordinates&page2=Module%3ACoordinates%2Fsandbox here]. <span class="nowrap">– [[User:BrandonXLF|<span style="color:blue;">Brandon</span><span style="color:green;">XLF</span>]] ([[User talk:BrandonXLF|talk]])</span> 19:41, 29 May 2023 (UTC)

:{{done}}<!-- Template:EP --> also made the change to coord2text noted above &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 15:00, 5 June 2023 (UTC)

::{{re|BrandonXLF|MSGJ}} based on timing, it appears that this change has broken page previews. For instance, hovering over [[Free City of Danzig]] shows just the coordinates, rather than the beginning of the article as it should. I haven't looked too closely to see whether this is a bug in the module or page previews, but you ought to consider reverting. [[User:Vahurzpu|Vahurzpu]] ([[User talk:Vahurzpu|talk]]) 03:15, 6 June 2023 (UTC)