Content deleted Content added
m Archiving 2 discussion(s) from Module talk:WikiProject banner) (bot |
m Archiving 3 discussion(s) from Module talk:WikiProject banner) (bot |
||
Line 199:
::I would go for option 1 first, 2 second, without any strong feelings about the choice. Both are better than current. · · · [[User:Pbsouthwood|Peter Southwood]] [[User talk:Pbsouthwood|<sup>(talk)</sup>]]: 11:09, 30 January 2025 (UTC)
:::Thanks Peter. I've gone with option 2 for now because that matches what the banner shell template uses, but don't really mind either wy. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:05, 30 January 2025 (UTC)
== January 2025 update ==
Code on the sandbox:
* Fix the problem with drafts not being able to rated for importance (see [[#Override importance to NA on non-articles]])
* Remove the transition code for the category moves from "articles" to "pages" (see [[#Fallback conflict]])
* Add transition code for the intersection categories (see bottom of [[#Changes for FM-class]])
* Fix an issue where the class was not being shown in the banner when there is no banner shell rating.
* Remove all code for the listas parameter (see [[#Moving listas to banner shell]])
— Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 10:53, 30 January 2025 (UTC)
:{{done|Deployed}} — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 22:35, 30 January 2025 (UTC)
== Moving listas to banner shell ==
I have coded some tracking categories to help us ensure that all listas values are moved into the banner shell template. I have created the following tracking categories:
# {{clc|WikiProject banners with redundant listas value}}
# {{clc|WikiProject banners with listas value which needs moving to banner shell}}
# <s>{{clc|WikiProject banners with conflicting listas value}}</s>
My plan to deal with these is:
# Parameter removed by bot ([[User:Qwerfjkl]] has offered to use his bot)
# Parameter moved by bot (I think [[User:Cewbot]] should already do this)
# Human review needed. (These should already be tracked in [[:Category:Pages with DEFAULTSORT conflicts]] and possibly cleared out by other editors working through this category.)
Any comments? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 21:57, 5 September 2024 (UTC)
:When completed and categories emptied, I think the code can be simplified to just have "Category:WikiProject banners with listas value which needs moving to banner shell", when listas is used. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 21:38, 6 September 2024 (UTC)
::Absolutely. And after a while, we could just remove the parameter entirely and then they will turn up in the unknown parameter categories — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 11:22, 7 September 2024 (UTC)
Planning to remove [[:Category:WikiProject banners with conflicting listas value]] because they will be picked up by [[:Category:Pages with DEFAULTSORT conflicts]] — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 19:55, 22 September 2024 (UTC)
:Martin, I don't understand this. Listas and defaultsort refer to the article page but the banner shell is on the talk page. [[User:Hawkeye7|<span style="color:#800082">Hawkeye7</span>]] [[User_talk:Hawkeye7|<span style="font-size:80%">(discuss)</span>]] 00:29, 23 September 2024 (UTC)
::You can sort any page, including talk pages. The banner sorts the page it's placed on. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 06:11, 23 September 2024 (UTC)
It's taken a while but I think we are now ready to remove all the code for listas from this module. Any remaining values will be picked up by the unknown parameter tracking — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 21:56, 9 January 2025 (UTC)
:{{removed}}. Now if you remove <code><nowiki>|listas={{{listas|}}}</nowiki></code> from banner templates, any use of listas will tracked as an unknown parameter — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 22:39, 30 January 2025 (UTC)
== Changes for FM-class ==
A few days ago [[:Category:FM-Class articles]] and all its subcategories were renamed to [[:Category:FM-Class pages]] and the module needs to be updated to reflect this.
I am requesting a code review of changes [https://en.wikipedia.org/w/index.php?title=Module%3AWikiProject_banner%2Fsandbox&diff=1261572962&oldid=1261227606 here]. There is a test case at [[Module talk:WikiProject banner/testcases#FM-class]]. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 20:34, 6 December 2024 (UTC)
:{{ping|MSGJ}} I don't know Lua, but it seems like [[Special:Diff/1261666097|this change]] made some talk pages of Wikipedia essays be categorized under [[:Category:Top-impact WikiProject Wikipedia essays pages articles]] instead of simply [[:Category:Top-impact WikiProject Wikipedia essays pages]] (also applies to high, mid and low importance). For instance, [[Wikipedia talk:Inline citation]] used to be [https://web.archive.org/web/20241130183129/https://en.wikipedia.org/wiki/Wikipedia_talk:Inline_citation#footer correctly categorized], but after the module edit, the red linked category was there. [[:Category:Top-impact WikiProject Wikipedia essays pages|The latter category page]] says that 9 pages are under it, but after purging one of those pages, it appeared under the red linked one. [[User:ObserveOwl|ObserveOwl]] ([[User talk:ObserveOwl#top|talk]]) 15:08, 7 December 2024 (UTC)
::Thanks for reporting. I think I know how to fix that — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 18:46, 7 December 2024 (UTC)
::Actually, not sure of the best way to fix this, but we also have [[:Category:NA-Class AfC project pages articles]]. Basically any project that was not using "articles" at the end of their assessment category will be affected. The next step is to rename other non-article page categories to "pages", and then I think this problem will largely be resolved. But it may take a bit of time to do this ... — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 23:24, 7 December 2024 (UTC)
:::[[Template:WikiProject U.S. Roads]] still broken. See [[:File talk:Bixby Creek Bridge, California, USA - May 2013.jpg]]. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 19:24, 8 December 2024 (UTC)
::::U.S. Roads does not use this module for its task forces. I have looked into converting it in the past, but there were barriers. I may have to move those categories back to their original names — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 21:49, 8 December 2024 (UTC)
:::::I don't think this module should continue supporting the handful of templates that want to do stuff their own way. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 01:30, 9 December 2024 (UTC)
::::::[[Template:WikiProject Redirect]] and [[:Category:NA-Class redirect pages articles]] also causing problems. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 17:50, 9 December 2024 (UTC)
Update: all remaining non-article categories have been nominated for moving. Please comment [[Wikipedia:Categories_for_discussion/Log/2024_December_7#Category:Category-Class_articles|here]]. Once these are done, we can fix this mess properly — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 23:15, 9 December 2024 (UTC)
:I believe that the required changes for all the remaining categories is now in [[:Module:WikiProject banner/sandbox]], but would appreciate any help testing and reviewing code — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 22:35, 14 December 2024 (UTC)
::{{ping|MSGJ}} File-Class categories are now listed at [[WP:CFDW]] for Speedy processing. Please could you repeat your FM-Class edits to [[Module:WikiProject banner]] for File class? – [[User:Fayenatic london|Fayenatic]] [[User talk:Fayenatic london|'''<span style="color:#FF0000;">L</span>'''ondon]] 10:09, 15 December 2024 (UTC)
:::It would be best if we could process all the others in one go, i.e. wait for [[Wikipedia:Categories_for_discussion/Log/2024_December_7#Category:Category-Class_articles|these]] to be closed — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 14:16, 15 December 2024 (UTC)
::::No it would be best to fix this now. This renaming has caused chaos because the bot can't process it and the templates can't be easily amended. Please make the necessary amendments immediately. [[User:Timrollpickering|Timrollpickering]] ([[User talk:Timrollpickering|talk]]) 00:25, 16 December 2024 (UTC)
:::::You are being overly dramatic, using words like "chaos", and it is not helpful. A handful of redlinked categories does not constitute chaos. I believe the necessary changes have now been made to the module, sop hopefully the bot can continue its work — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 22:42, 16 December 2024 (UTC)
:[[Template:WikiProject assessment category check]] needs to be updated. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 23:57, 16 December 2024 (UTC)
::{{ping|Gonnym}} like [https://en.wikipedia.org/w/index.php?title=Template:WikiProject_assessment_category_check/sandbox&diff=prev&oldid=1263832215 this]? – [[User:Fayenatic london|Fayenatic]] [[User talk:Fayenatic london|'''<span style="color:#FF0000;">L</span>'''ondon]] 22:22, 18 December 2024 (UTC)
:::I didn't check what needs to be done, I just noticed it was causing errors when looking at another page. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 11:00, 19 December 2024 (UTC)
I have rewritten [[Template:Category class]] in Lua, so it will now recognise categories with "pages" instead of "articles" — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 09:19, 20 December 2024 (UTC)
:Thank you {{u|MSGJ}}, that looks to have been quite a big piece of work. Please can you help with Gonnym's request above? For future reference, [[Template:Assessment Class Summary]] is another template that needs updating if any other classes are renamed from "articles". – [[User:Fayenatic london|Fayenatic]] [[User talk:Fayenatic london|'''<span style="color:#FF0000;">L</span>'''ondon]] 22:08, 21 December 2024 (UTC)
=== Break ===
{{ping|MSGJ}}: There is quite a bit of work not yet done to clean up the mess created by all this category renaming. Just to take the first two categories appearing in [[:Category:Wikipedia non-empty soft redirected categories]]:
# [[:Category:Category-Class 20th Century Studios articles of NA-importance]] contains 94 pages that are being placed in this category by {{tl|WikiProject 20th Century Studios}}.
# [[:Category:Category-Class Alabama road transport articles]] contains 49 pages that are being placed in this category by {{tl|WikiProject U.S. Roads}}.
Again, this is literally just the first two out of some 6,000+ assessment categories that may need to be reviewed and templates that need to be updated to use the new category names. It would be greatly appreciated if this could be made a priority, because the current backlog of incorrectly categorized pages is severely impacting the category redirect fixing bot. --[[User:R'n'B|R'n'B]] ([[User talk:R'n'B|call me]] Russ) 13:18, 5 January 2025 (UTC)
:Regarding the former, I was not aware these were being moved yet. Please link to the closed CfD for this. For the latter, we are actively discussing a way to fix these on [[Template talk:WikiProject U.S. Roads]] — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 17:43, 5 January 2025 (UTC)
::OK - the 20th Century Studios category apparently was moved by an overzealous editor (per the history) who saw a bunch of similarly-named categories being moved, and assumed that this one should be too. But then you have [[:Category:Category-Class Animation articles of NA-importance]], which was moved by the bot after someone (not me!) marked it for CFD/Speedy. Don't know how many others there are like this. --[[User:R'n'B|R'n'B]] ([[User talk:R'n'B|call me]] Russ) 20:02, 5 January 2025 (UTC)
:::I will try and look at the code changes needed for the intersecting categories as soon as possible (hopefully sometime this week) — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:37, 6 January 2025 (UTC)
:::Okay I have some code ready for review in [[Module:WikiProject banner/auxiliary/sandbox]]. Changes are:
:::* <s>If {{para|class|NA}} then no intersection category will be used.</s>
:::* <s>If {{para|importance|NA}} then no intersection category will be used.</s>
:::* For a non-article class (e.g. Redirect-class) it will check if the category with "pages" exists and will use that, otherwise it will use the category with "articles".
:::I tested this on [[:Category:Redirect-Class India articles of Mid-importance]] which is now at [[:Category:Redirect-Class India pages of Mid-importance]] and it seems to work okay — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 23:13, 9 January 2025 (UTC)
::::I jumped the gun on removing NA categories. There was a [[Wikipedia:Categories for discussion/Log/2024 December 21#Category:Portal-Class Comics articles of NA-importance|CfD]] but it only applied to two categories not more generally. I've left these in for now — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 12:42, 10 January 2025 (UTC)
:::@[[User:R'n'B|R'n'B]] This code has now been deployed, so we should be able to start nominating these categories for moving — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 22:37, 30 January 2025 (UTC)
::::@[[User:MSGJ|MSGJ]] If you review [[User:RussBot/category redirect log]], you'll see that there seems to be a new backlog of pages in the NA-importance categories that aren't being re-categorized by the template(s) correctly. --[[User:R'n'B|R'n'B]] ([[User talk:R'n'B|call me]] Russ) 13:09, 31 January 2025 (UTC)
| |||