Content deleted Content added
m Archiving 1 discussion(s) from Module talk:WikiProject banner) (bot |
m Archiving 1 discussion(s) from Module talk:WikiProject banner) (bot |
||
Line 358:
:{{done}}. I have moved the three preload templates to [[Template:WikiProject banner preload template]] and deleted all the rest which are no longer needed — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 18:14, 26 March 2025 (UTC)
== To do adjustments ==
I have [https://en.wikipedia.org/w/index.php?title=Module%3AWikiProject_banner%2Fauxiliary%2Fsandbox&diff=1274014600&oldid=1268570995 made a few adjustments] to the to do related code in /auxiliary/sandbox.
# Converted the presentational table to a more appropriate div.
# Use a dark mode token for the background.
# Removed support for setting custom styles. [[Template:WikiProject Freemasonry]] is the only project which uses them ([https://en.wikipedia.org/w/index.php?search=insource:/TODO_STYLE/%20-intitle:/(\/sandbox|\/doc)/&title=Special:Search&profile=advanced&fulltext=1&ns10=1&ns828=1 TODO_STYLE] [https://en.wikipedia.org/w/index.php?search=insource:/TODO_TITLE_STYLE/%20-intitle:/(\/sandbox|\/doc)/&title=Special:Search&profile=advanced&fulltext=1&ns10=1&ns828=1 TODO_TITLE_STYLE]), and the way in which they are used is not friendly for dark mode, though the particular color flavor happens to be readable. [https://en.wikipedia.org/w/index.php?title=Template%3AWikiProject_NASCAR&diff=1274014111&oldid=1175978317 I removed another] which was using the default in light mode.
It looks like [[Module:WikiProject banner/templatepage]] needs removal of the parameters of interest. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 02:10, 5 February 2025 (UTC)
:Great, thanks for the info. I can deal with /templatepage — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 18:15, 5 February 2025 (UTC)
:@[[User:Izno|Izno]] there is a slight spacing inconsistency with the new divs, which you can observe on [[Template:WikiProject Japan/sandbox]]. Are you able to line up the text on the left and the [show] links on the right? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 16:43, 22 March 2025 (UTC)
::Playing around with the left/right padding on the container seems to do it. Adding 2px on the left and another 2px on the right I think got it. Basically what's happening is that tables have a natural border-spacing (not coincidentally it's 2px) which is padding like but applied slightly differently. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 16:53, 22 March 2025 (UTC)
:::Padding is always inside the border. The spacing outside the border is the margin. See [https://www.w3.org/TR/css-box-3/#box-model The CSS Box Model]. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] 🌹 ([[User talk:Redrose64|talk]]) 23:27, 22 March 2025 (UTC)
::::Tables are special in that they have the border-spacing property. The point I was making is that in fact there is more to the box model than just padding and margin. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 00:58, 23 March 2025 (UTC)
:::::I don't see any changes to the sandbox and the example is still looking the same? If you can fix the spacing in the sandbox, I suggest we change all of the collapsible boxes in the module to use div boxes, to keep things consistent — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 08:46, 24 March 2025 (UTC)
:::::@[[User:Izno|Izno]] are you still interested in this? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 20:48, 28 March 2025 (UTC)
::::::I didn't make any adjustments, which is why you do not see any changes.
::::::I didn't change the other collapsible boxes because they're more or less fairly marked up as tables, from memory (and memory may be wrong of course). [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 21:30, 28 March 2025 (UTC)
:::::::In that case I can't really see a benefit to converting the table to a div, as it will introduce an inconsistency. I have removed the style parameters from /templatepage, so these will now be treated as unknown parameters — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 18:53, 30 March 2025 (UTC)
| |||