Content deleted Content added
→Code to insert bold tags: globals still there |
|||
Line 273:
That said, non-working bolding is better than the error that was there before, so good job restoring partial functionality while I was MIA :) It's fixed now. —[[User:Codehydro|<font color="#aaaaaa" face="Unicode" style="font-size:12pt;">'''Code'''</font>]][[User talk:Codehydro|<font color="#5577aa">'''Hydro'''</font>]] 23:32, 8 September 2018 (UTC)
|}
::@[[User:Codehydro|Codehydro]]: It's good code! I monitor [[:Category:Pages with script errors|script errors]] and my edits here were, I'm afraid, merely intended to remove those errors. I know nothing about this topic or exactly what the module is supposed to do so I was working in the dark. If you want to support a single occurrence of <code><nowiki>'''</nowiki></code> as valid bolding I suppose that is ok, but my humble opinion is that it would be better to throw an error or put the article in a hidden category so the broken wikitext can be fixed. The purpose of my edit was to remove a problem, but while doing that I chose to only replace <code><nowiki>'''</nowiki></code> if there were exactly two occurrences as a quick workaround. Anyway, that's up to you.<p>You may not be aware that the global variables I mentioned are almost certainly bugs that need to be fixed. I can explain more if you like, but searching for each will show places where they would give <code>nil</code> as an uninitialized global. I could take a stab at fixing a couple of them but it would take longer than I have to work out the underlying intention regarding what should happen. [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 01:30, 9 September 2018 (UTC)
== "previewnumbers" do not work ==
| |||