Content deleted Content added
→Making the lum function accessible from modules: very sensible and useful improvement |
|||
Line 23:
:
: {{re|Gonnym}} That looks like a very sensible and useful improvement. My only reservation is that passing the parameters as a table gives the person wanting to import the routine no idea of what values/types to supply to the routine without having to read through all of the code to determine them. In general I'd usually recommend either documenting a brief list of required values for the args table or passing the parameters as a list of obviously-named variables rather than a table. But that's just a minor point and shouldn't stop you from updating the main module. --[[User:RexxS|RexxS]] ([[User talk:RexxS|talk]]) 13:03, 6 January 2019 (UTC)
::{{ping|RexxS}} I don't mind doing either if that helps. I just followed the current style used for the other three public functions. Do you want me to change _lum(args) to _lum(color)? --[[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 13:27, 6 January 2019 (UTC)
| |||