Content deleted Content added
→Localisation: thanks |
|||
Line 34:
:::::I have uploaded in the [[Module:Val/sandbox]] a test version with all the error messages listed in a table at the top of the file. It pass all test in [[Template talk:Val/testcases]] except for 27 cases, but the previous version in sandbox was failing them too. Ithaquabe the expected result should be corrected in the table of test ?
:::::I have also added a test on row 133-135 <code><nowiki>if numdot ~= '.' then arg = arg:gsub(numdot, '.') end</nowiki></code> to replace the locale numdot with "." if different from dot. --[[User:Moroboshi|Moroboshi]] ([[User talk:Moroboshi|talk]]) 11:40, 6 June 2019 (UTC)
::::::Thanks, that's great work, and you have thoughtfully used the same style that I would. I made a couple of minor changes in [[Module:Val/sandbox]]. One strange thing is that something changed "may" to "Ithaqua" in your edits both here and in the module. There is no benefit from using mw.ustring.format rather than plain string.format with <code>%s</code>.<br>I updated the testcases to show what the current {{tl|val}} does and now [[Template talk:Val/testcases]] shows only two differences from the sandbox. They are due to use of &quot; in the sandbox.<br>I assume the messages used <code>&quot;</code> instead of plain <code>"</code> because valerror replaces all quotes in warnings with <code>&quot;</code>. I think it would be better to use the clear <code>"</code> in the messages and let valerr do what it needs to. There is no problem with overhead because valerror is only called if an error occurs, and that is rare. Further, if an error occurs, additional overhead is immaterial, and would be minuscule.<br>I wouldn't be surprised if further work is needed somewhere because val can output some strange wikitext. Please let me know how you get on at itwiki. I will update the main module here when you have completed your tests. [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 08:15, 7 June 2019 (UTC)
| |||