Module talk:IPAddress: Difference between revisions

Content deleted Content added
Reuse Module:IP: ok but fix
Reuse Module:IP: hunting for usage
Line 79:
What do you think about this change? If it's something that will break other templates, then I would propose to add new functions to check if a string is an IPv4 or IPv6 IP or range. [[User:MarioGom|MarioGom]] ([[User talk:MarioGom|talk]]) 18:28, 18 March 2021 (UTC)
:Probably desirable although I haven't looked at the details yet. It would be quite a lot more overhead but probably insignificant. Some thought about how Module:IPAddress is used would be good (if it's not used much, overhead doesn't matter). However, if it's going to be redone, please fix the atrocious global functions and fix any modules which use them. This is 2021 and global functions are known bad! For one thing, any module using [[Module:No globals]] will crash if it tries to use these functions. [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 00:58, 19 March 2021 (UTC)
::I don't know how reliable it is, but according to "what links here", Module:IPAddress is not used by any modules (apart from itself for some weird reason). It is used by around 210 templates but I suspect that almost all of them are incorrect reporting by the tool, due to use of {{tl|Userspace linking templates}} on the doc pages of those templates. There may be more, but the only templates I can find using this module are {{tl|IsIPAddress}} and {{tl|Xsign}}. The module is used at [[MediaWiki:Newarticletext]]. {{ping|L235}} Did you use this module somewhere? [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 09:09, 19 March 2021 (UTC)