Revision as of 08:38, 28 March 2021 edit Johnuniq (talk \| contribs) Autopatrolled, Administrators 88,358 edits →Reuse Module:IP: needs thought ← Previous edit		Revision as of 08:38, 28 March 2021 edit undo Johnuniq (talk \| contribs) Autopatrolled, Administrators 88,358 edits →Reuse Module:IP: and testcases Next edit →
Line 84: :::::Sounds good then! I have no permissions to edit this template, can any of you apply the changes in the sandbox? Is there anything that needs to be addressed before? [[User:MarioGom\|MarioGom]] ([[User talk:MarioGom\|talk]]) 16:44, 27 March 2021 (UTC) ::::::The thing that's outstanding is fixing the globals as mentioned above. I'll have a look at that later. [[User:Johnuniq\|Johnuniq]] ([[User talk:Johnuniq\|talk]]) 00:50, 28 March 2021 (UTC) :::::::I edited the sandbox to fix the globals. However I added a TODO note which is going to require quite a bit of thought because the changes (to accept ranges as noted above) might not be compatible with how this module is used. I'm not even sure if it is desirable: should 1.2.3.4/5 be regarded as a valid IPv4 address? Also, the testcases need thought. [[User:Johnuniq\|Johnuniq]] ([[User talk:Johnuniq\|talk]]) 08:38, 28 March 2021 (UTC)

Module talk:IPAddress: Difference between revisions