Content deleted Content added
Guarapiranga (talk | contribs) |
|||
Line 467:
::::::::So I went ahead and created a copy of [[Module:Chart]] in its sandbox with ''string'' instead of ''mw.ustring''. At least in the doc examples, it doesn't break. Should it be 'downgraded'? [[User:Guarapiranga|— 𝐆𝐮𝐚𝐫𝐚𝐩𝐢𝐫𝐚𝐧𝐠𝐚]] ([[User talk:Guarapiranga|talk]]) 23:00, 25 May 2021 (UTC)
:::::::::Testing in [[Module:Graph table]] showed that [[Module:Chart]] requires a proper frame because it calls <code>frame:preprocess(...)</code>. Adding that makes the chart work. The regex does not handle the 6.4e5 notation. Regarding removing mw.ustring from Module:Chart: The problem is that who ever does that is volunteering to maintain the module and I don't want to take that on, however I fixed [[Module:Chart/sandbox]] by using tab indents and removing unintended globals (including a couple of typos) and removing a couple of unused items. I checked the removal of mw.ustring and it is good although the <code>getArg</code> function could fail if it were ever used in a vastly different way from how it is used now. After testing and more thought, it would be ok to update [[Module:Chart]] because I don't want to fix the sandbox again. [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 05:20, 26 May 2021 (UTC)
::::::::::Awesome! ''It lives!!'' That's proof of concept right there. Thanks, {{u|Johnuniq}}.
::::::::::{{tq|Testing in Module:Graph table showed that Module:Chart requires a proper frame because it calls frame:preprocess(...). Adding that makes the chart work.}}
::::::::::No idea what that means. Totally above my pay grade. Would never have guessed it.
::::::::::{{tq|The regex does not handle the 6.4e5 notation.}}
::::::::::Yeah, I expected that. {{Fixed}}
::::::::::{{tq|After testing and more thought, it would be ok to update Module:Chart because I don't want to fix the sandbox again.}}
::::::::::Will do. [[User:Guarapiranga|— 𝐆𝐮𝐚𝐫𝐚𝐩𝐢𝐫𝐚𝐧𝐠𝐚]] ([[User talk:Guarapiranga|talk]]) 12:43, 26 May 2021 (UTC)
| |||