MediaWiki talk:Common.js/Archive 8: Difference between revisions

Revision as of 11:30, 7 February 2018

Revision as of 11:01, 1 October 2021

Line 28:

I have just reverted Martinp23's addition of the search engine images. Adding images like these violates our [[WP:FU|fair use policy]] and may be interpreted as ads. [[User:Sean William|Sean William]] 22:46, 19 May 2007 (UTC)

:Agreed. <small>^{<font color="#000">[[User:H|(]]</font><fontspan colorstyle="color:#c20000000;">(</span>]][[User talk:H|H]]</font><fontspan colorstyle="color:#000cc2200;">H</span>]][[User:H|<span style="color:#000000;">)]]</fontspan>]]}</small><!-- Was HighInBC --> 22:50, 19 May 2007 (UTC)

::Likewise. I factored the images out, but apparantely I'm not allowed to do that, so putting this reversion up for discussion - to be clear, the ideal way to give the external searches would be server-side, in the mediawiki text, but as no params are available in the relevant text, something client side is required. This has been requested in various places, including [[WP:AN]] (which, incidentally, is where I decided to add the images code, from fr.wiki, as a favour - still somewhat sick at the hostility of some to an easily reversible mistake...). The removal of the code which I changes is reverted [http://en.wikipedia.org/w/index.php?title=MediaWiki:Common.js&curid=763577&diff=132109299&oldid=132106859 here]. [[User:Martinp23|Mart]]'''[[User_talk:Martinp23|inp23]]''' 00:21, 20 May 2007 (UTC)

::: Unfortunately any code pasted here is not easily reverted as it can stayed cached in visitors' browser cache for weeks. Any mistakes in the code can cause anything from annoying popups to appear to all pages on Wikipedia showing up blank during that time. From the simple cut 'n paste job you did I assumed you are not familiar with Javascript yourself, while adding executable code to one of the most visited websites is something that should not be doen without a little care. There are usually enough people hanging around on this page who van evaluate (and perhaps improve the code) on it's correctness, performance impact, maintainability etc. This was not meant as a hostile action, but as necessary caution. A reaction you can sometimes expect when being bold. —''[[User:Ruud Koot|Ruud]]'' 13:27, 20 May 2007 (UTC)

Line 35:

::::::Not at all! Thank you for your diligence in taking that care. Feel free to re-enter the js when/if you feel it has been suitably reviewed. [[User:Martinp23|Mart]]'''[[User_talk:Martinp23|inp23]]''' 19:25, 20 May 2007 (UTC)

::I support the image free version. Good idea. <small>^{<font color="#000">[[User:H|(]]</font><fontspan colorstyle="color:#c20000000;">(</span>]][[User talk:H|H]]</font><fontspan colorstyle="color:#000cc2200;">H</span>]][[User:H|<span style="color:#000000;">)]]</fontspan>]]}</small><!-- Was HighInBC --> 19:28, 20 May 2007 (UTC)

:See my note below. I'm not a fan, but at least I can do <code>onloadFuncts.splice(onloadFuncts.indexOf(SpecialSearchEnhanced3), 1)</code>. [[User:Gracenotes|<span style="color:#960;">Grace</span><span style="color:#000;">notes</span>]]^{[[User talk:Gracenotes|<span style="color:#960;">T</span>]]} § 19:41, 20 May 2007 (UTC)