Content deleted Content added
MalnadachBot (talk | contribs) m Fixed Lint errors in signatures. (Task 2) |
MalnadachBot (talk | contribs) m Fixed Lint errors. (Task 12) |
||
Line 51:
== Embedded alert template isn't showing its show/hide link ==
See {{tl|WikiProject Louisville}} template (using WPBannerMeta) where I set BOTTOM_TEXT to {{tl|WikiProject Louisville alerts}}, which uses {{tl|hidden}} for showing/hiding the alerts. The alert box's show/hide link won't show with normal usage of {{tl|WikiProject Louisville}}, except when it's nested. Is this a bug in WPBannerMeta or a bug in {{tl|WikiProject Louisville alerts}} or a bug in {{tl|hidden}}? [[User:Stevietheman|<
:It works for me, both nested and unnested. What browser are you using? [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 00:19, 2 November 2008 (UTC)
::I am using Firefox 3, and I just tested it against IE 7. It looks like it's not a matter of browser, but of skin. I'm using Cologne Blue, where the bug is appearing, but with the default skin, it works fine. [[User:Stevietheman|<
::Does anyone know what is causing this problem? Is it a skin issue or an issue with this template (or other templates I refer to)? [[User:Stevietheman|<
:::I'm afraid I'm not sure; I can replicate the problem by changing to cologneblue skin, so it's clearly skin-related. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 23:54, 3 November 2008 (UTC)
:There has been a change to our alert that doesn't really fix the problem but instead just spills out the alert text when the banner isn't nested. The alert text needs to be hidden with a show link whether the banner is nested or not. [[User:Stevietheman|<
::That edit was to make the text visible to users without javascript (previously it was inaccessible). I'm honestly not sure why it doesn't work in cologneblue; I have asked at the village pump, maybe someone will have an answer there. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 23:44, 6 November 2008 (UTC)
:::I appreciate your work on this! There's a problem with this latest approach though. I have JavaScript enabled, and the alert text in an unnested project template is all showing, when it should be rolled up with a Show link. I understand the need to show all the text to those with JavaScript disabled, but that shouldn't be the standard behavior. [[User:Stevietheman|<
::::I have Javascript enabled too, and it looks fine. Another skin issue? [[User:Stepshep|<span style="color:green; font-family:Comic Sans MS;">§hep</span>]] • [[User talk:Stepshep|<span style="color:green; font-family:Comic Sans MS;">¡Talk to me!</span>]] 00:10, 7 November 2008 (UTC)
:Yes, Stevie, I know, this is the problem I'm trying to get my head around. The issue is entirely ''un''related to the recent edit to {{tlx|hidden}}, as evidenced by the way it still recurs after I converted it to use CollapsibleTables instead. If you try viewing any other page using any other skin, you can see that the uncollapsed-by-default appearance is ''not'' the standard behavior. I'm doing my best to resolve this issue; just be patient (but keep prodding me if it seems I've forgotten!). [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 00:15, 7 November 2008 (UTC)
:If there's no requirement for the project banner to be based off WPBannerMeta, I may move it back to its prior design, until this issue can be resolved. It was doing all right before being standardized anyway. [[User:Stevietheman|<
::This should now be fixed. Does it work for you? [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 17:38, 10 November 2008 (UTC)
:::Yes, it's working now. Thanks! What was changed to make it work? [[User:Stevietheman|<
::::The CollapsibleTables code itself had a subtle error which affected the cologneblue skin only (it was looking for an id that doesn't exist in the cologneblue skin metadata). It wasn't spotted before because, TBH, no one uses cologneblue! <tt>:D</tt> That doesn't mean we can allow such random problems to persist, however, so thanks for bringing this to our attention. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 22:49, 10 November 2008 (UTC)
Line 93:
== Nested title not centered like in other project banners ==
This is a very minor issue, but still a little nit I noticed. Project banners based off of WPBannerMeta have their titles left-aligned when nested instead of being centered like the titles of other project banners. Could this title be centered, or can we be given an option to align the title? Thanks! [[User:Stevietheman|<
:Browser/OS please? [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 16:41, 11 November 2008 (UTC)
::I'm not sure how that matters, but it's Firefox 3.0.3 and Windows Vista (all updates applied). [[User:Stevietheman|<
:::Oh believe me, all rendering/display problems are browser-related <tt>:D</tt>. Even though it's the banner that needs to be altered, it's the browser that's revealing the problem, and if I can't see it on my browser (obviously if I could I'd already have tried to fix it <tt>:D</tt>) it makes it much harder to reproduce and hence fix. Can you tell me, please, what you see at [[User:Happy-melon/sandbox5]]?? [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 17:42, 11 November 2008 (UTC)
::::The first two nested project titles are centered, and the third appears left-aligned. Beyond browser rendering differences, I wonder if this could be a skin issue again (arghh, I love Cologne Blue!). :) [[User:Stevietheman|<
::::In IE7, the first project title appears more centered than when viewing with Firefox, but it still sits significantly to the left of the first two. [[User:Stevietheman|<
:::::Hi. [[Template_talk:OH-Project#Aligning_to_the_left|This]] discussion also seems related. If you have the '''Justify Paragraphs''' option ticked, it aligns the banner name to the left.--[[User:Rockfang|Rockfang]] ([[User talk:Rockfang|talk]]) 17:47, 12 November 2008 (UTC)
::::::When I unchecked "Justify Paragraphs", the nested title centered itself. Of course, I want to leave this checked, as that's how I like to read the pages. So, I continue to consider this a very minor bug. [[User:Stevietheman|<
:::::::Indeed, it is minor. I still hope someone is able to fix it though. :) [[User:Rockfang|Rockfang]] ([[User talk:Rockfang|talk]]) 02:54, 13 November 2008 (UTC)
::::::::I didn't mean to suggest it wasn't worth fixing. The left alignment is kind of an eyesore. :) [[User:Stevietheman|<
:Bizzarre though it sounds, I intend to be able to fix this when I get a response [[MediaWiki_talk:Common.js#CollapsibleTables_show.2Fhide_button|here]]. In the meantime can I just check that everyone sees the header below centered, even if it does linewrap unexpectedly? [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 08:44, 13 November 2008 (UTC)
{{WikiProjectBannerShell|1=
Line 135:
}}
::It's a lot more centered than before, but it still leans to the left just a tad. [[User:Stevietheman|<
:::Same here.--[[User:Rockfang|Rockfang]] ([[User talk:Rockfang|talk]]) 17:36, 13 November 2008 (UTC)
Line 142:
:::::Here's a screenshot from me [[:Image:WPOH Banner.png]] (yep bad name). The top of the banners are way to big. [[User:Stepshep|<span style="color:green; font-family:Comic Sans MS;">§hep</span>]] • [[User talk:Stepshep|<span style="color:green; font-family:Comic Sans MS;">¡Talk to me!</span>]] 17:37, 14 November 2008 (UTC)
:::::The first and second look identical. I'm a little too busy to post a screenshot right now, but should have time over the weekend. [[User:Stevietheman|<
::::::Here's a screenshot of the above that I just took: [[:Image:NestedBannerMetaExample.jpg]]. [[User:Stevietheman|<
:Aha! I see what you're concerned about. The space between the WikiProject link and the "rated X class" bracket ''is'' in the centre of the banner. It's only because the text on the left "WikiProject Musical Instruments" is longer than the text on the right "Rated Start-Class") that it appears to be off-centre. If I lined up a number of different banners with different texts, the 'centreline' of the headers would become more obvious. Now, if we can work out why the show/hide button and the actual header text appear on separate lines, we'll be in business. I suspect I know what's going on there, but not how to fix it; no combination of attributes I've managed to apply can make the subtable centre in the cell without using width=100%; those two floating spans screw everything up. Does anyone have any bright ideas? Because at the moment I'm reduced to saying that the only way to both centre the titles and align their midpoints (which will beautify pages like [[Talk:Duduk]] no end) is to get yet another modification to the CollapsibleTables code for a way to manually position the show/hide button. Again, it's functionality that could be useful elsewhere, but it seems a very brute-force solution. Then again, the set of nested tables and cross-styled divs that this template currently uses isn't particularly elegant itself.... Any clever ideas? [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 20:57, 17 November 2008 (UTC)
Line 475:
Just one question: why? —[[User:Ms2ger|Ms2ger]] ([[User talk:Ms2ger|talk]]) 18:34, 21 December 2008 (UTC)
:Something I've always wanted, and I only just got round to implementing. I'm not sure where's best to put them, tho; I thought about above the left image or in the bottom-right corner as well. Thoughts? [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 18:50, 21 December 2008 (UTC)
::I like it. An 'r' link (for refresh) would a good idea as well. [[User:Stevietheman|<
:::It's just inlining {{tlx|navbar}}, which is itself just a ripoff of {{tlx|tnavbar}}, so you should probably take that idea over there. I do think it's a good idea, tho. [[User:Happy-melon|<b style="color:forestgreen;">Happy</b>]]‑[[User talk:Happy-melon|<b style="color:darkorange;">melon</b>]] 19:01, 21 December 2008 (UTC)
Should it be v . d . e rather than v . e . h though? -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 19:15, 21 December 2008 (UTC)
| |||