Content deleted Content added
→Performance change: done |
ClueBot III (talk | contribs) m Fixing links to archived content. (BOT) |
||
Line 42:
:::{{re|Xaosflux}} I don't have the Lua knowledge to properly comment on {{u|Snævar}}'s changes, but they seemed to indicate all would be the same with less memory usage (which seems to be the goal). - [[User:Favre1fan93|Favre1fan93]] ([[User talk:Favre1fan93|talk]]) 21:39, 18 February 2022 (UTC)
:{{not done}} all of the [[Module talk:EditAtWikidata/testcases|test cases]] are reporting failure, {{re|Snævar}} can you review and comment on that? (Once resolved, reactivate the edit request). — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 01:14, 25 February 2022 (UTC)
LOL! I saw this when pinged but ignored it because I haven't been involved here and had other things to do—see [[Template talk:Authority control/Archive 13#Big problem]] where I've just found that <code><nowiki>{{EditAtWikidata|pid=identifiers}}</nowiki></code> uses 17MB of Lua memory at [[Among Us]]. I previewed an edit to this module to convince myself that a simple change would reduce that to well under 1MB. Then I checked the talk page to see if there was any activity. Now I see that {{u|Snævar}} has put the correct code in the sandbox with some other things I didn't think of! The reason [[Module talk:EditAtWikidata/testcases]] is showing failures is that the sandbox includes noprint to remove the pencil from printed articles (see the section below). That is, the output is <code><nowiki><span class="noprint">...</span></nowiki></code> where <code>...</code> is the previous output. While we're implementing this I think the Lua code should be further cleaned up and I will have a go at that in the next day or two. Please wait before implementing to see if my tweaks are worthwhile. [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 09:38, 11 March 2022 (UTC)
:I tweaked the code in [[Module:EditAtWikidata/sandbox]] and temporarily removed the noprint span so [[Module talk:EditAtWikidata/testcases]] works. The output includes several redundant spaces that no one can see so I plan to remove them before going live. I left them for now so the tests work. When the issue in the section below is settled I can update the module and make a small tweak in [[Module:Authority control]] to directly call the module rather than expand the template which it is doing at the moment. [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 02:36, 12 March 2022 (UTC)
::I have updated [[Module:EditAtWikidata/sandbox]]. Previewing an edit of [[User:Johnuniq/sandbox2|my sandbox2]] showed that the Lua memory usage for <code><nowiki>{{EditAtWikidata|qid=Q96417649}}</nowiki></code> was 17,150,179 bytes, but adding <code>/sandbox</code> reduced that to 526,882 bytes. I'll update the main module soon. [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 01:59, 13 March 2022 (UTC)
| |||