MediaWiki talk:Common.js/Archive 4: Difference between revisions

Revision as of 04:31, 1 March 2022

Revision as of 23:30, 4 September 2022

Line 23:

== escape() and replace() in importScript function ==

I read this [[MediaWiki_talk:Common.js/Archive_2#Import_Module|December discussion about import module]] but I still don't see why <ttcode>escape()</ttcode> is there in the first place. Can you please give me an example when it's really needed? As far as I can see, it doesn't work for 2-byte Unicode characters anyway, so in [[:ru:MediaWiki:Common.js]] we had to remove it so far.

Same question for <ttcode>replace()</ttcode>: everything seems to work fine without it, even with spaces in the script path.

— [[User:Alex Smotrov|Alex Smotrov]] 20:48, 3 March 2007 (UTC)

Line 161:

== Proposal: Edittools with Javascript ==

Replace all those <code><a … onlcick=InsertTags </code> lines now generated from [[MediaWiki:Edittools]] with javascript code inside <ttcode>MediaWiki:Editpage.js</ttcode>. Sample version of this code: [[User:Alex Smotrov/createEditTools]], see discussion page for instructions on how to test it. Advantages:

* ease of removing (not just hiding) unnecessary characters and adding your own

* Js code is about 10 times smaller

Line 194:

<span id="63298702036" ></span>

== Proposal: Editpage.js ==

Create another «common» javascript file <ttcode>MediaWiki:Editpage.js</ttcode> and «call» it from [[MediaWiki:Common.js]] (already implemented e.g. in [[:pl:MediaWiki:Monobook.js]] and [[:ru:MediaWiki:Common.js]]: search for "<ttcode>Onlyifediting.js</ttcode>")

if (document.___URL.indexOf('action=edit') > 0 || document.___URL.indexOf('action=submit') > 0)

importScript('MediaWiki:Editpage.js');

Then move from [[MediaWiki:Common.js]] → <ttcode>MediaWiki:Editpage.js</ttcode>

* code «Extra toolbar options» (mwCustomEditButtons)

* code «fix edit summary prompt for undo»