Content deleted Content added
Trialpears (talk | contribs) →isIpV4Range and isIpV6Range: new section |
→isIpV4Range and isIpV6Range: Reply |
||
Line 123:
I've created the new functions isIpV4Range and isIpV6Range which do exactly what it sounds like. This is for use in [[Template:Vandal]] but can probably come in handy in other places as well. If noone objects in the next few days I will take the code in the sandbox live. There are testcases. --[[User:Trialpears|Trialpears]] ([[User talk:Trialpears|talk]]) 18:30, 10 January 2023 (UTC)
:i do not see any such functions in the snadbox.
:i am guessing the functions you describe reside somewhere else. furthermore, i am guessing they are in the same vein as _isIpOrRange().
:presuming this is the case, i'll say what i should have said when this function was added: i think it's utterly silly. not the function itself, of course, but its inclusion in this module. i can't imagine what is the added value of placing in module A a function that does nothing but pipe calls to module B.
:this practice makes sense when some of the "native" functions of A are using this implanted function, but this is not the case here, and _isIpOrRange, as well as the 2 new functions you describe are entirely for "export" purposes. all they do is pipe functionality of [[Module:IP]], and my common sense says they should reside there. what is the value of planting this "foreign body" here?
:tl;dr: please consider placing these new functions in module IP rather than here.
:peace. [[User:קיפודנחש|קיפודנחש (aka kipod)]] ([[User talk:קיפודנחש|talk]]) 19:47, 10 January 2023 (UTC)
| |||