Content deleted Content added
Line 109:
|}
Anyway, I don't see this conflicting with any other use of the module, and it hasn't broken in the period of me testing it, so I will add these changes to the main module, unless you have an objection or want to do it better (I don't think this is the best-written code, as I am not a "Lua guy"). '''[[User:JPxG|jp]]'''×'''[[User talk:JPxG|g]]''' 05:05, 17 January 2023 (UTC)
:{{ping|JPxG}} Thank you for implementing this. Personally, I would use digits to specify the page view durations: <code>views7</code> and <code>getViews7</code> instead of <code>viewsSeven</code> and <code>getViewsSeven</code>. I find it easier to tell at a glance what the number is when using digits. Also, once it gets over 100, things start to get less obvious. Should it be <code>getViewsOneTwenty</code>, <code>getViewsOneHundredTwenty</code> or <code>getViewsOneHundredAndTwenty</code>? Users of the module will probably have to look at the documentation to get it right. Otherwise, the code looks good to me. — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr. Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪ talk ♪]]</sup> 14:32, 18 January 2023 (UTC)
| |||