Content deleted Content added
Line 112:
:{{ping|JPxG}} Thank you for implementing this. Personally, I would use digits to specify the page view durations: <code>views7</code> and <code>getViews7</code> instead of <code>viewsSeven</code> and <code>getViewsSeven</code>. I find it easier to tell at a glance what the number is when using digits. Also, once it gets over 100, things start to get less obvious. Should it be <code>getViewsOneTwenty</code>, <code>getViewsOneHundredTwenty</code> or <code>getViewsOneHundredAndTwenty</code>? Users of the module will probably have to look at the documentation to get it right. Otherwise, the code looks good to me. — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr. Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪ talk ♪]]</sup> 14:32, 18 January 2023 (UTC)
::{{ping|Mr. Stradivarius}} Yeah, that would be the sane thing to do. That was what I initially tried, and it triggered Lua errors every time. You can try it and see: if you go into the sandbox code and do nothing but change <code>viewsSeven</code> to <code>views7</code>, then edit the table maker to call <code>views7</code>... it will flip out. I don't know if this is an insurmountable issue with Lua, or a skill issue on my part (likely the latter). If there's any way to make it just be "views7", that wold be infinitely preferable lol. '''[[User:JPxG|jp]]'''×'''[[User talk:JPxG|g]]''' 23:29, 18 January 2023 (UTC)
:::{{ping|JPxG}} I edited the sandbox to make it work. The trick was to change the pattern that detected variables like <code>${title}</code> to accept both letters and numbers - previously it only accepted letters. Best — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr. Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪ talk ♪]]</sup> 15:06, 19 January 2023 (UTC)
| |||