|
| minthreadsleft = 4
}}
== Missing options ==
Please add the new links added to {{Tl|Find sources}} here as well. – [[User:Ilovemydoodle|Ilovemydoodle]] ([[User talk:Ilovemydoodle|talk]]) 05:07, 18 August 2022 (UTC)
== Edit request 22 November 2022 ==
'''Description of suggested change:'''
Change this: Find sources: "example text" – news · newspapers · books · scholar · JSTOR (July 2012) (Learn how and when to remove this template message)
To this: Find sources: "example text" – Google (news · newspapers · books · scholar) · JSTOR (July 2012) (Learn how and when to remove this template message)
'''Diff:'''
Change this: Find sources: "example text" – news · newspapers · books · scholar · JSTOR (July 2012) (Learn how and when to remove this template message)
To this: Find sources: "example text" – Google (news · newspapers · books · scholar) · JSTOR (July 2012) (Learn how and when to remove this template message)
{{TextDiff|1=ORIGINAL_TEXT|2=CHANGED_TEXT}} [[User:Uni3993|Uni3993]] ([[User talk:Uni3993|talk]]) 01:03, 22 November 2022 (UTC)
:[[File:Red information icon with gradient background.svg|20px|link=|alt=]] '''Not done for now:''' please establish a [[Wikipedia:Consensus|consensus]] for this alteration '''[[Wikipedia:Edit requests|before]]''' using the {{Tlx|Edit template-protected}} template.<!-- Template:ETp --> '''''[[User:Paine Ellsworth|<span style="font-size:92%;color:darkblue;font-family:Segoe Script">P.I. Ellsworth</span>]]''''' , [[Editor|<span style="color:black">ed.</span>]] [[User talk:Paine Ellsworth|<sup>put'r there</sup>]] <small>03:14, 22 November 2022 (UTC)</small>
:''[[User:Uni3993|Uni3993]]'' is requesting that [[Template:Find sources mainspace]] be formatted the same way as [[Template:Find general sources]] so it's clear each link executes a different Google search. It makes sense to me. Only question is can we drop the quoted text in favor of "Google" or keep both? Otherwise, the edits to [[Module:Find sources/templates/Find sources mainspace]] are pretty straightforward. - [[User:Wikmoz|Wikmoz]] ([[User talk:Wikmoz|talk]]) 07:08, 22 November 2022 (UTC)
::{{u|Wikmoz}} I prefer my version but that version would work for me too, so who will make the change, I'm not allowed to do it. [[User:Uni3993|Uni3993]] ([[User talk:Uni3993|talk]]) 00:01, 23 November 2022 (UTC)
::So sorry, {{u|Wikmoz}}, I meant to mention Uni3993's previous TPER at [[Template talk:More citations needed#Template-protected edit request on 20 November 2022|Template talk:More citations needed]]. The TE asked that this be discussed here. So an edit request is not really warranted until more editors opine about the change. Thank you very much for your input''!'' '''''[[User:Paine Ellsworth|<span style="font-size:92%;color:darkblue;font-family:Segoe Script">P.I. Ellsworth</span>]]''''' , [[Editor|<span style="color:black">ed.</span>]] [[User talk:Paine Ellsworth|<sup>put'r there</sup>]] <small>07:46, 22 November 2022 (UTC)</small>
=== Google links with parentheses in Find sources mainspace ===
[[User:Uni3993|Uni3993]] has proposed that {{Tl|Find sources mainspace}} be formatted the same way as {{Tl|Find sources}} with respect to clearly identifying Google search links by wrapping them in parentheses.
I've applied these necessary edits in the module sandbox: [[Module:Find sources/templates/Find sources mainspace/sandbox]]. Three edits: 1. Added "Google" link; 2. Added ''separator = ' ({{hairspace}}'{{hairspace}}''; 3. Added ''afterDisplay = '{{hairspace}})''' at end of link set.
The benefit here is that the link targets are no longer ambiguous. The slight downside is that the "Google" link goes to the same target as the quoted search term. However, we're not short on space here so I don't see that as too much of a problem at all.
CURRENT: {{Tl|Find sources mainspace}}
* {{Find sources_mainspace|Albert Einstein}}
PROPOSED: {{Tl|Find sources mainspace/sandbox}} (actual edit applied in [[Module:Find sources/templates/Find sources mainspace/sandbox]])
* {{Find sources_mainspace/sandbox|Albert Einstein}}
The edits are fairly surgical so not sure how much testing is necessary. Open to feedback {{replyto|Paine Ellsworth|Mathglot|Pppery}}. - [[User:Wikmoz|Wikmoz]] ([[User talk:Wikmoz|talk]]) 20:23, 23 November 2022 (UTC)
: {{u|Wikmoz}} Looks good, maybe the quoted keyword that will be searched doesn't have to be linked to Google. That would be nice, so it would mean this keyword will be searched in Google and JSTOR and whatever service, not only Google. [[User:Uni3993|Uni3993]] ([[User talk:Uni3993|talk]]) 20:26, 23 November 2022 (UTC)
: Yes, looks good to me, too. I also think one doesn't need to link the keyword field (which could be many keywords). The "testing not necessary" makes me nervous; [[Template:Find sources mainspace/testcases]] doesn't exist, but [[Template:Find sources mainspace/sandbox]] does and already invokes the Module sandbox version; the testcases page could be easily cloned from the first two sections at [[Template:Find sources/testcases]], and if those tests pass, that should be a good indication that it's good. Adding {{ping|Primefac|Sdkb}} to ping list. [[User:Mathglot|Mathglot]] ([[User talk:Mathglot|talk]]) 21:28, 23 November 2022 (UTC)
:: I like the idea of removing the link from the quoted text. However, I think we'd have to remove the introLink and code it into the blurb, or modify the introLink code to allow plain text. I remember there was some complicated logic around repeating the article title so I'm not sure how to do this or if it's worth the effort given the additional testing that would then be required. - [[User:Wikmoz|Wikmoz]] ([[User talk:Wikmoz|talk]]) 23:46, 23 November 2022 (UTC)
== Find France sources ==
| 