Module talk:Coordinates: Difference between revisions

Revision as of 03:15, 6 June 2023

Revision as of 03:55, 6 June 2023

Line 493:

:{{done}}<!-- Template:EP --> also made the change to coord2text noted above &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 15:00, 5 June 2023 (UTC)

::{{re|BrandonXLF|MSGJ}} based on timing, it appears that this change has broken page previews. For instance, hovering over [[Free City of Danzig]] shows just the coordinates, rather than the beginning of the article as it should. I haven't looked too closely to see whether this is a bug in the module or page previews, but you ought to consider reverting. [[User:Vahurzpu|Vahurzpu]] ([[User talk:Vahurzpu|talk]]) 03:15, 6 June 2023 (UTC)

:::This needs to be done, but I favor leaving it as is for a short period to allow debugging. [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 03:54, 6 June 2023 (UTC)

I'm trying to find the documentation to see what popups needs. It starts at [[mw:Page previews]] but I don't think there is anything relevant there apart from the link to the implementation at [[mw:Special:MyLanguage/Extension:Popups]]. That has a FAQ with two items reproduced below without the links.

*How can I remove content from a page preview? Any element marked with the noexcerpt class will be stripped from the summary.

*Where do summaries come from? These are provided by the summary REST API or the TextExtracts API in case your wiki is using the default mwApiPlain gateway.

Some investigation might show why the new coordinates code is messing up the popup preview or how it can be fixed. {{u|BrandonXLF}} is not active at the moment but I'm pinging to alert them. [[User:Johnuniq|Johnuniq]] ([[User talk:Johnuniq|talk]]) 03:54, 6 June 2023 (UTC)