Content deleted Content added
m Archiving 2 discussion(s) from Template talk:WPBannerMeta) (bot |
m Archiving 1 discussion(s) from Template talk:WPBannerMeta) (bot |
||
Line 947:
::::Great, I'll let you know if I find any more bugs. [[User:DFlhb|DFlhb]] ([[User talk:DFlhb|talk]]) 16:47, 22 June 2023 (UTC)
As a demonstration of the new capabilities I have simplified [[Template:WikiProject South America]] so the 17 task forces do not need any hooks — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 21:13, 22 June 2023 (UTC)
== Mobile Issue ==
Since the recent update, no WikiProject banners are viewable on mobile, being replaced with horizontal yellow lines. This affects all WikiProjects. Please fix this quickly! [[User:QuicoleJR|QuicoleJR]] ([[User talk:QuicoleJR|talk]]) 15:22, 23 June 2023 (UTC)
:{{ping|PresN}} You seem like you know a lot about the banners. Any ideas here? [[User:QuicoleJR|QuicoleJR]] ([[User talk:QuicoleJR|talk]]) 20:44, 24 June 2023 (UTC)
::I just worked out some configuration, no idea about the code itself. Did it work before, though? There's a big template on the doc page for this template saying "This template does not display in the mobile view of Wikipedia; it is desktop only. Read the documentation for an explanation." The documentation doesn't seem to have an explanation, though? --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 00:25, 25 June 2023 (UTC)
:::That said, that warning was [https://en.wikipedia.org/w/index.php?title=Template:WPBannerMeta/doc&diff=prev&oldid=978417297 put on] by a driveby editor with no further explanation in 2020. Also, I just pulled up [[Talk:Doom (1993 video game)]], and while the wikiproject boxes don't work (just the borders with no content or height), the Vital article template does show up, as does the overall Bannershell box (but with a ''tiny'' icon, so that's a bug too). I guess, {{u|QuicoleJR}} can you verify that it was working for you on mobile before the update? {{u|MSGJ}} was your understanding that mobile is not supported for this template? --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 00:30, 25 June 2023 (UTC)
::::Ok, yeah, [[Template_talk:WPBannerMeta/Archive_10#Mobile]] says that it was suppressed on mobile as far back as 2015. So the issue is not that its broken on mobile suddenly, it's that it shows up at all. --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 00:32, 25 June 2023 (UTC)
:::::It was fully visible before the recent update. [[User:QuicoleJR|QuicoleJR]] ([[User talk:QuicoleJR|talk]]) 00:33, 25 June 2023 (UTC)
::::::Hmm, digging through the code, and it seems like the new Lua code adds class=tmbox to the wikiproject banners (so they get suppressed), but not the overall box, while the old WPBannerMeta/core subtemplate used to put it on the box overall. Don't know why it would show up for you before, though? Either way, I think that it's possibly missing on the overall box, but we should wait for MSGJ to say what they intended to happen on mobile. --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 00:38, 25 June 2023 (UTC)
:::::::There was no intention to change any of the display. I will have a look through the code now. — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 18:37, 25 June 2023 (UTC)
:::::::Please clarify what you mean by "the box overall". Which line of code are you looking at? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 18:50, 25 June 2023 (UTC)
::::::::Just wondering if it's anything to do with [[Module:WikiProject_banner#L-579|line 579]]? -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 22:37, 25 June 2023 (UTC)
:::::::::Not sure where the css('height', '0') came from - looks like it can safely be removed. I can't see any difference in mobile view. @[[User:QuicoleJR|QuicoleJR]]: any chance of a screenshot to show what you are seeing? Which browser are you using, etc.? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:23, 26 June 2023 (UTC)
::::::::::{{multiple image |align = right |image1 = Thin line WPBM banners - inside WPBS.jpg |caption1 = At [[Talk:Doom (1993 video game)]], WP banners inside shell appear as thin lines, just below vital banner. |image2 = Thin line WPBM banners - outside WPBS.jpg |caption2 = At this talk page, the only WP banner appear as thin line, between {{tl|central}} and number of formatting errors. |footer_align=center |footer = Demonstration of thin line problems. }}
::::::::::@[[User:MSGJ|MSGJ]]: Here are some screenshots. <span class="nowrap">—'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 08:00, 26 June 2023 (UTC)
:::::::::::Thanks for that, very helpful. Not seeing anything like that on Chrome for mobile. What browser is that? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 08:04, 26 June 2023 (UTC)
::::::::::::I'm on Chrome version 113.0.5672.132 on Android 13, Samsung Galaxy M13 5G. <span class="nowrap">—'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 08:07, 26 June 2023 (UTC)
::::::::::::BTW, I use the Google app. Not Chrome, just plain Google. [[User:QuicoleJR|QuicoleJR]] ([[User talk:QuicoleJR|talk]]) 14:14, 26 June 2023 (UTC)
::::::::{{re|MSGJ}} I'm wrong, I was referring to how [[Template:WPBannerMeta/core]] puts the tmbox css class on the table element itself and I didn't see that in the Lua code, but it's there in the actual html so I must have just missed it. --'''[[User:PresN|<span style="color:green">Pres</span>]][[User talk:PresN|<span style="color:blue">N</span>]]''' 00:19, 26 June 2023 (UTC)
{{ping|MSGJ|PresN}} It appears to be working now. Thanks for the help! [[User:QuicoleJR|QuicoleJR]] ([[User talk:QuicoleJR|talk]]) 14:18, 26 June 2023 (UTC)
:The only thing I changed was to remove the css('height', '0') so you can thank @[[User:WOSlinker|WOSlinker]] for that — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 14:32, 26 June 2023 (UTC)
| |||