Content deleted Content added
m Archiving 1 discussion(s) from Template talk:WPBannerMeta) (bot |
m Archiving 1 discussion(s) from Template talk:WPBannerMeta) (bot |
||
Line 116:
:I'm not crazy, we did have such a warning [[Template:WPBannerMeta/templatepage/sandbox|before]].  <span style="font-variant:small-caps; whitespace:nowrap;">[[User:Headbomb|Headbomb]] {[[User talk:Headbomb|t]] · [[Special:Contributions/Headbomb|c]] · [[WP:PHYS|p]] · [[WP:WBOOKS|b]]}</span> 14:04, 15 July 2023 (UTC)
:Yeah, this is a reasonable warning that should be shown to editors because lots of stuffs can break if changes aren't done correctly. <span class="nowrap">—'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 21:00, 18 July 2023 (UTC)
== Note parameter change in behaviour ==
It appears that the {{para|note ''n''}} parameters have changed behaviour during or after the recent conversion to Lua. Previously, non-blank values that didn't evaluate to <code>no</code> would be treated as if they were <code>yes</code> but now an explicit <code>yes</code> seems to be required. Consider [[Template:WikiProject UK geography]] which has <syntaxhighlight lang=mediawiki>|note 2={{{photo|}}}
|NOTE_2_TEXT = This article needs a photo.
|NOTE_2_IMAGE = Icon tools.svg
|NOTE_2_CAT = Wikipedia requested photographs in {{#ifexist:Category:Wikipedia requested photographs in {{{photo}}}|{{{photo}}}|the United Kingdom}}</syntaxhighlight> which is documented as
*'''photo''' – use {{para|photo|yes}} to indicate that the article requires a photograph. Values other than {{para|photo|yes}} or {{para|photo|no}} may be used for categorisation, if a matching category exists of the form <code>Category:Wikipedia requested photographs in ''photo''</code>; this will normally be a county, but some smaller areas are also permitted. For example:
**{{para|photo|yes}} → {{cl|Wikipedia requested photographs in the United Kingdom}}
**{{para|photo|England}} → {{cl|Wikipedia requested photographs in England}}
**{{para|photo|the West Midlands (county)}} → {{cl|Wikipedia requested photographs in the West Midlands (county)}}
**{{para|photo|Birmingham}} → {{cl|Wikipedia requested photographs in Birmingham}}
**{{para|photo|Edgbaston}} → {{cl|Wikipedia requested photographs in the United Kingdom}}
and this worked just fine until the recent conversion to Lua. Now, setting {{para|photo|England}} does nothing, it only recognises {{para|photo|yes}}. Can the previous behaviour please be restored? --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] 🌹 ([[User talk:Redrose64|talk]]) 18:44, 18 July 2023 (UTC)
:You are right, we are using [[Module:Yesno]] for this logic now. It can be restored to previous behaviour. Just to check though, do we want {{para|attention|no}} to trigger or not? Would a trigger for any non-negative value be a good implementation? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 21:49, 18 July 2023 (UTC)
:This is now implemented in the sandbox. To be clear ''no'', ''n'', ''false'', ''f'', ''off'', ''0'' and blank will not trigger but any other input will trigger. This change will apply to the attention note, the infobox-needed note, all the custom notes and all the task forces. Does that sound right? — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:29, 19 July 2023 (UTC)
::No other comments so this is {{done}} — Martin <small>([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]])</small> 07:17, 20 July 2023 (UTC)
:::{{ty}} --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] 🌹 ([[User talk:Redrose64|talk]]) 17:48, 20 July 2023 (UTC)
| |||