Module talk:WikiProject banner/Archive 14: Difference between revisions

Content deleted Content added
m Archiving 2 discussion(s) from Template talk:WPBannerMeta) (bot
m Archiving 1 discussion(s) from Template talk:WPBannerMeta) (bot
Line 198:
:::::Okay this change will need to be made in [[Module:Class mask]]. Should WT:COUNCIL be notified first? &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 23:04, 25 July 2023 (UTC)
::::::Feel free to, but I'd recommend reaching out to WP:FILM and maybe 1-2 more of the biggest projects that use B-criteria, since few people watch WP:COUNCIL [[User:DFlhb|DFlhb]] ([[User talk:DFlhb|talk]]) 23:42, 25 July 2023 (UTC)
 
== Padding on right image ==
 
{{WikiProject Seventh-day Adventist Church/sandbox|category=no|class=start}}
Not many banners use {{para|IMAGE_RIGHT}} but I noticed yesterday on [[Template:WikiProject Seventh-day Adventist Church]] that this is no padding on the right side of the image. Anyone know how to fix? &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 06:20, 27 July 2023 (UTC)
 
:At [[Module:WikiProject_banner/styles.css#L-44]]: .wpb-main { padding: 3px 0 3px 5px; }, so there is a top/bottom-padding=3px, left-padding=5px, right-padding=0. At [[Module:WikiProject_banner/styles.css#L-60]]: .wpb-image { padding: 2px 0; }, so top/bottom-padding=2px, left/right-padding=0. Both the images use .wpb-image class, so on the left of left-image, we have 5+0=5px padding, on the right of right-image 0+0=0px. <span class="nowrap">&#8212;'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 07:04, 27 July 2023 (UTC)
::Lack of right-padding on .wpb-main is also visible when you expand the To-do list. The left border is thicker than the right. <span class="nowrap">&#8212;'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 07:08, 27 July 2023 (UTC)
::<s>So changing [[Module:WikiProject_banner/styles.css#L-44]] to .wpb-main { padding: 3px 5px 3px 5px; }, should do it then?</s> Looks like it (sandbox shown above)! That was an easy fix ... &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 12:50, 27 July 2023 (UTC)
:::.wpb-main { padding: 3px 5px; } would render the same results (and is shorter). By the way, I've noticed that .wpb-imageright is a class defined in L-64 of the css, but this class is not applied on the right-image. Is there any element using it, or may it be removed from stylesheet? <span class="nowrap">&#8212;'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 13:17, 27 July 2023 (UTC)
::::A search in the code for wpb-imageright does not bring anything, so I guess it's not being used at the moment. Do we need it? &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 15:44, 27 July 2023 (UTC)
:::::Perhaps not, because nothing is assigning this class as far as I see. <span class="nowrap">&#8212;'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 18:13, 27 July 2023 (UTC)
::::::Okay I've removed it &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 18:31, 27 July 2023 (UTC)